diff --git a/docs/design/multi-spaces.md b/docs/design/multi-spaces.md
index b5806db2..bf6bffb1 100644
--- a/docs/design/multi-spaces.md
+++ b/docs/design/multi-spaces.md
@@ -35,7 +35,7 @@ Every memo remains an author-owned, independent resource. Placement, audience, a
- Space archival or restoration.
- Guests, email or external-user invitations, open enrollment, federation, or public Space discovery.
- A generated default Space.
-- UI/UX design or a redesign of global surfaces.
+- Re-scoping user-global surfaces such as Inbox and user profiles around a Space.
## Research
@@ -52,7 +52,7 @@ The research supports four choices:
- Make Space one first-class resource with explicit membership and roles, gated by invitee acceptance.
- Keep placement, audience, authorship, and distribution independent.
- Represent Unassigned as a real absence of placement.
-- Eventually make Spaces visible in normal browsing and creation flows, while deferring UI/UX here.
+- Make Spaces visible in normal browsing, creation, and management flows while keeping user-global surfaces independent of the current Space.
Sources: [Discourse category permissions](https://meta.discourse.org/t/understanding-groups-and-category-permissions/87678), [Discourse post ownership](https://meta.discourse.org/t/changing-ownership-of-posts/276672), [Notion Teamspaces](https://www.notion.com/help/intro-to-teamspaces), [Notion sharing and permissions](https://www.notion.com/help/sharing-and-permissions), [Mastodon post visibility](https://docs.joinmastodon.org/user/posting/), and [Mastodon Lists](https://docs.joinmastodon.org/entities/List/).
@@ -158,6 +158,8 @@ A dedicated Space service provides create, list, get, update, and hard-delete op
Listing Spaces returns only Spaces in which the caller has active membership; no application-wide Space listing or archive API is added. An authenticated non-member, including a pending invitee, receives `NotFound` for Space metadata, members, and feed requests.
+Space responses returned through membership-authorized operations include the authenticated user's membership role and the accepted-member count as output-only projections. Metadata-only Space summaries, such as the summary carried by an invitation, use the default role and count values.
+
Memo responses gain an optional Space resource name, and `Visibility` adds `SPACE = 4` without renumbering existing values. The domain-to-v1 mapping is Author to `PRIVATE`, Instance to `PROTECTED`, Public to `PUBLIC`, and Space to `SPACE`. `VISIBILITY_UNSPECIFIED` remains an input sentinel: create treats it as `PRIVATE`, an explicit visibility update rejects it, and responses never return it. Visibility values are named domains and must not be compared numerically. The global default memo visibility setting continues to accept only `PRIVATE`, `PROTECTED`, and `PUBLIC`, because it cannot identify a Space.
Memo listing gains explicit all-readable, Unassigned, and Space scopes. Space scope requires active membership. Existing global and Space feeds exclude comments by default, and Space identity is not added to the CEL filter schema.
@@ -166,6 +168,10 @@ Placement and audience use the existing memo update mechanism so the memo author
MCP memo operations reuse the same memo policy; Space management is not exposed through MCP in the initial version.
+### UI shape
+
+The active Space scopes collaborative resource browsing and creation, including Home and attachment lists. Inbox and user profiles remain user-global and their routes do not inherit the active Space. Global Settings provides a Spaces section for viewing received invitations and managing joined Spaces, metadata, members, roles, and pending invitations; it is a management surface rather than another Space switcher.
+
### Security invariants
Before `SPACE` can be stored, one shared, memo-local, fail-closed policy must cover point reads, lists and counts, files, reactions, relations, notifications, email, webhooks, shares, search, statistics, public feeds, and MCP. Child resources resolve the memo they directly belong to. Application `ADMIN` receives no implicit bypass.
@@ -181,7 +187,7 @@ OR SPACE + active membership in memo.space_id
CEL filters may only narrow this predicate. Space membership is checked per request or through immediately invalidated cache state. Write paths validate membership and placement as part of their ordinary operation. Missing or unreadable notification subjects and relation endpoints fail closed without leaking partial metadata. Broader serialization between concurrent membership, placement, and memo mutations remains deferred.
-Live refresh is an authenticated, subject-free cache-invalidation channel. Successful memo, reaction, Space, invitation, and membership mutations broadcast only `{"type":"memo.changed"}` to connected clients. The event carries no resource name, audience, actor, invitation, or membership data; clients invalidate memo-backed caches and refetch through ordinary authorization. SSE does not materialize recipient sets or perform memo-level authorization.
+Live refresh is an authenticated, subject-free cache-invalidation channel. Successful memo and reaction mutations broadcast `{"type":"memo.changed"}`; successful Space, invitation, and membership mutations broadcast `{"type":"space.changed"}`. Neither event carries a resource name, audience, actor, invitation, or membership data. Clients invalidate the corresponding Space- and memo-backed caches and refetch through ordinary authorization. SSE does not materialize recipient sets or perform memo-level authorization.
Notifications are authorized when presented. Email and user webhook payloads are authorized before entering the existing asynchronous queue; the initial version does not cancel a prepared delivery when access changes while it is queued. A comment webhook requires both the comment and its context memo to be readable by the webhook owner when the event is prepared. A deleted-memo webhook is built only from an author-readable pre-delete snapshot.
@@ -207,6 +213,4 @@ Files for `PRIVATE`, `PROTECTED`, and `SPACE` memos use `private, no-store`; pub
## Deferred design
-UI/UX is explicitly out of scope, including navigation, editor controls, membership screens, warnings, and confirmation flows.
-
Email and external-user invitations, invitation expiration, inviter attribution, invitation history, open enrollment, account erasure beyond the membership guard, notification delivery and retention policy, application-admin moderation and recovery, audit history, soft deletion, restoration, retryable external-object cleanup, delivery-time cancellation of queued email/webhooks, broader concurrent-mutation hardening, and asynchronous deletion of very large Spaces remain deferred. Later work must preserve invitee consent, independent memo authorization, non-propagating relations, and explicit Space aggregate deletion unless this design is revisited.
diff --git a/proto/api/v1/space_service.proto b/proto/api/v1/space_service.proto
index 54fac983..22b4f339 100644
--- a/proto/api/v1/space_service.proto
+++ b/proto/api/v1/space_service.proto
@@ -149,6 +149,14 @@ message Space {
// Optional. A description of the space.
string description = 3 [(google.api.field_behavior) = OPTIONAL];
+
+ // Output only. The authenticated user's membership role in this space.
+ // ROLE_UNSPECIFIED when this Space is exposed as metadata-only.
+ SpaceMember.Role current_user_role = 4 [(google.api.field_behavior) = OUTPUT_ONLY];
+
+ // Output only. The number of accepted members in this space. Pending
+ // invitations are excluded. Zero when this Space is exposed as metadata-only.
+ int32 member_count = 5 [(google.api.field_behavior) = OUTPUT_ONLY];
}
// SpaceMember is a user's membership and governance role in a space.
diff --git a/proto/gen/api/v1/space_service.pb.go b/proto/gen/api/v1/space_service.pb.go
index 62337726..aa5ddbbc 100644
--- a/proto/gen/api/v1/space_service.pb.go
+++ b/proto/gen/api/v1/space_service.pb.go
@@ -81,7 +81,13 @@ type Space struct {
// Required. The human-readable title.
Title string `protobuf:"bytes,2,opt,name=title,proto3" json:"title,omitempty"`
// Optional. A description of the space.
- Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
+ Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
+ // Output only. The authenticated user's membership role in this space.
+ // ROLE_UNSPECIFIED when this Space is exposed as metadata-only.
+ CurrentUserRole SpaceMember_Role `protobuf:"varint,4,opt,name=current_user_role,json=currentUserRole,proto3,enum=memos.api.v1.SpaceMember_Role" json:"current_user_role,omitempty"`
+ // Output only. The number of accepted members in this space. Pending
+ // invitations are excluded. Zero when this Space is exposed as metadata-only.
+ MemberCount int32 `protobuf:"varint,5,opt,name=member_count,json=memberCount,proto3" json:"member_count,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -137,6 +143,20 @@ func (x *Space) GetDescription() string {
return ""
}
+func (x *Space) GetCurrentUserRole() SpaceMember_Role {
+ if x != nil {
+ return x.CurrentUserRole
+ }
+ return SpaceMember_ROLE_UNSPECIFIED
+}
+
+func (x *Space) GetMemberCount() int32 {
+ if x != nil {
+ return x.MemberCount
+ }
+ return 0
+}
+
// SpaceMember is a user's membership and governance role in a space.
type SpaceMember struct {
state protoimpl.MessageState `protogen:"open.v1"`
@@ -1306,11 +1326,13 @@ var File_api_v1_space_service_proto protoreflect.FileDescriptor
const file_api_v1_space_service_proto_rawDesc = "" +
"\n" +
- "\x1aapi/v1/space_service.proto\x12\fmemos.api.v1\x1a\x1cgoogle/api/annotations.proto\x1a\x17google/api/client.proto\x1a\x1fgoogle/api/field_behavior.proto\x1a\x19google/api/resource.proto\x1a\x1bgoogle/protobuf/empty.proto\x1a google/protobuf/field_mask.proto\"\xa0\x01\n" +
+ "\x1aapi/v1/space_service.proto\x12\fmemos.api.v1\x1a\x1cgoogle/api/annotations.proto\x1a\x17google/api/client.proto\x1a\x1fgoogle/api/field_behavior.proto\x1a\x19google/api/resource.proto\x1a\x1bgoogle/protobuf/empty.proto\x1a google/protobuf/field_mask.proto\"\x99\x02\n" +
"\x05Space\x12\x17\n" +
"\x04name\x18\x01 \x01(\tB\x03\xe0A\bR\x04name\x12\x19\n" +
"\x05title\x18\x02 \x01(\tB\x03\xe0A\x02R\x05title\x12%\n" +
- "\vdescription\x18\x03 \x01(\tB\x03\xe0A\x01R\vdescription:<\xeaA9\n" +
+ "\vdescription\x18\x03 \x01(\tB\x03\xe0A\x01R\vdescription\x12O\n" +
+ "\x11current_user_role\x18\x04 \x01(\x0e2\x1e.memos.api.v1.SpaceMember.RoleB\x03\xe0A\x03R\x0fcurrentUserRole\x12&\n" +
+ "\fmember_count\x18\x05 \x01(\x05B\x03\xe0A\x03R\vmemberCount:<\xeaA9\n" +
"\x12memos.api.v1/Space\x12\x0espaces/{space}\x1a\x04name*\x06spaces2\x05space\"\xa2\x02\n" +
"\vSpaceMember\x12\x17\n" +
"\x04name\x18\x01 \x01(\tB\x03\xe0A\bR\x04name\x12-\n" +
@@ -1462,56 +1484,57 @@ var file_api_v1_space_service_proto_goTypes = []any{
(*emptypb.Empty)(nil), // 25: google.protobuf.Empty
}
var file_api_v1_space_service_proto_depIdxs = []int32{
- 0, // 0: memos.api.v1.SpaceMember.role:type_name -> memos.api.v1.SpaceMember.Role
- 0, // 1: memos.api.v1.SpaceInvitation.role:type_name -> memos.api.v1.SpaceMember.Role
- 1, // 2: memos.api.v1.SpaceInvitation.space:type_name -> memos.api.v1.Space
- 1, // 3: memos.api.v1.CreateSpaceRequest.space:type_name -> memos.api.v1.Space
- 1, // 4: memos.api.v1.ListSpacesResponse.spaces:type_name -> memos.api.v1.Space
- 1, // 5: memos.api.v1.UpdateSpaceRequest.space:type_name -> memos.api.v1.Space
- 24, // 6: memos.api.v1.UpdateSpaceRequest.update_mask:type_name -> google.protobuf.FieldMask
- 3, // 7: memos.api.v1.CreateSpaceInvitationRequest.space_invitation:type_name -> memos.api.v1.SpaceInvitation
- 3, // 8: memos.api.v1.ListSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation
- 3, // 9: memos.api.v1.ListUserSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation
- 2, // 10: memos.api.v1.ListSpaceMembersResponse.space_members:type_name -> memos.api.v1.SpaceMember
- 2, // 11: memos.api.v1.UpdateSpaceMemberRequest.space_member:type_name -> memos.api.v1.SpaceMember
- 24, // 12: memos.api.v1.UpdateSpaceMemberRequest.update_mask:type_name -> google.protobuf.FieldMask
- 4, // 13: memos.api.v1.SpaceService.CreateSpace:input_type -> memos.api.v1.CreateSpaceRequest
- 5, // 14: memos.api.v1.SpaceService.ListSpaces:input_type -> memos.api.v1.ListSpacesRequest
- 7, // 15: memos.api.v1.SpaceService.GetSpace:input_type -> memos.api.v1.GetSpaceRequest
- 8, // 16: memos.api.v1.SpaceService.UpdateSpace:input_type -> memos.api.v1.UpdateSpaceRequest
- 9, // 17: memos.api.v1.SpaceService.DeleteSpace:input_type -> memos.api.v1.DeleteSpaceRequest
- 10, // 18: memos.api.v1.SpaceService.CreateSpaceInvitation:input_type -> memos.api.v1.CreateSpaceInvitationRequest
- 11, // 19: memos.api.v1.SpaceService.ListSpaceInvitations:input_type -> memos.api.v1.ListSpaceInvitationsRequest
- 13, // 20: memos.api.v1.SpaceService.ListUserSpaceInvitations:input_type -> memos.api.v1.ListUserSpaceInvitationsRequest
- 15, // 21: memos.api.v1.SpaceService.GetSpaceInvitation:input_type -> memos.api.v1.GetSpaceInvitationRequest
- 16, // 22: memos.api.v1.SpaceService.DeleteSpaceInvitation:input_type -> memos.api.v1.DeleteSpaceInvitationRequest
- 17, // 23: memos.api.v1.SpaceService.AcceptSpaceInvitation:input_type -> memos.api.v1.AcceptSpaceInvitationRequest
- 18, // 24: memos.api.v1.SpaceService.DeclineSpaceInvitation:input_type -> memos.api.v1.DeclineSpaceInvitationRequest
- 19, // 25: memos.api.v1.SpaceService.ListSpaceMembers:input_type -> memos.api.v1.ListSpaceMembersRequest
- 21, // 26: memos.api.v1.SpaceService.GetSpaceMember:input_type -> memos.api.v1.GetSpaceMemberRequest
- 22, // 27: memos.api.v1.SpaceService.UpdateSpaceMember:input_type -> memos.api.v1.UpdateSpaceMemberRequest
- 23, // 28: memos.api.v1.SpaceService.DeleteSpaceMember:input_type -> memos.api.v1.DeleteSpaceMemberRequest
- 1, // 29: memos.api.v1.SpaceService.CreateSpace:output_type -> memos.api.v1.Space
- 6, // 30: memos.api.v1.SpaceService.ListSpaces:output_type -> memos.api.v1.ListSpacesResponse
- 1, // 31: memos.api.v1.SpaceService.GetSpace:output_type -> memos.api.v1.Space
- 1, // 32: memos.api.v1.SpaceService.UpdateSpace:output_type -> memos.api.v1.Space
- 25, // 33: memos.api.v1.SpaceService.DeleteSpace:output_type -> google.protobuf.Empty
- 3, // 34: memos.api.v1.SpaceService.CreateSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation
- 12, // 35: memos.api.v1.SpaceService.ListSpaceInvitations:output_type -> memos.api.v1.ListSpaceInvitationsResponse
- 14, // 36: memos.api.v1.SpaceService.ListUserSpaceInvitations:output_type -> memos.api.v1.ListUserSpaceInvitationsResponse
- 3, // 37: memos.api.v1.SpaceService.GetSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation
- 25, // 38: memos.api.v1.SpaceService.DeleteSpaceInvitation:output_type -> google.protobuf.Empty
- 2, // 39: memos.api.v1.SpaceService.AcceptSpaceInvitation:output_type -> memos.api.v1.SpaceMember
- 25, // 40: memos.api.v1.SpaceService.DeclineSpaceInvitation:output_type -> google.protobuf.Empty
- 20, // 41: memos.api.v1.SpaceService.ListSpaceMembers:output_type -> memos.api.v1.ListSpaceMembersResponse
- 2, // 42: memos.api.v1.SpaceService.GetSpaceMember:output_type -> memos.api.v1.SpaceMember
- 2, // 43: memos.api.v1.SpaceService.UpdateSpaceMember:output_type -> memos.api.v1.SpaceMember
- 25, // 44: memos.api.v1.SpaceService.DeleteSpaceMember:output_type -> google.protobuf.Empty
- 29, // [29:45] is the sub-list for method output_type
- 13, // [13:29] is the sub-list for method input_type
- 13, // [13:13] is the sub-list for extension type_name
- 13, // [13:13] is the sub-list for extension extendee
- 0, // [0:13] is the sub-list for field type_name
+ 0, // 0: memos.api.v1.Space.current_user_role:type_name -> memos.api.v1.SpaceMember.Role
+ 0, // 1: memos.api.v1.SpaceMember.role:type_name -> memos.api.v1.SpaceMember.Role
+ 0, // 2: memos.api.v1.SpaceInvitation.role:type_name -> memos.api.v1.SpaceMember.Role
+ 1, // 3: memos.api.v1.SpaceInvitation.space:type_name -> memos.api.v1.Space
+ 1, // 4: memos.api.v1.CreateSpaceRequest.space:type_name -> memos.api.v1.Space
+ 1, // 5: memos.api.v1.ListSpacesResponse.spaces:type_name -> memos.api.v1.Space
+ 1, // 6: memos.api.v1.UpdateSpaceRequest.space:type_name -> memos.api.v1.Space
+ 24, // 7: memos.api.v1.UpdateSpaceRequest.update_mask:type_name -> google.protobuf.FieldMask
+ 3, // 8: memos.api.v1.CreateSpaceInvitationRequest.space_invitation:type_name -> memos.api.v1.SpaceInvitation
+ 3, // 9: memos.api.v1.ListSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation
+ 3, // 10: memos.api.v1.ListUserSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation
+ 2, // 11: memos.api.v1.ListSpaceMembersResponse.space_members:type_name -> memos.api.v1.SpaceMember
+ 2, // 12: memos.api.v1.UpdateSpaceMemberRequest.space_member:type_name -> memos.api.v1.SpaceMember
+ 24, // 13: memos.api.v1.UpdateSpaceMemberRequest.update_mask:type_name -> google.protobuf.FieldMask
+ 4, // 14: memos.api.v1.SpaceService.CreateSpace:input_type -> memos.api.v1.CreateSpaceRequest
+ 5, // 15: memos.api.v1.SpaceService.ListSpaces:input_type -> memos.api.v1.ListSpacesRequest
+ 7, // 16: memos.api.v1.SpaceService.GetSpace:input_type -> memos.api.v1.GetSpaceRequest
+ 8, // 17: memos.api.v1.SpaceService.UpdateSpace:input_type -> memos.api.v1.UpdateSpaceRequest
+ 9, // 18: memos.api.v1.SpaceService.DeleteSpace:input_type -> memos.api.v1.DeleteSpaceRequest
+ 10, // 19: memos.api.v1.SpaceService.CreateSpaceInvitation:input_type -> memos.api.v1.CreateSpaceInvitationRequest
+ 11, // 20: memos.api.v1.SpaceService.ListSpaceInvitations:input_type -> memos.api.v1.ListSpaceInvitationsRequest
+ 13, // 21: memos.api.v1.SpaceService.ListUserSpaceInvitations:input_type -> memos.api.v1.ListUserSpaceInvitationsRequest
+ 15, // 22: memos.api.v1.SpaceService.GetSpaceInvitation:input_type -> memos.api.v1.GetSpaceInvitationRequest
+ 16, // 23: memos.api.v1.SpaceService.DeleteSpaceInvitation:input_type -> memos.api.v1.DeleteSpaceInvitationRequest
+ 17, // 24: memos.api.v1.SpaceService.AcceptSpaceInvitation:input_type -> memos.api.v1.AcceptSpaceInvitationRequest
+ 18, // 25: memos.api.v1.SpaceService.DeclineSpaceInvitation:input_type -> memos.api.v1.DeclineSpaceInvitationRequest
+ 19, // 26: memos.api.v1.SpaceService.ListSpaceMembers:input_type -> memos.api.v1.ListSpaceMembersRequest
+ 21, // 27: memos.api.v1.SpaceService.GetSpaceMember:input_type -> memos.api.v1.GetSpaceMemberRequest
+ 22, // 28: memos.api.v1.SpaceService.UpdateSpaceMember:input_type -> memos.api.v1.UpdateSpaceMemberRequest
+ 23, // 29: memos.api.v1.SpaceService.DeleteSpaceMember:input_type -> memos.api.v1.DeleteSpaceMemberRequest
+ 1, // 30: memos.api.v1.SpaceService.CreateSpace:output_type -> memos.api.v1.Space
+ 6, // 31: memos.api.v1.SpaceService.ListSpaces:output_type -> memos.api.v1.ListSpacesResponse
+ 1, // 32: memos.api.v1.SpaceService.GetSpace:output_type -> memos.api.v1.Space
+ 1, // 33: memos.api.v1.SpaceService.UpdateSpace:output_type -> memos.api.v1.Space
+ 25, // 34: memos.api.v1.SpaceService.DeleteSpace:output_type -> google.protobuf.Empty
+ 3, // 35: memos.api.v1.SpaceService.CreateSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation
+ 12, // 36: memos.api.v1.SpaceService.ListSpaceInvitations:output_type -> memos.api.v1.ListSpaceInvitationsResponse
+ 14, // 37: memos.api.v1.SpaceService.ListUserSpaceInvitations:output_type -> memos.api.v1.ListUserSpaceInvitationsResponse
+ 3, // 38: memos.api.v1.SpaceService.GetSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation
+ 25, // 39: memos.api.v1.SpaceService.DeleteSpaceInvitation:output_type -> google.protobuf.Empty
+ 2, // 40: memos.api.v1.SpaceService.AcceptSpaceInvitation:output_type -> memos.api.v1.SpaceMember
+ 25, // 41: memos.api.v1.SpaceService.DeclineSpaceInvitation:output_type -> google.protobuf.Empty
+ 20, // 42: memos.api.v1.SpaceService.ListSpaceMembers:output_type -> memos.api.v1.ListSpaceMembersResponse
+ 2, // 43: memos.api.v1.SpaceService.GetSpaceMember:output_type -> memos.api.v1.SpaceMember
+ 2, // 44: memos.api.v1.SpaceService.UpdateSpaceMember:output_type -> memos.api.v1.SpaceMember
+ 25, // 45: memos.api.v1.SpaceService.DeleteSpaceMember:output_type -> google.protobuf.Empty
+ 30, // [30:46] is the sub-list for method output_type
+ 14, // [14:30] is the sub-list for method input_type
+ 14, // [14:14] is the sub-list for extension type_name
+ 14, // [14:14] is the sub-list for extension extendee
+ 0, // [0:14] is the sub-list for field type_name
}
func init() { file_api_v1_space_service_proto_init() }
diff --git a/proto/gen/openapi.yaml b/proto/gen/openapi.yaml
index 64db8508..65dfa8d5 100644
--- a/proto/gen/openapi.yaml
+++ b/proto/gen/openapi.yaml
@@ -4376,6 +4376,24 @@ components:
description:
type: string
description: Optional. A description of the space.
+ currentUserRole:
+ readOnly: true
+ enum:
+ - ROLE_UNSPECIFIED
+ - ADMIN
+ - USER
+ type: string
+ description: |-
+ Output only. The authenticated user's membership role in this space.
+ ROLE_UNSPECIFIED when this Space is exposed as metadata-only.
+ format: enum
+ memberCount:
+ readOnly: true
+ type: integer
+ description: |-
+ Output only. The number of accepted members in this space. Pending
+ invitations are excluded. Zero when this Space is exposed as metadata-only.
+ format: int32
description: Space is a collaboration boundary for placed memos.
SpaceInvitation:
required:
diff --git a/server/router/api/v1/space_service.go b/server/router/api/v1/space_service.go
index cd326fd8..ea80868a 100644
--- a/server/router/api/v1/space_service.go
+++ b/server/router/api/v1/space_service.go
@@ -106,7 +106,7 @@ func (s *APIV1Service) CreateSpace(ctx context.Context, request *v1pb.CreateSpac
if err != nil {
return nil, mapSpaceMutationError(err, "failed to create space")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return convertSpaceFromStore(created), nil
}
@@ -212,7 +212,7 @@ func (s *APIV1Service) UpdateSpace(ctx context.Context, request *v1pb.UpdateSpac
if updated == nil {
return nil, status.Error(codes.NotFound, "space not found")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return convertSpaceFromStore(updated), nil
}
@@ -234,7 +234,7 @@ func (s *APIV1Service) DeleteSpace(ctx context.Context, request *v1pb.DeleteSpac
if err != nil {
return nil, mapSpaceMutationError(err, "failed to delete space")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
if err := s.cleanupDeletedAttachmentStorage(ctx, deleteResult.Attachments); err != nil {
return nil, status.Errorf(codes.Internal, "space was deleted but attachment storage cleanup failed: %v", err)
}
@@ -288,7 +288,7 @@ func (s *APIV1Service) CreateSpaceInvitation(ctx context.Context, request *v1pb.
if err != nil {
return nil, mapSpaceMutationError(err, "failed to create space invitation")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return convertSpaceInvitationFromStore(space, targetUser, created), nil
}
@@ -500,7 +500,7 @@ func (s *APIV1Service) DeleteSpaceInvitation(ctx context.Context, request *v1pb.
}, currentUser.ID); err != nil {
return nil, mapSpaceMutationError(err, "failed to revoke space invitation")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return &emptypb.Empty{}, nil
}
@@ -522,7 +522,7 @@ func (s *APIV1Service) AcceptSpaceInvitation(ctx context.Context, request *v1pb.
if err != nil {
return nil, mapSpaceMutationError(err, "failed to accept space invitation")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return convertSpaceMemberFromStore(space, currentUser, member), nil
}
@@ -543,7 +543,7 @@ func (s *APIV1Service) DeclineSpaceInvitation(ctx context.Context, request *v1pb
if err := s.Store.DeclineSpaceInvitation(ctx, &store.DeclineSpaceInvitation{SpaceID: invitation.SpaceID, UserID: currentUser.ID}, currentUser.ID); err != nil {
return nil, mapSpaceMutationError(err, "failed to decline space invitation")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return &emptypb.Empty{}, nil
}
@@ -712,7 +712,7 @@ func (s *APIV1Service) UpdateSpaceMember(ctx context.Context, request *v1pb.Upda
if updated == nil {
return nil, status.Error(codes.NotFound, "space member not found")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return convertSpaceMemberFromStore(space, targetUser, updated), nil
}
@@ -738,6 +738,6 @@ func (s *APIV1Service) DeleteSpaceMember(ctx context.Context, request *v1pb.Dele
}, currentUser.ID); err != nil {
return nil, mapSpaceMutationError(err, "failed to delete space member")
}
- s.SSEHub.publishMemoChanged()
+ s.SSEHub.publishSpaceChanged()
return &emptypb.Empty{}, nil
}
diff --git a/server/router/api/v1/space_service_converters.go b/server/router/api/v1/space_service_converters.go
index 14b7cdce..7bda669f 100644
--- a/server/router/api/v1/space_service_converters.go
+++ b/server/router/api/v1/space_service_converters.go
@@ -18,6 +18,16 @@ func buildSpaceInvitationName(spaceUID, username string) string {
}
func convertSpaceFromStore(space *store.Space) *v1pb.Space {
+ converted := convertSpaceMetadataFromStore(space)
+ if converted == nil {
+ return nil
+ }
+ converted.CurrentUserRole = convertSpaceMemberRoleFromStore(space.CurrentUserRole)
+ converted.MemberCount = space.MemberCount
+ return converted
+}
+
+func convertSpaceMetadataFromStore(space *store.Space) *v1pb.Space {
if space == nil {
return nil
}
@@ -69,6 +79,6 @@ func convertSpaceInvitationFromStore(space *store.Space, user *store.User, invit
Name: buildSpaceInvitationName(space.UID, user.Username),
Invitee: BuildUserName(user.Username),
Role: convertSpaceMemberRoleFromStore(invitation.Role),
- Space: convertSpaceFromStore(space),
+ Space: convertSpaceMetadataFromStore(space),
}
}
diff --git a/server/router/api/v1/space_service_test.go b/server/router/api/v1/space_service_test.go
index 10c77a92..34d7dad5 100644
--- a/server/router/api/v1/space_service_test.go
+++ b/server/router/api/v1/space_service_test.go
@@ -66,6 +66,8 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) {
require.NoError(t, err)
require.Equal(t, "spaces/team-notes", space.Name)
require.Equal(t, "Team notes", space.Title)
+ require.Equal(t, v1pb.SpaceMember_ADMIN, space.CurrentUserRole)
+ require.Equal(t, int32(1), space.MemberCount)
_, err = service.CreateSpace(userCtx(ctx, owner.ID), &v1pb.CreateSpaceRequest{
SpaceId: "team-notes",
Space: &v1pb.Space{Title: "Duplicate"},
@@ -89,7 +91,11 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) {
})
require.NoError(t, err)
require.Equal(t, "spaces/team-notes/invitations/space-member", invitation.Name)
- require.Equal(t, space, invitation.Space, "the invitation must identify the Space without granting membership access")
+ require.Equal(t, space.Name, invitation.Space.Name, "the invitation must identify the Space without granting membership access")
+ require.Equal(t, space.Title, invitation.Space.Title)
+ require.Equal(t, space.Description, invitation.Space.Description)
+ require.Equal(t, v1pb.SpaceMember_ROLE_UNSPECIFIED, invitation.Space.CurrentUserRole)
+ require.Zero(t, invitation.Space.MemberCount)
_, err = service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name})
require.Equal(t, codes.NotFound, status.Code(err), "a pending invitation must not grant Space access")
@@ -122,8 +128,22 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) {
_, err = service.GetSpaceInvitation(userCtx(ctx, owner.ID), &v1pb.GetSpaceInvitationRequest{Name: invitation.Name})
require.Equal(t, codes.NotFound, status.Code(err))
- _, err = service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name})
+ memberSpace, err := service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name})
require.NoError(t, err)
+ require.Equal(t, v1pb.SpaceMember_USER, memberSpace.CurrentUserRole)
+ require.Equal(t, int32(2), memberSpace.MemberCount)
+ memberSpaces, err := service.ListSpaces(userCtx(ctx, member.ID), &v1pb.ListSpacesRequest{})
+ require.NoError(t, err)
+ require.Len(t, memberSpaces.Spaces, 1)
+ require.Equal(t, v1pb.SpaceMember_USER, memberSpaces.Spaces[0].CurrentUserRole)
+ require.Equal(t, int32(2), memberSpaces.Spaces[0].MemberCount)
+ updatedSpace, err := service.UpdateSpace(userCtx(ctx, owner.ID), &v1pb.UpdateSpaceRequest{
+ Space: &v1pb.Space{Name: space.Name, Title: "Updated team notes"},
+ UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}},
+ })
+ require.NoError(t, err)
+ require.Equal(t, v1pb.SpaceMember_ADMIN, updatedSpace.CurrentUserRole)
+ require.Equal(t, int32(2), updatedSpace.MemberCount)
_, err = service.UpdateSpace(userCtx(ctx, member.ID), &v1pb.UpdateSpaceRequest{
Space: &v1pb.Space{Name: space.Name, Title: "not allowed"},
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}},
diff --git a/server/router/api/v1/sse_hub.go b/server/router/api/v1/sse_hub.go
index 765a585d..e624dbc0 100644
--- a/server/router/api/v1/sse_hub.go
+++ b/server/router/api/v1/sse_hub.go
@@ -5,6 +5,7 @@ import "sync"
const (
sseClientEventBufferSize = 32
memoChangedSSEFrame = "data: {\"type\":\"memo.changed\"}\n\n"
+ spaceChangedSSEFrame = "data: {\"type\":\"space.changed\"}\n\n"
)
// SSEClient represents a single SSE connection.
@@ -78,8 +79,17 @@ func (h *SSEHub) Close() {
// Slow clients with a full buffer are disconnected so they can reconnect and
// resynchronize instead of silently missing an event.
func (h *SSEHub) publishMemoChanged() {
- frame := []byte(memoChangedSSEFrame)
+ h.publish([]byte(memoChangedSSEFrame))
+}
+// publishSpaceChanged tells connected clients to refresh Space-backed caches
+// and caches whose visibility or presentation depends on Space state.
+// Like memo.changed, the event carries no authorization-sensitive data.
+func (h *SSEHub) publishSpaceChanged() {
+ h.publish([]byte(spaceChangedSSEFrame))
+}
+
+func (h *SSEHub) publish(frame []byte) {
var slowClients []*SSEClient
h.mu.RLock()
for c := range h.clients {
diff --git a/server/router/api/v1/sse_hub_test.go b/server/router/api/v1/sse_hub_test.go
index 5e25976a..06f01ebf 100644
--- a/server/router/api/v1/sse_hub_test.go
+++ b/server/router/api/v1/sse_hub_test.go
@@ -83,6 +83,22 @@ func TestSSEHubPublishMemoChangedBroadcastsToSubscribers(t *testing.T) {
}
}
+func TestSSEHubPublishSpaceChangedBroadcastsDistinctFrame(t *testing.T) {
+ hub := NewSSEHub()
+ first := hub.Subscribe()
+ defer hub.Unsubscribe(first)
+ second := hub.Subscribe()
+ defer hub.Unsubscribe(second)
+
+ hub.publishSpaceChanged()
+
+ for _, client := range []*SSEClient{first, second} {
+ frame := string(mustReceive(t, client.events, time.Second))
+ assert.Equal(t, spaceChangedSSEFrame, frame)
+ assert.NotEqual(t, memoChangedSSEFrame, frame)
+ }
+}
+
func TestSSEHubSlowClientIsDisconnected(t *testing.T) {
hub := NewSSEHub()
slow := hub.Subscribe()
diff --git a/server/router/api/v1/sse_service_test.go b/server/router/api/v1/sse_service_test.go
index fd13bc14..454c3e6d 100644
--- a/server/router/api/v1/sse_service_test.go
+++ b/server/router/api/v1/sse_service_test.go
@@ -57,6 +57,11 @@ func requireMemoChanged(t *testing.T, ch <-chan []byte) {
require.Equal(t, memoChangedSSEFrame, string(mustReceive(t, ch, time.Second)))
}
+func requireSpaceChanged(t *testing.T, ch <-chan []byte) {
+ t.Helper()
+ require.Equal(t, spaceChangedSSEFrame, string(mustReceive(t, ch, time.Second)))
+}
+
func requireNoMemoChanged(t *testing.T, ch <-chan []byte) {
t.Helper()
select {
@@ -223,7 +228,7 @@ func TestDeleteAttachmentPublishesBeforeStorageCleanupFailure(t *testing.T) {
require.Nil(t, storedAttachment, "the database deletion must remain committed")
}
-func TestSpaceMutationsPublishMemoChanged(t *testing.T) {
+func TestSpaceMutationsPublishSpaceChanged(t *testing.T) {
ctx := context.Background()
svc := newIntegrationService(t)
owner := createSpaceTestUser(ctx, t, svc, "sse-space-owner", store.RoleAdmin)
@@ -237,7 +242,7 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) {
Space: &v1pb.Space{Title: "SSE Space"},
})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
space.Title = "Renamed SSE Space"
_, err = svc.UpdateSpace(ownerCtx, &v1pb.UpdateSpaceRequest{
@@ -245,17 +250,17 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) {
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}},
})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
invitation, err := svc.CreateSpaceInvitation(ownerCtx, &v1pb.CreateSpaceInvitationRequest{
Parent: space.Name,
SpaceInvitation: &v1pb.SpaceInvitation{Invitee: BuildUserName(member.Username), Role: v1pb.SpaceMember_USER},
})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
membership, err := svc.AcceptSpaceInvitation(userCtx(ctx, member.ID), &v1pb.AcceptSpaceInvitationRequest{Name: invitation.Name})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
membership.Role = v1pb.SpaceMember_ADMIN
_, err = svc.UpdateSpaceMember(ownerCtx, &v1pb.UpdateSpaceMemberRequest{
@@ -263,15 +268,15 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) {
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"role"}},
})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
_, err = svc.DeleteSpaceMember(ownerCtx, &v1pb.DeleteSpaceMemberRequest{Name: membership.Name})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
_, err = svc.DeleteSpace(ownerCtx, &v1pb.DeleteSpaceRequest{Name: space.Name})
require.NoError(t, err)
- requireMemoChanged(t, client.events)
+ requireSpaceChanged(t, client.events)
}
func TestUpdateMemoSSEBroadcastsToAllSubscribers(t *testing.T) {
diff --git a/store/db/mysql/space.go b/store/db/mysql/space.go
index 57b02d28..25c64461 100644
--- a/store/db/mysql/space.go
+++ b/store/db/mysql/space.go
@@ -45,6 +45,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
if err != nil {
return nil, err
}
+ space.CurrentUserRole = store.SpaceMemberRoleAdmin
+ space.MemberCount = 1
if err := tx.Commit(); err != nil {
return nil, err
}
@@ -53,6 +55,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) {
where, args := []string{"1 = 1"}, []any{}
+ selectFields := "space.id, space.uid, space.title, space.description"
+ joins := ""
+ groupBy := ""
if find.ID != nil {
where, args = append(where, "space.id = ?"), append(args, *find.ID)
}
@@ -68,10 +73,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
where, args = append(where, "space.uid = ?"), append(args, *find.UID)
}
if find.MemberUserID != nil {
- where, args = append(where, "EXISTS (SELECT 1 FROM space_member sm JOIN user u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = ? AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')"), append(args, *find.MemberUserID)
+ selectFields += ", viewer_member.role, COUNT(active_member.user_id)"
+ joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id
+ JOIN user viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'`
+ where = append(where, "viewer_member.user_id = ?", "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'")
+ args = append(args, *find.MemberUserID)
+ groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role"
}
- query := `SELECT space.id, space.uid, space.title, space.description
- FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC`
+ query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC"
query = appendMySQLLimit(query, find.Limit, find.Offset)
rows, err := d.db.QueryContext(ctx, query, args...)
if err != nil {
@@ -81,7 +92,7 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
spaces := []*store.Space{}
for rows.Next() {
space := &store.Space{}
- if err := scanMySQLSpace(rows, space); err != nil {
+ if err := scanMySQLSpaceWithSummary(rows, space, find.MemberUserID != nil); err != nil {
return nil, err
}
spaces = append(spaces, space)
@@ -116,6 +127,9 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs
if err != nil {
return nil, err
}
+ if err := populateMySQLSpaceSummary(ctx, tx, space, actorUserID); err != nil {
+ return nil, err
+ }
if err := tx.Commit(); err != nil {
return nil, err
}
@@ -423,6 +437,24 @@ func scanMySQLSpace(row mysqlRowScanner, space *store.Space) error {
return row.Scan(&space.ID, &space.UID, &space.Title, &space.Description)
}
+func scanMySQLSpaceWithSummary(row mysqlRowScanner, space *store.Space, withSummary bool) error {
+ if !withSummary {
+ return scanMySQLSpace(row, space)
+ }
+ return row.Scan(&space.ID, &space.UID, &space.Title, &space.Description, &space.CurrentUserRole, &space.MemberCount)
+}
+
+func populateMySQLSpaceSummary(ctx context.Context, tx *sql.Tx, space *store.Space, userID int32) error {
+ return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id)
+ FROM space_member viewer_member
+ JOIN user viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'
+ WHERE viewer_member.space_id = ? AND viewer_member.user_id = ? AND viewer_member.status = 'ACTIVE'
+ AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL'
+ GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount)
+}
+
func getMySQLSpace(ctx context.Context, tx *sql.Tx, id int32) (*store.Space, error) {
space := &store.Space{}
return space, scanMySQLSpace(tx.QueryRowContext(ctx, `SELECT id, uid, title, description FROM space WHERE id = ?`, id), space)
diff --git a/store/db/postgres/space.go b/store/db/postgres/space.go
index d53acd33..8fceb2c6 100644
--- a/store/db/postgres/space.go
+++ b/store/db/postgres/space.go
@@ -36,6 +36,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
if _, err := tx.ExecContext(ctx, "INSERT INTO space_member (space_id, user_id, status, role) VALUES ($1, $2, $3, $4)", space.ID, creatorID, store.SpaceMemberStatusActive, store.SpaceMemberRoleAdmin); err != nil {
return nil, err
}
+ space.CurrentUserRole = store.SpaceMemberRoleAdmin
+ space.MemberCount = 1
if err := tx.Commit(); err != nil {
return nil, err
}
@@ -44,6 +46,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) {
where, args := []string{"1 = 1"}, []any{}
+ selectFields := "space.id, space.uid, space.title, space.description"
+ joins := ""
+ groupBy := ""
add := func(condition string, value any) {
args = append(args, value)
where = append(where, fmt.Sprintf(condition, placeholder(len(args))))
@@ -63,10 +68,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
add("space.uid = %s", *find.UID)
}
if find.MemberUserID != nil {
- add(`EXISTS (SELECT 1 FROM space_member sm JOIN "user" u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = %s AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')`, *find.MemberUserID)
+ selectFields += ", viewer_member.role, COUNT(active_member.user_id)"
+ joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id
+ JOIN "user" viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN "user" active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'`
+ add("viewer_member.user_id = %s", *find.MemberUserID)
+ where = append(where, "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'")
+ groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role"
}
- query := `SELECT space.id, space.uid, space.title, space.description
- FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC`
+ query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC"
query = appendPostgresLimit(query, find.Limit, find.Offset)
rows, err := d.db.QueryContext(ctx, query, args...)
if err != nil {
@@ -76,7 +87,11 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
spaces := []*store.Space{}
for rows.Next() {
space := &store.Space{}
- if err := rows.Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil {
+ scanTargets := []any{&space.ID, &space.UID, &space.Title, &space.Description}
+ if find.MemberUserID != nil {
+ scanTargets = append(scanTargets, &space.CurrentUserRole, &space.MemberCount)
+ }
+ if err := rows.Scan(scanTargets...); err != nil {
return nil, err
}
spaces = append(spaces, space)
@@ -113,12 +128,26 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs
if err := tx.QueryRowContext(ctx, query, args...).Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil {
return nil, err
}
+ if err := populatePostgresSpaceSummary(ctx, tx, space, actorUserID); err != nil {
+ return nil, err
+ }
if err := tx.Commit(); err != nil {
return nil, err
}
return space, nil
}
+func populatePostgresSpaceSummary(ctx context.Context, tx *sql.Tx, space *store.Space, userID int32) error {
+ return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id)
+ FROM space_member viewer_member
+ JOIN "user" viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN "user" active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'
+ WHERE viewer_member.space_id = $1 AND viewer_member.user_id = $2 AND viewer_member.status = 'ACTIVE'
+ AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL'
+ GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount)
+}
+
func (d *DB) CreateSpaceInvitation(ctx context.Context, create *store.SpaceInvitation, actorUserID int32) (*store.SpaceInvitation, error) {
tx, err := d.db.BeginTx(ctx, nil)
if err != nil {
diff --git a/store/db/sqlite/space.go b/store/db/sqlite/space.go
index 021dd914..1bb22471 100644
--- a/store/db/sqlite/space.go
+++ b/store/db/sqlite/space.go
@@ -37,6 +37,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
if _, err := tx.ExecContext(ctx, "INSERT INTO space_member (space_id, user_id, status, role) VALUES (?, ?, ?, ?)", space.ID, creatorID, store.SpaceMemberStatusActive, store.SpaceMemberRoleAdmin); err != nil {
return nil, errors.Wrap(err, "failed to create initial space admin")
}
+ space.CurrentUserRole = store.SpaceMemberRoleAdmin
+ space.MemberCount = 1
if err := tx.Commit(); err != nil {
return nil, errors.Wrap(err, "failed to commit space create transaction")
}
@@ -45,6 +47,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int
func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) {
where, args := []string{"1 = 1"}, []any{}
+ selectFields := "space.id, space.uid, space.title, space.description"
+ joins := ""
+ groupBy := ""
if find.ID != nil {
where, args = append(where, "space.id = ?"), append(args, *find.ID)
}
@@ -60,10 +65,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
where, args = append(where, "space.uid = ?"), append(args, *find.UID)
}
if find.MemberUserID != nil {
- where, args = append(where, "EXISTS (SELECT 1 FROM space_member sm JOIN user u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = ? AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')"), append(args, *find.MemberUserID)
+ selectFields += ", viewer_member.role, COUNT(active_member.user_id)"
+ joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id
+ JOIN user viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'`
+ where = append(where, "viewer_member.user_id = ?", "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'")
+ args = append(args, *find.MemberUserID)
+ groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role"
}
- query := `SELECT space.id, space.uid, space.title, space.description
- FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC`
+ query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC"
query = appendSQLiteLimit(query, find.Limit, find.Offset)
rows, err := d.db.QueryContext(ctx, query, args...)
if err != nil {
@@ -73,7 +84,11 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp
spaces := []*store.Space{}
for rows.Next() {
space := &store.Space{}
- if err := rows.Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil {
+ scanTargets := []any{&space.ID, &space.UID, &space.Title, &space.Description}
+ if find.MemberUserID != nil {
+ scanTargets = append(scanTargets, &space.CurrentUserRole, &space.MemberCount)
+ }
+ if err := rows.Scan(scanTargets...); err != nil {
return nil, err
}
spaces = append(spaces, space)
@@ -104,12 +119,26 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs
if err := tx.QueryRowContext(ctx, query, args...).Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil {
return nil, err
}
+ if err := populateSQLiteSpaceSummary(ctx, tx, space, actorUserID); err != nil {
+ return nil, err
+ }
if err := tx.Commit(); err != nil {
return nil, err
}
return space, nil
}
+func populateSQLiteSpaceSummary(ctx context.Context, tx dbExecutor, space *store.Space, userID int32) error {
+ return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id)
+ FROM space_member viewer_member
+ JOIN user viewer_user ON viewer_user.id = viewer_member.user_id
+ JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER')
+ JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'
+ WHERE viewer_member.space_id = ? AND viewer_member.user_id = ? AND viewer_member.status = 'ACTIVE'
+ AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL'
+ GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount)
+}
+
func (d *DB) CreateSpaceInvitation(ctx context.Context, create *store.SpaceInvitation, actorUserID int32) (*store.SpaceInvitation, error) {
tx, err := d.db.BeginTx(ctx, nil)
if err != nil {
diff --git a/store/space.go b/store/space.go
index 98a57d02..e194fea4 100644
--- a/store/space.go
+++ b/store/space.go
@@ -68,13 +68,16 @@ func (r SpaceMemberRole) IsActiveMember() bool {
type Space struct {
ID int32
- UID string
- Title string
- Description string
+ UID string
+ Title string
+ Description string
+ CurrentUserRole SpaceMemberRole
+ MemberCount int32
}
// FindSpace selects spaces. MemberUserID restricts results to spaces where the
-// user has a membership and is applied before pagination.
+// user has a membership, populates the viewer summary, and is applied before
+// pagination.
type FindSpace struct {
ID *int32
IDList []int32
diff --git a/store/test/space_test.go b/store/test/space_test.go
index da46009a..f766f2c6 100644
--- a/store/test/space_test.go
+++ b/store/test/space_test.go
@@ -21,6 +21,8 @@ func TestSpaceStoreMembershipGuards(t *testing.T) {
space, err := ts.CreateSpace(ctx, &store.Space{UID: "space-store", Title: "Store Space"}, owner.ID)
require.NoError(t, err)
+ require.Equal(t, store.SpaceMemberRoleAdmin, space.CurrentUserRole)
+ require.Equal(t, int32(1), space.MemberCount)
ownerMembership, err := ts.GetSpaceMember(ctx, &store.FindSpaceMember{SpaceID: &space.ID, UserID: &owner.ID, ViewerUserID: &owner.ID})
require.NoError(t, err)
@@ -29,6 +31,24 @@ func TestSpaceStoreMembershipGuards(t *testing.T) {
created, err := createSpaceMemberForTest(ctx, ts, &store.SpaceMember{SpaceID: space.ID, UserID: member.ID, Role: store.SpaceMemberRoleUser}, owner.ID)
require.NoError(t, err)
require.Equal(t, member.ID, created.UserID)
+ ownerSpaces, err := ts.ListSpaces(ctx, &store.FindSpace{MemberUserID: &owner.ID})
+ require.NoError(t, err)
+ require.Len(t, ownerSpaces, 1)
+ require.Equal(t, store.SpaceMemberRoleAdmin, ownerSpaces[0].CurrentUserRole)
+ require.Equal(t, int32(2), ownerSpaces[0].MemberCount)
+ memberSpace, err := ts.GetSpace(ctx, &store.FindSpace{UID: &space.UID, MemberUserID: &member.ID})
+ require.NoError(t, err)
+ require.Equal(t, store.SpaceMemberRoleUser, memberSpace.CurrentUserRole)
+ require.Equal(t, int32(2), memberSpace.MemberCount)
+ unscopedSpace, err := ts.GetSpace(ctx, &store.FindSpace{UID: &space.UID})
+ require.NoError(t, err)
+ require.Empty(t, unscopedSpace.CurrentUserRole)
+ require.Zero(t, unscopedSpace.MemberCount)
+ updatedTitle := "Updated Store Space"
+ updatedSpace, err := ts.UpdateSpace(ctx, &store.UpdateSpace{ID: space.ID, Title: &updatedTitle}, owner.ID)
+ require.NoError(t, err)
+ require.Equal(t, store.SpaceMemberRoleAdmin, updatedSpace.CurrentUserRole)
+ require.Equal(t, int32(2), updatedSpace.MemberCount)
_, err = createSpaceMemberForTest(ctx, ts, &store.SpaceMember{SpaceID: space.ID, UserID: member.ID, Role: store.SpaceMemberRoleUser}, owner.ID)
require.ErrorIs(t, err, store.ErrSpaceMemberAlreadyExists)
diff --git a/web/src/components/AppSidebar/AppSidebar.tsx b/web/src/components/AppSidebar/AppSidebar.tsx
index 83d9f3e0..0b592ba2 100644
--- a/web/src/components/AppSidebar/AppSidebar.tsx
+++ b/web/src/components/AppSidebar/AppSidebar.tsx
@@ -30,7 +30,7 @@ import { Link, matchPath, useLocation, useNavigate, useSearchParams } from "reac
import ConfirmDialog from "@/components/ConfirmDialog";
import { MemoDetailSidebar } from "@/components/MemoDetailSidebar";
import MemoDisplaySettingMenu from "@/components/MemoDisplaySettingMenu";
-import { SETTINGS_SECTIONS } from "@/components/Settings/settingSections";
+import { DEFAULT_SETTING_SECTION, SETTINGS_SECTIONS } from "@/components/Settings/settingSections";
import StatisticsView from "@/components/StatisticsView";
import UserMenu from "@/components/UserMenu";
import { Button } from "@/components/ui/button";
@@ -376,7 +376,7 @@ const SettingsSidebarContent = () => {
const user = useCurrentUser();
const { setMobileOpen } = useAppSidebar();
const isHost = user?.role === User_Role.ADMIN;
- const currentSection = location.hash.slice(1) || "my-account";
+ const currentSection = location.hash.slice(1) || DEFAULT_SETTING_SECTION;
const basic = SETTINGS_SECTIONS.filter((section) => section.scope === "basic");
const admin = SETTINGS_SECTIONS.filter((section) => section.scope === "admin");
const renderSections = (sections: typeof SETTINGS_SECTIONS) =>
diff --git a/web/src/components/AppSidebar/SpaceSwitcher.tsx b/web/src/components/AppSidebar/SpaceSwitcher.tsx
index acfe7dc4..438b08c9 100644
--- a/web/src/components/AppSidebar/SpaceSwitcher.tsx
+++ b/web/src/components/AppSidebar/SpaceSwitcher.tsx
@@ -2,6 +2,7 @@ import { CheckIcon, ChevronsUpDownIcon, LoaderCircleIcon, type LucideIcon, PlusI
import { type ReactNode, useState } from "react";
import CreateSpaceDialog from "@/components/CreateSpaceDialog";
import MemosLogo from "@/components/MemosLogo";
+import SpaceMark from "@/components/SpaceMark";
import {
DropdownMenu,
DropdownMenuContent,
@@ -13,32 +14,8 @@ import {
} from "@/components/ui/dropdown-menu";
import { useSpaceContext } from "@/contexts/SpaceContext";
import { cn } from "@/lib/utils";
-import type { Space } from "@/types/proto/api/v1/space_service_pb";
import { useTranslate } from "@/utils/i18n";
-// Mirrors MemosLogo's compact scale so the brand and a Space read as peers in the menu.
-const MARK_SCALE = {
- md: "size-7 rounded-[7px] text-[13px]",
- sm: "size-5 rounded-[5px] text-[11px]",
-} as const;
-
-const SpaceMark = ({ space, size = "md" }: { space?: Space; size?: "sm" | "md" }) => {
- const label = space?.title.trim() || "S";
- const initial = Array.from(label)[0]?.toLocaleUpperCase() ?? "S";
-
- return (
-
- {initial}
-
- );
-};
-
// Icons in action and status rows sit in a glyph-width slot so every label in the menu
// starts on the same text rail as the context rows.
const RowIcon = ({ icon: Icon, className }: { icon: LucideIcon; className?: string }) => (
@@ -128,7 +105,7 @@ function SpaceSwitcher({ className }: { className?: string }) {
-
+
>
);
}
diff --git a/web/src/components/CreateSpaceDialog.tsx b/web/src/components/CreateSpaceDialog.tsx
index 24c86650..e6c23ac7 100644
--- a/web/src/components/CreateSpaceDialog.tsx
+++ b/web/src/components/CreateSpaceDialog.tsx
@@ -5,21 +5,22 @@ import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, D
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
import { Textarea } from "@/components/ui/textarea";
-import { useSpaceContext } from "@/contexts/SpaceContext";
import useCurrentUser from "@/hooks/useCurrentUser";
import { useCreateSpace } from "@/hooks/useSpaceQueries";
import { handleError } from "@/lib/error";
+import type { Space } from "@/types/proto/api/v1/space_service_pb";
import { useTranslate } from "@/utils/i18n";
interface Props {
open: boolean;
onOpenChange: (open: boolean) => void;
+ onCreated?: (space: Space) => void;
+ note?: string;
}
-function CreateSpaceDialog({ open, onOpenChange }: Props) {
+function CreateSpaceDialog({ open, onOpenChange, onCreated, note }: Props) {
const t = useTranslate();
const currentUserName = useCurrentUser()?.name ?? "";
- const { selectSpace } = useSpaceContext();
const createSpace = useCreateSpace(currentUserName);
const [title, setTitle] = useState("");
const [description, setDescription] = useState("");
@@ -38,17 +39,20 @@ function CreateSpaceDialog({ open, onOpenChange }: Props) {
return;
}
+ let space: Space;
try {
- const space = await createSpace.mutateAsync({
+ space = await createSpace.mutateAsync({
title: trimmedTitle,
description: description.trim() || undefined,
});
- selectSpace(space);
- toast.success(t("space.create-success"));
- onOpenChange(false);
} catch (error) {
handleError(error, toast.error, { context: "Create space" });
+ return;
}
+
+ toast.success(t("space.create-success"));
+ onOpenChange(false);
+ onCreated?.(space);
};
const handleOpenChange = (nextOpen: boolean) => {
@@ -87,7 +91,7 @@ function CreateSpaceDialog({ open, onOpenChange }: Props) {
className="min-h-20 resize-none"
/>
-
{t("space.creator-admin-note")}
+ {note ?? t("space.creator-admin-note")}
+ }
+ className="gap-5"
+ >
+
+ {receivedInvitations.length > 0 ? (
+
+
+
+ {t("setting.spaces.invitations")}
+
+
+ {t("setting.spaces.pending-count", { count: receivedInvitations.length })}
+
+
+
+ {receivedInvitations.map((invitation) => (
+
+
+
+
+
+
{invitation.space?.title || t("setting.spaces.untitled")}
+
+
+
+ {invitation.space?.description || t("setting.spaces.invited-to-join")}
+
+
+
+
+
+
+
+
+ ))}
+
+
+ ) : null}
+
+
+
+
+ {t("setting.spaces.your-spaces")}
+
+ {spaces.length > 0 ? (
+
+ {spaces.length === 1
+ ? t("setting.spaces.space-count", { count: spaces.length })
+ : t("setting.spaces.spaces-count", { count: spaces.length })}
+
+ ) : null}
+
+ {spacesQuery.isLoading ? (
+
+
+ {t("setting.spaces.loading")}
+
+ ) : spacesQuery.isError ? (
+
+ {t("setting.spaces.load-error")}
+
+ ) : spaces.length === 0 ? (
+
+
{t("setting.spaces.no-spaces")}
+
{t("setting.spaces.no-spaces-description")}
+
+
+ ) : (
+
+ {spaces.map((space) => (
+
+ ))}
+
+ )}
+
+
+
+
+ navigate(getSpacesSettingsLocation(space.name))}
+ note={t("setting.spaces.create-scope-note")}
+ />
+ >
+ );
+};
+
+interface SpaceDetailProps {
+ space: Space;
+ viewerName: string;
+ onBack: () => void;
+}
+
+const SpaceDetail = ({ space, viewerName, onBack }: SpaceDetailProps) => {
+ const t = useTranslate();
+ const membersQuery = useSpaceMembers(viewerName, space.name);
+ const members = membersQuery.data ?? [];
+ const currentMember = members.find((member) => member.user === viewerName);
+ const currentRole = currentMember?.role ?? space.currentUserRole;
+ const isAdmin = currentRole === SpaceMember_Role.ADMIN;
+ const invitationsQuery = useSpaceInvitations(viewerName, space.name, { enabled: isAdmin });
+ const invitations = invitationsQuery.data ?? [];
+ const usernames = useMemo(
+ () =>
+ Array.from(
+ new Set(
+ [...members.map((member) => member.user), ...invitations.map((invitation) => invitation.invitee)].map(extractUsernameFromName),
+ ),
+ ),
+ [invitations, members],
+ );
+ const usersQuery = useUsersByUsernames(usernames);
+ const usersByUsername = usersQuery.data ?? new Map();
+ const [tab, setTab] = useState("general");
+ const [title, setTitle] = useState(space.title);
+ const [description, setDescription] = useState(space.description);
+ const [inviteOpen, setInviteOpen] = useState(false);
+ const [leaveOpen, setLeaveOpen] = useState(false);
+ const [deleteOpen, setDeleteOpen] = useState(false);
+ const [removeTarget, setRemoveTarget] = useState();
+ const [cancelInvitationTarget, setCancelInvitationTarget] = useState();
+ const updateSpace = useUpdateSpace(viewerName);
+ const deleteSpace = useDeleteSpace(viewerName);
+ const updateMember = useUpdateSpaceMember(viewerName);
+ const deleteMember = useDeleteSpaceMember(viewerName);
+ const deleteInvitation = useDeleteSpaceInvitation(viewerName);
+ const activeAdminCount = members.filter((member) => member.role === SpaceMember_Role.ADMIN).length;
+ const isLastAdmin = currentRole === SpaceMember_Role.ADMIN && activeAdminCount === 1;
+ const memberUserNames = useMemo(() => new Set(members.map((member) => member.user)), [members]);
+ const pendingInviteeNames = useMemo(() => new Set(invitations.map((invitation) => invitation.invitee)), [invitations]);
+ const roleOptions = [
+ { value: String(SpaceMember_Role.USER), label: t("setting.spaces.space-user") },
+ { value: String(SpaceMember_Role.ADMIN), label: t("setting.spaces.space-admin") },
+ ];
+ const detailsChanged = title.trim() !== space.title || description.trim() !== space.description;
+
+ useEffect(() => {
+ setTitle(space.title);
+ setDescription(space.description);
+ }, [space.description, space.title]);
+
+ const handleSave = async () => {
+ const trimmedTitle = title.trim();
+ if (!trimmedTitle || !isAdmin || updateSpace.isPending) return;
+ try {
+ await updateSpace.mutateAsync({
+ space: { name: space.name, title: trimmedTitle, description: description.trim() },
+ updateMask: ["title", "description"],
+ });
+ toast.success(t("setting.spaces.save-success"));
+ } catch (error) {
+ handleError(error, toast.error, { context: "Update space" });
+ }
+ };
+
+ const handleRoleChange = async (member: SpaceMember, role: SpaceMember_Role) => {
+ if (member.role === role || updateMember.isPending) return;
+ try {
+ await updateMember.mutateAsync({ spaceMember: { name: member.name, role }, updateMask: ["role"] });
+ toast.success(t("setting.spaces.role-update-success"));
+ } catch (error) {
+ handleError(error, toast.error, { context: "Update space member" });
+ }
+ };
+
+ const handleRemoveMember = async () => {
+ if (!removeTarget) return;
+ try {
+ await deleteMember.mutateAsync({ name: removeTarget.name });
+ toast.success(t("setting.spaces.remove-success", { username: extractUsernameFromName(removeTarget.user) }));
+ setRemoveTarget(undefined);
+ } catch (error) {
+ handleError(error, toast.error, { context: "Remove space member" });
+ throw error;
+ }
+ };
+
+ const handleCancelInvitation = async () => {
+ if (!cancelInvitationTarget) return;
+ try {
+ await deleteInvitation.mutateAsync({ name: cancelInvitationTarget.name });
+ toast.success(t("setting.spaces.cancel-invitation-success"));
+ setCancelInvitationTarget(undefined);
+ } catch (error) {
+ handleError(error, toast.error, { context: "Cancel space invitation" });
+ throw error;
+ }
+ };
+
+ const handleLeave = async () => {
+ if (!currentMember) return;
+ try {
+ await deleteMember.mutateAsync({ name: currentMember.name });
+ toast.success(t("setting.spaces.leave-success", { space: space.title }));
+ onBack();
+ } catch (error) {
+ handleError(error, toast.error, { context: "Leave space" });
+ throw error;
+ }
+ };
+
+ const handleDeleteSpace = async () => {
+ try {
+ await deleteSpace.mutateAsync({ name: space.name });
+ toast.success(t("setting.spaces.delete-success", { space: space.title }));
+ onBack();
+ } catch (error) {
+ handleError(error, toast.error, { context: "Delete space" });
+ throw error;
+ }
+ };
+
+ return (
+
+
+
+
+
+ setTab(value as DetailTab)} variant="underline" className="mt-2">
+
+
+ {t("setting.spaces.general")}
+
+
+ {t("setting.spaces.members")}
+ {members.length || space.memberCount}
+
+
+
+
+ {tab === "general" ? (
+
+
+
+
{t("setting.spaces.space-details")}
+
{t("setting.spaces.space-details-description")}
+
+
+
+
+ setTitle(event.target.value)}
+ readOnly={!isAdmin}
+ className={!isAdmin ? "bg-muted/25" : undefined}
+ />
+
+
+
+
+
{t("setting.spaces.description-help")}
+
+
+ {isAdmin ? (
+
+
+
+ ) : null}
+
+
+
+
+ {t("setting.spaces.your-access")}
+
+
+
+
+
{t("setting.spaces.role-in-space")}
+
+ {isAdmin ? t("setting.spaces.admin-role-description") : t("setting.spaces.user-role-description")}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
{t("setting.spaces.leave-space")}
+
+ {isLastAdmin ? t("setting.spaces.last-admin-leave-description") : t("setting.spaces.leave-description")}
+
+
+
+
+
+ {isAdmin ? (
+
+
+
+
+
+
+
{t("setting.spaces.delete-space")}
+
{t("setting.spaces.delete-description")}
+
+
+
+
+ ) : null}
+
+
+ ) : (
+
+
+
+
+
{t("setting.spaces.members")}
+
{t("setting.spaces.members-description")}
+
+ {isAdmin ? (
+
+ ) : null}
+
+
+
+ {membersQuery.isLoading ? (
+
+
+ {t("setting.spaces.loading-members")}
+
+ ) : membersQuery.isError ? (
+
{t("setting.spaces.members-load-error")}
+ ) : (
+ members.map((member) => {
+ const isCurrentUser = member.user === viewerName;
+ return (
+
+
+
+ {isAdmin && !isCurrentUser ? (
+
+ ) : (
+
+ )}
+ {isAdmin && !isCurrentUser ? (
+
+ ) : null}
+
+
+ );
+ })
+ )}
+
+
+
+ {isAdmin ? (
+
+
+
{t("setting.spaces.pending-invitations")}
+ {invitations.length}
+
+
+ {invitationsQuery.isLoading ? (
+
+
+ {t("setting.spaces.loading-invitations")}
+
+ ) : invitations.length === 0 ? (
+
{t("setting.spaces.no-pending-invitations")}
+ ) : (
+ invitations.map((invitation) => (
+
+
+
+
+
+ {t("setting.spaces.invitation-pending")}
+
+
+
+
+
+ ))
+ )}
+
+
+ ) : null}
+
+ )}
+
+
+
+
+
+ !open && setRemoveTarget(undefined)}
+ title={t("setting.spaces.remove-confirm-title", { username: extractUsernameFromName(removeTarget?.user ?? "") })}
+ description={t("setting.spaces.remove-confirm-description")}
+ confirmLabel={t("setting.spaces.remove")}
+ cancelLabel={t("common.cancel")}
+ onConfirm={handleRemoveMember}
+ confirmVariant="destructive"
+ />
+ !open && setCancelInvitationTarget(undefined)}
+ title={t("setting.spaces.cancel-invitation-confirm-title", {
+ username: extractUsernameFromName(cancelInvitationTarget?.invitee ?? ""),
+ })}
+ description={t("setting.spaces.cancel-invitation-confirm-description")}
+ confirmLabel={t("setting.spaces.cancel-invitation")}
+ cancelLabel={t("common.cancel")}
+ onConfirm={handleCancelInvitation}
+ confirmVariant="destructive"
+ />
+
+ );
+};
+
+export default SpacesSection;
diff --git a/web/src/components/Settings/settingSections.ts b/web/src/components/Settings/settingSections.ts
index 917c6824..a8c14948 100644
--- a/web/src/components/Settings/settingSections.ts
+++ b/web/src/components/Settings/settingSections.ts
@@ -1,5 +1,6 @@
import {
BarChart3Icon,
+ BoxesIcon,
CogIcon,
DatabaseIcon,
HeartHandshakeIcon,
@@ -24,6 +25,7 @@ import MyAccountSection from "@/components/Settings/MyAccountSection";
import NotificationSection from "@/components/Settings/NotificationSection";
import PreferencesSection from "@/components/Settings/PreferencesSection";
import ResourceStatsSection from "@/components/Settings/ResourceStatsSection";
+import SpacesSection from "@/components/Settings/SpacesSection";
import SSOSection from "@/components/Settings/SSOSection";
import StorageSection from "@/components/Settings/StorageSection";
import TagsSection from "@/components/Settings/TagsSection";
@@ -32,6 +34,7 @@ import { InstanceSetting_Key } from "@/types/proto/api/v1/instance_service_pb";
export type SettingSectionKey =
| "my-account"
+ | "spaces"
| "access-token"
| "preference"
| "webhook"
@@ -64,6 +67,13 @@ export const SETTINGS_SECTIONS: SettingSectionDefinition[] = [
icon: UserIcon,
component: MyAccountSection,
},
+ {
+ key: "spaces",
+ scope: "basic",
+ labelKey: "setting.spaces.label",
+ icon: BoxesIcon,
+ component: SpacesSection,
+ },
{
key: "access-token",
scope: "basic",
diff --git a/web/src/components/SpaceMark.tsx b/web/src/components/SpaceMark.tsx
new file mode 100644
index 00000000..07be5df4
--- /dev/null
+++ b/web/src/components/SpaceMark.tsx
@@ -0,0 +1,35 @@
+import { cn } from "@/lib/utils";
+import type { Space } from "@/types/proto/api/v1/space_service_pb";
+
+const MARK_SCALE = {
+ xl: "size-11 rounded-lg text-base",
+ lg: "size-9 rounded-[7px] text-sm",
+ md: "size-7 rounded-[7px] text-[13px]",
+ sm: "size-5 rounded-[5px] text-[11px]",
+} as const;
+
+interface Props {
+ space?: Pick;
+ size?: keyof typeof MARK_SCALE;
+ className?: string;
+}
+
+const SpaceMark = ({ space, size = "md", className }: Props) => {
+ const label = space?.title.trim() || "S";
+ const initial = Array.from(label)[0]?.toLocaleUpperCase() ?? "S";
+
+ return (
+
+ {initial}
+
+ );
+};
+
+export default SpaceMark;
diff --git a/web/src/hooks/useLiveMemoRefresh.ts b/web/src/hooks/useLiveMemoRefresh.ts
index 3435cd9d..e51538e5 100644
--- a/web/src/hooks/useLiveMemoRefresh.ts
+++ b/web/src/hooks/useLiveMemoRefresh.ts
@@ -4,6 +4,7 @@ import { getRequestToken, refreshAccessToken } from "@/connect";
import { useAuth } from "@/contexts/AuthContext";
import { attachmentKeys } from "@/hooks/useAttachmentQueries";
import { memoKeys } from "@/hooks/useMemoQueries";
+import { spaceKeys } from "@/hooks/useSpaceQueries";
import { userKeys } from "@/hooks/useUserQueries";
/**
@@ -18,7 +19,8 @@ const HIDDEN_DISCONNECT_DELAY_MS = 30_000;
const SSE_CONNECTION_LOCK_NAME = "memos-sse-connection";
const SSE_SYNC_CHANNEL_NAME = "memos-sse-sync";
-const SSE_EVENT_TYPE = "memo.changed" as const;
+const MEMO_CHANGED_SSE_EVENT_TYPE = "memo.changed" as const;
+const SPACE_CHANGED_SSE_EVENT_TYPE = "space.changed" as const;
// ---------------------------------------------------------------------------
// Shared connection status store (singleton)
@@ -56,7 +58,7 @@ export function useSSEConnectionStatus(): SSEConnectionStatus {
}
interface SSEChangeEvent {
- type: typeof SSE_EVENT_TYPE;
+ type: typeof MEMO_CHANGED_SSE_EVENT_TYPE | typeof SPACE_CHANGED_SSE_EVENT_TYPE;
}
type SSESyncMessage =
@@ -69,8 +71,8 @@ type SSESyncMessage =
// ---------------------------------------------------------------------------
/**
- * useLiveMemoRefresh connects to the server's SSE endpoint and
- * invalidates memo-backed React Query caches when a change event is received.
+ * useLiveMemoRefresh connects to the server's SSE endpoint and invalidates
+ * Space- and memo-backed React Query caches when a change event is received.
*
* This enables real-time updates across all open instances of the app.
*/
@@ -152,7 +154,7 @@ export function useLiveMemoRefresh() {
if (hasConnectedOnceRef.current) {
// Resync active collaborative views after reconnect because the server may have
// dropped events while the client was disconnected or backpressured.
- invalidateLiveMemoQueries(queryClient);
+ invalidateAllLiveQueries(queryClient);
}
hasConnectedOnceRef.current = true;
@@ -276,7 +278,7 @@ export function useLiveMemoRefresh() {
}
if (message.status === "connected") {
if (hasConnectedOnceRef.current) {
- invalidateLiveMemoQueries(queryClient);
+ invalidateAllLiveQueries(queryClient);
}
hasConnectedOnceRef.current = true;
}
@@ -458,9 +460,18 @@ async function consumeSSEStream(body: ReadableStream, signal: AbortS
}
function handleSSEEvent(event: SSEChangeEvent, queryClient: ReturnType) {
- if (event.type !== SSE_EVENT_TYPE) {
- return;
+ switch (event.type) {
+ case MEMO_CHANGED_SSE_EVENT_TYPE:
+ invalidateLiveMemoQueries(queryClient);
+ break;
+ case SPACE_CHANGED_SSE_EVENT_TYPE:
+ invalidateAllLiveQueries(queryClient);
+ break;
}
+}
+
+function invalidateAllLiveQueries(queryClient: ReturnType) {
+ queryClient.invalidateQueries({ queryKey: spaceKeys.all, refetchType: "active" });
invalidateLiveMemoQueries(queryClient);
}
diff --git a/web/src/hooks/useSpaceQueries.ts b/web/src/hooks/useSpaceQueries.ts
index 031340d2..53975675 100644
--- a/web/src/hooks/useSpaceQueries.ts
+++ b/web/src/hooks/useSpaceQueries.ts
@@ -1,19 +1,107 @@
import { create } from "@bufbuild/protobuf";
-import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
+import { FieldMaskSchema } from "@bufbuild/protobuf/wkt";
+import { type QueryClient, type QueryKey, useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { spaceServiceClient } from "@/connect";
-import { type Space, SpaceSchema } from "@/types/proto/api/v1/space_service_pb";
+import { attachmentKeys } from "@/hooks/useAttachmentQueries";
+import { memoKeys } from "@/hooks/useMemoQueries";
+import { userKeys } from "@/hooks/useUserQueries";
+import {
+ type Space,
+ type SpaceInvitation,
+ SpaceInvitationSchema,
+ type SpaceMember,
+ SpaceMemberSchema,
+ SpaceSchema,
+} from "@/types/proto/api/v1/space_service_pb";
const SPACE_LIST_PAGE_SIZE = 1000;
+const SPACE_LIST_STALE_TIME = 1000 * 60 * 5;
+
+export interface SpaceQueryOptions {
+ enabled?: boolean;
+}
+
+export type UpdateSpaceVariables = {
+ space: Partial & Pick;
+ updateMask: string[];
+};
+
+export type DeleteSpaceVariables = {
+ name: string;
+};
+
+export type CreateSpaceInvitationVariables = {
+ parent: string;
+ spaceInvitation: Pick;
+};
+
+export type SpaceInvitationNameVariables = {
+ name: string;
+};
+
+export type UpdateSpaceMemberVariables = {
+ spaceMember: Partial & Pick;
+ updateMask: string[];
+};
+
+export type DeleteSpaceMemberVariables = {
+ name: string;
+};
export const spaceKeys = {
all: ["spaces"] as const,
lists: () => [...spaceKeys.all, "list"] as const,
- list: (userName: string) => [...spaceKeys.lists(), userName] as const,
+ list: (viewerName: string) => [...spaceKeys.lists(), viewerName] as const,
+ space: (viewerName: string, spaceName: string) => [...spaceKeys.all, "space", viewerName, spaceName] as const,
+ members: (viewerName: string, spaceName: string) => [...spaceKeys.space(viewerName, spaceName), "members"] as const,
+ spaceInvitations: (viewerName: string, spaceName: string) => [...spaceKeys.space(viewerName, spaceName), "invitations"] as const,
+ userInvitations: (viewerName: string) => [...spaceKeys.all, "user-invitations", viewerName] as const,
};
-export function useSpaces(userName: string | undefined) {
+const queryEnabled = (viewerName: string | undefined, resourceName: string | undefined, options?: SpaceQueryOptions) =>
+ Boolean(viewerName && resourceName) && (options?.enabled ?? true);
+
+const spaceNameFromChildResource = (name: string): string | undefined => {
+ const [collection, spaceID] = name.split("/");
+ return collection === "spaces" && spaceID ? `${collection}/${spaceID}` : undefined;
+};
+
+const resourceID = (name: string): string | undefined => name.split("/").filter(Boolean).pop();
+
+const upsertByName = (items: T[], item: T): T[] => {
+ const index = items.findIndex(({ name }) => name === item.name);
+ if (index === -1) {
+ return [...items, item];
+ }
+
+ const next = [...items];
+ next[index] = item;
+ return next;
+};
+
+const removeByName = (items: T[], name: string): T[] => items.filter((item) => item.name !== name);
+
+const updateCachedList = (queryClient: QueryClient, queryKey: QueryKey, update: (items: T[]) => T[]) => {
+ const items = queryClient.getQueryData(queryKey);
+ if (items !== undefined) {
+ queryClient.setQueryData(queryKey, update(items));
+ }
+};
+
+const removeSpaceFromViewerCache = (queryClient: QueryClient, viewerName: string, spaceName: string) => {
+ updateCachedList(queryClient, spaceKeys.list(viewerName), (spaces) => removeByName(spaces, spaceName));
+ queryClient.removeQueries({ queryKey: spaceKeys.space(viewerName, spaceName) });
+};
+
+const invalidateMembershipSensitiveQueries = (queryClient: QueryClient) => {
+ void queryClient.invalidateQueries({ queryKey: memoKeys.all });
+ void queryClient.invalidateQueries({ queryKey: attachmentKeys.lists() });
+ void queryClient.invalidateQueries({ queryKey: userKeys.stats() });
+};
+
+export function useSpaces(viewerName: string | undefined, options?: SpaceQueryOptions) {
return useQuery({
- queryKey: spaceKeys.list(userName ?? ""),
+ queryKey: spaceKeys.list(viewerName ?? ""),
queryFn: async () => {
const spaces: Space[] = [];
let pageToken = "";
@@ -29,15 +117,84 @@ export function useSpaces(userName: string | undefined) {
return spaces;
},
- enabled: Boolean(userName),
+ enabled: Boolean(viewerName) && (options?.enabled ?? true),
// SpaceProvider wraps the whole route tree, so this drains every page on boot.
// Space membership is near-static, so don't re-run that loop on each tab return.
- staleTime: 1000 * 60 * 5,
+ staleTime: SPACE_LIST_STALE_TIME,
refetchOnWindowFocus: false,
});
}
-export function useCreateSpace(userName: string) {
+export function useSpaceMembers(viewerName: string | undefined, spaceName: string | undefined, options?: SpaceQueryOptions) {
+ return useQuery({
+ queryKey: spaceKeys.members(viewerName ?? "", spaceName ?? ""),
+ queryFn: async () => {
+ const members: SpaceMember[] = [];
+ let pageToken = "";
+
+ do {
+ const response = await spaceServiceClient.listSpaceMembers({
+ parent: spaceName!,
+ pageSize: SPACE_LIST_PAGE_SIZE,
+ pageToken,
+ });
+ members.push(...response.spaceMembers);
+ pageToken = response.nextPageToken;
+ } while (pageToken);
+
+ return members;
+ },
+ enabled: queryEnabled(viewerName, spaceName, options),
+ });
+}
+
+export function useSpaceInvitations(viewerName: string | undefined, spaceName: string | undefined, options?: SpaceQueryOptions) {
+ return useQuery({
+ queryKey: spaceKeys.spaceInvitations(viewerName ?? "", spaceName ?? ""),
+ queryFn: async () => {
+ const invitations: SpaceInvitation[] = [];
+ let pageToken = "";
+
+ do {
+ const response = await spaceServiceClient.listSpaceInvitations({
+ parent: spaceName!,
+ pageSize: SPACE_LIST_PAGE_SIZE,
+ pageToken,
+ });
+ invitations.push(...response.spaceInvitations);
+ pageToken = response.nextPageToken;
+ } while (pageToken);
+
+ return invitations;
+ },
+ enabled: queryEnabled(viewerName, spaceName, options),
+ });
+}
+
+export function useUserSpaceInvitations(viewerName: string | undefined, options?: SpaceQueryOptions) {
+ return useQuery({
+ queryKey: spaceKeys.userInvitations(viewerName ?? ""),
+ queryFn: async () => {
+ const invitations: SpaceInvitation[] = [];
+ let pageToken = "";
+
+ do {
+ const response = await spaceServiceClient.listUserSpaceInvitations({
+ parent: viewerName!,
+ pageSize: SPACE_LIST_PAGE_SIZE,
+ pageToken,
+ });
+ invitations.push(...response.spaceInvitations);
+ pageToken = response.nextPageToken;
+ } while (pageToken);
+
+ return invitations;
+ },
+ enabled: Boolean(viewerName) && (options?.enabled ?? true),
+ });
+}
+
+export function useCreateSpace(viewerName: string) {
const queryClient = useQueryClient();
return useMutation({
@@ -46,7 +203,175 @@ export function useCreateSpace(userName: string) {
space: create(SpaceSchema, { title, description }),
}),
onSuccess: (space) => {
- queryClient.setQueryData(spaceKeys.list(userName), (spaces = []) => [...spaces, space]);
+ queryClient.setQueryData(spaceKeys.list(viewerName), (spaces = []) => upsertByName(spaces, space));
+ },
+ });
+}
+
+export function useUpdateSpace(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: ({ space, updateMask }: UpdateSpaceVariables) =>
+ spaceServiceClient.updateSpace({
+ space: create(SpaceSchema, space as Record),
+ updateMask: create(FieldMaskSchema, { paths: updateMask }),
+ }),
+ onSuccess: (space) => {
+ updateCachedList(queryClient, spaceKeys.list(viewerName), (spaces) => upsertByName(spaces, space));
+ },
+ });
+}
+
+export function useDeleteSpace(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: async ({ name }: DeleteSpaceVariables) => {
+ await spaceServiceClient.deleteSpace({ name });
+ return name;
+ },
+ onSuccess: (spaceName) => {
+ removeSpaceFromViewerCache(queryClient, viewerName, spaceName);
+ invalidateMembershipSensitiveQueries(queryClient);
+ },
+ });
+}
+
+export function useCreateSpaceInvitation(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: ({ parent, spaceInvitation }: CreateSpaceInvitationVariables) =>
+ spaceServiceClient.createSpaceInvitation({
+ parent,
+ spaceInvitation: create(SpaceInvitationSchema, spaceInvitation),
+ }),
+ onSuccess: (invitation, { parent }) => {
+ updateCachedList(queryClient, spaceKeys.spaceInvitations(viewerName, parent), (invitations) =>
+ upsertByName(invitations, invitation),
+ );
+ },
+ });
+}
+
+export function useDeleteSpaceInvitation(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: async ({ name }: SpaceInvitationNameVariables) => {
+ await spaceServiceClient.deleteSpaceInvitation({ name });
+ return name;
+ },
+ onSuccess: (name) => {
+ const spaceName = spaceNameFromChildResource(name);
+ if (spaceName) {
+ updateCachedList(queryClient, spaceKeys.spaceInvitations(viewerName, spaceName), (invitations) =>
+ removeByName(invitations, name),
+ );
+ }
+ updateCachedList(queryClient, spaceKeys.userInvitations(viewerName), (invitations) =>
+ removeByName(invitations, name),
+ );
+ },
+ });
+}
+
+export function useAcceptSpaceInvitation(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: ({ name }: SpaceInvitationNameVariables) => spaceServiceClient.acceptSpaceInvitation({ name }),
+ onSuccess: (member, { name }) => {
+ const userInvitationKey = spaceKeys.userInvitations(viewerName);
+ const spaceName = spaceNameFromChildResource(member.name) ?? spaceNameFromChildResource(name);
+
+ updateCachedList(queryClient, userInvitationKey, (invitations) => removeByName(invitations, name));
+ if (spaceName) {
+ updateCachedList(queryClient, spaceKeys.spaceInvitations(viewerName, spaceName), (invitations) =>
+ removeByName(invitations, name),
+ );
+ updateCachedList(queryClient, spaceKeys.members(viewerName, spaceName), (members) => upsertByName(members, member));
+ }
+
+ // Invitation summaries deliberately omit membership-only Space fields. Never
+ // promote that summary into the member list; refresh the authoritative list.
+ void queryClient.invalidateQueries({ queryKey: spaceKeys.list(viewerName), exact: true });
+ invalidateMembershipSensitiveQueries(queryClient);
+ },
+ });
+}
+
+export function useDeclineSpaceInvitation(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: async ({ name }: SpaceInvitationNameVariables) => {
+ await spaceServiceClient.declineSpaceInvitation({ name });
+ return name;
+ },
+ onSuccess: (name) => {
+ updateCachedList(queryClient, spaceKeys.userInvitations(viewerName), (invitations) =>
+ removeByName(invitations, name),
+ );
+ const spaceName = spaceNameFromChildResource(name);
+ if (spaceName) {
+ updateCachedList(queryClient, spaceKeys.spaceInvitations(viewerName, spaceName), (invitations) =>
+ removeByName(invitations, name),
+ );
+ }
+ },
+ });
+}
+
+export function useUpdateSpaceMember(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: ({ spaceMember, updateMask }: UpdateSpaceMemberVariables) =>
+ spaceServiceClient.updateSpaceMember({
+ spaceMember: create(SpaceMemberSchema, spaceMember as Record),
+ updateMask: create(FieldMaskSchema, { paths: updateMask }),
+ }),
+ onSuccess: (member) => {
+ const spaceName = spaceNameFromChildResource(member.name);
+ if (spaceName) {
+ updateCachedList(queryClient, spaceKeys.members(viewerName, spaceName), (members) => upsertByName(members, member));
+ }
+ if (member.user === viewerName) {
+ void queryClient.invalidateQueries({ queryKey: spaceKeys.list(viewerName), exact: true });
+ }
+ },
+ });
+}
+
+export function useDeleteSpaceMember(viewerName: string) {
+ const queryClient = useQueryClient();
+
+ return useMutation({
+ mutationFn: async ({ name }: DeleteSpaceMemberVariables) => {
+ await spaceServiceClient.deleteSpaceMember({ name });
+ return name;
+ },
+ onSuccess: (name) => {
+ const spaceName = spaceNameFromChildResource(name);
+ if (!spaceName) {
+ return;
+ }
+
+ const memberKey = spaceKeys.members(viewerName, spaceName);
+ const deletedMember = queryClient.getQueryData(memberKey)?.find((member) => member.name === name);
+ const viewerIsDeletedMember =
+ deletedMember?.user === viewerName || (resourceID(name) !== undefined && resourceID(name) === resourceID(viewerName));
+
+ updateCachedList(queryClient, memberKey, (members) => removeByName(members, name));
+ if (viewerIsDeletedMember) {
+ removeSpaceFromViewerCache(queryClient, viewerName, spaceName);
+ invalidateMembershipSensitiveQueries(queryClient);
+ }
+ // Membership counts (and, for self-removal, membership-derived fields) are
+ // authoritative list output. Refresh them without relying on those fields here.
+ void queryClient.invalidateQueries({ queryKey: spaceKeys.list(viewerName), exact: true });
},
});
}
diff --git a/web/src/locales/en.json b/web/src/locales/en.json
index d5c0f34e..74a9683f 100644
--- a/web/src/locales/en.json
+++ b/web/src/locales/en.json
@@ -670,6 +670,87 @@
"my-account": {
"label": "My Account"
},
+ "spaces": {
+ "accept": "Accept",
+ "accept-success": "Invitation accepted. {{space}} is now in Your spaces.",
+ "active-user": "Active Memos user",
+ "admin-role-description": "Can edit this space, invite users, and manage members.",
+ "already-invited": "Invitation already pending",
+ "already-member": "Already a member",
+ "cancel-invitation": "Cancel invitation",
+ "cancel-invitation-confirm-description": "The user will no longer be able to accept this invitation. You can invite them again later.",
+ "cancel-invitation-confirm-title": "Cancel the invitation for @{{username}}?",
+ "cancel-invitation-success": "Invitation cancelled.",
+ "change-role": "Change @{{username}}'s role",
+ "create-scope-note": "You'll become the first admin. Creating it here will not change your current browsing scope.",
+ "create-space": "Create space",
+ "decline": "Decline",
+ "decline-success": "Invitation declined.",
+ "delete-confirm-description": "This permanently deletes the space and the memos placed in it. This action cannot be undone.",
+ "delete-confirm-title": "Delete {{space}}?",
+ "delete-description": "Permanently delete this space and the memos placed in it.",
+ "delete-space": "Delete space",
+ "delete-success": "{{space}} was deleted.",
+ "description": "View spaces you belong to and manage members and invitations.",
+ "description-help": "Explain what this space is for.",
+ "general": "General",
+ "invitation-pending": "Invitation pending",
+ "invitations": "Invitations",
+ "invite-description": "Invite an existing Memos user. They must accept before joining the space.",
+ "invite-member": "Invite member",
+ "invite-success": "Invitation sent to @{{username}}.",
+ "invite-to": "Invite to {{space}}",
+ "invite-yourself": "This is you",
+ "invited-to-join": "You have been invited to join this space.",
+ "label": "Spaces",
+ "last-admin-leave-description": "Assign another Space admin before you leave.",
+ "leave": "Leave",
+ "leave-confirm-description": "You will lose access to the memos and attachments in this space.",
+ "leave-confirm-title": "Leave {{space}}?",
+ "leave-description": "You will lose access to its memos and attachments.",
+ "leave-space": "Leave space",
+ "leave-success": "You left {{space}}.",
+ "load-error": "Failed to load your spaces.",
+ "loading": "Loading spaces...",
+ "loading-invitations": "Loading invitations...",
+ "loading-members": "Loading members...",
+ "manage-space": "Manage {{space}}",
+ "member-count": "{{count}} member",
+ "members": "Members",
+ "members-count": "{{count}} members",
+ "members-description": "People who can view and contribute to this space.",
+ "members-load-error": "Failed to load members.",
+ "memos-user": "Memos user",
+ "no-description": "No description yet.",
+ "no-pending-invitations": "No pending invitations.",
+ "no-spaces": "No spaces yet",
+ "no-spaces-description": "Create a shared place for memos and members. Creating it here will not change your current browsing scope.",
+ "pending-count": "{{count}} pending",
+ "pending-invitations": "Pending invitations",
+ "remove": "Remove",
+ "remove-confirm-description": "They will lose access to the memos and attachments in this space.",
+ "remove-confirm-title": "Remove @{{username}} from this space?",
+ "remove-success": "@{{username}} was removed from the space.",
+ "role-in-space": "Role in this space",
+ "role-update-success": "Member role updated.",
+ "save-changes": "Save changes",
+ "save-success": "Space details saved.",
+ "search-user-placeholder": "Search by exact username",
+ "send-invitation": "Send invitation",
+ "space-admin": "Space admin",
+ "space-count": "{{count}} space",
+ "space-details": "Space details",
+ "space-details-description": "These details are visible to everyone in this space.",
+ "space-user": "Space user",
+ "spaces-count": "{{count}} spaces",
+ "title": "Spaces",
+ "untitled": "Untitled space",
+ "user-not-found": "No active Memos user found for @{{username}}.",
+ "user-role-description": "Can view and contribute to this space.",
+ "you": "You",
+ "your-access": "Your access",
+ "your-spaces": "Your spaces"
+ },
"notification": {
"email-description": "Send email copies for memo comments and mentions. Gmail works with smtp.gmail.com, port 587, STARTTLS, and an app password.",
"email-enabled": "Enable email notifications",
diff --git a/web/src/types/proto/api/v1/space_service_pb.ts b/web/src/types/proto/api/v1/space_service_pb.ts
index 4ab07ec9..18f034f4 100644
--- a/web/src/types/proto/api/v1/space_service_pb.ts
+++ b/web/src/types/proto/api/v1/space_service_pb.ts
@@ -16,7 +16,7 @@ import type { Message } from "@bufbuild/protobuf";
* Describes the file api/v1/space_service.proto.
*/
export const file_api_v1_space_service: GenFile = /*@__PURE__*/
- fileDesc("ChphcGkvdjEvc3BhY2Vfc2VydmljZS5wcm90bxIMbWVtb3MuYXBpLnYxIoYBCgVTcGFjZRIRCgRuYW1lGAEgASgJQgPgQQgSEgoFdGl0bGUYAiABKAlCA+BBAhIYCgtkZXNjcmlwdGlvbhgDIAEoCUID4EEBOjzqQTkKEm1lbW9zLmFwaS52MS9TcGFjZRIOc3BhY2VzL3tzcGFjZX0aBG5hbWUqBnNwYWNlczIFc3BhY2UikAIKC1NwYWNlTWVtYmVyEhEKBG5hbWUYASABKAlCA+BBCBInCgR1c2VyGAIgASgJQhngQQL6QRMKEW1lbW9zLmFwaS52MS9Vc2VyEjEKBHJvbGUYAyABKA4yHi5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXIuUm9sZUID4EECIjEKBFJvbGUSFAoQUk9MRV9VTlNQRUNJRklFRBAAEgkKBUFETUlOEAESCAoEVVNFUhACOl/qQVwKGG1lbW9zLmFwaS52MS9TcGFjZU1lbWJlchIfc3BhY2VzL3tzcGFjZX0vbWVtYmVycy97bWVtYmVyfRoEbmFtZSoMc3BhY2VNZW1iZXJzMgtzcGFjZU1lbWJlciKhAgoPU3BhY2VJbnZpdGF0aW9uEhEKBG5hbWUYASABKAlCA+BBCBIqCgdpbnZpdGVlGAIgASgJQhngQQL6QRMKEW1lbW9zLmFwaS52MS9Vc2VyEjEKBHJvbGUYAyABKA4yHi5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXIuUm9sZUID4EECEicKBXNwYWNlGAQgASgLMhMubWVtb3MuYXBpLnYxLlNwYWNlQgPgQQM6c+pBcAocbWVtb3MuYXBpLnYxL1NwYWNlSW52aXRhdGlvbhInc3BhY2VzL3tzcGFjZX0vaW52aXRhdGlvbnMve2ludml0YXRpb259GgRuYW1lKhBzcGFjZUludml0YXRpb25zMg9zcGFjZUludml0YXRpb24iVAoSQ3JlYXRlU3BhY2VSZXF1ZXN0EicKBXNwYWNlGAEgASgLMhMubWVtb3MuYXBpLnYxLlNwYWNlQgPgQQISFQoIc3BhY2VfaWQYAiABKAlCA+BBASJEChFMaXN0U3BhY2VzUmVxdWVzdBIWCglwYWdlX3NpemUYASABKAVCA+BBARIXCgpwYWdlX3Rva2VuGAIgASgJQgPgQQEiUgoSTGlzdFNwYWNlc1Jlc3BvbnNlEiMKBnNwYWNlcxgBIAMoCzITLm1lbW9zLmFwaS52MS5TcGFjZRIXCg9uZXh0X3BhZ2VfdG9rZW4YAiABKAkiOwoPR2V0U3BhY2VSZXF1ZXN0EigKBG5hbWUYASABKAlCGuBBAvpBFAoSbWVtb3MuYXBpLnYxL1NwYWNlInMKElVwZGF0ZVNwYWNlUmVxdWVzdBInCgVzcGFjZRgBIAEoCzITLm1lbW9zLmFwaS52MS5TcGFjZUID4EECEjQKC3VwZGF0ZV9tYXNrGAIgASgLMhouZ29vZ2xlLnByb3RvYnVmLkZpZWxkTWFza0ID4EECIj4KEkRlbGV0ZVNwYWNlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEm1lbW9zLmFwaS52MS9TcGFjZSKSAQocQ3JlYXRlU3BhY2VJbnZpdGF0aW9uUmVxdWVzdBI0CgZwYXJlbnQYASABKAlCJOBBAvpBHhIcbWVtb3MuYXBpLnYxL1NwYWNlSW52aXRhdGlvbhI8ChBzcGFjZV9pbnZpdGF0aW9uGAIgASgLMh0ubWVtb3MuYXBpLnYxLlNwYWNlSW52aXRhdGlvbkID4EECIoQBChtMaXN0U3BhY2VJbnZpdGF0aW9uc1JlcXVlc3QSNAoGcGFyZW50GAEgASgJQiTgQQL6QR4SHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24SFgoJcGFnZV9zaXplGAIgASgFQgPgQQESFwoKcGFnZV90b2tlbhgDIAEoCUID4EEBInEKHExpc3RTcGFjZUludml0YXRpb25zUmVzcG9uc2USOAoRc3BhY2VfaW52aXRhdGlvbnMYASADKAsyHS5tZW1vcy5hcGkudjEuU3BhY2VJbnZpdGF0aW9uEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSJ9Ch9MaXN0VXNlclNwYWNlSW52aXRhdGlvbnNSZXF1ZXN0EikKBnBhcmVudBgBIAEoCUIZ4EEC+kETChFtZW1vcy5hcGkudjEvVXNlchIWCglwYWdlX3NpemUYAiABKAVCA+BBARIXCgpwYWdlX3Rva2VuGAMgASgJQgPgQQEidQogTGlzdFVzZXJTcGFjZUludml0YXRpb25zUmVzcG9uc2USOAoRc3BhY2VfaW52aXRhdGlvbnMYASADKAsyHS5tZW1vcy5hcGkudjEuU3BhY2VJbnZpdGF0aW9uEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSJPChlHZXRTcGFjZUludml0YXRpb25SZXF1ZXN0EjIKBG5hbWUYASABKAlCJOBBAvpBHgocbWVtb3MuYXBpLnYxL1NwYWNlSW52aXRhdGlvbiJSChxEZWxldGVTcGFjZUludml0YXRpb25SZXF1ZXN0EjIKBG5hbWUYASABKAlCJOBBAvpBHgocbWVtb3MuYXBpLnYxL1NwYWNlSW52aXRhdGlvbiJSChxBY2NlcHRTcGFjZUludml0YXRpb25SZXF1ZXN0EjIKBG5hbWUYASABKAlCJOBBAvpBHgocbWVtb3MuYXBpLnYxL1NwYWNlSW52aXRhdGlvbiJTCh1EZWNsaW5lU3BhY2VJbnZpdGF0aW9uUmVxdWVzdBIyCgRuYW1lGAEgASgJQiTgQQL6QR4KHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24ifAoXTGlzdFNwYWNlTWVtYmVyc1JlcXVlc3QSMAoGcGFyZW50GAEgASgJQiDgQQL6QRoSGG1lbW9zLmFwaS52MS9TcGFjZU1lbWJlchIWCglwYWdlX3NpemUYAiABKAVCA+BBARIXCgpwYWdlX3Rva2VuGAMgASgJQgPgQQEiZQoYTGlzdFNwYWNlTWVtYmVyc1Jlc3BvbnNlEjAKDXNwYWNlX21lbWJlcnMYASADKAsyGS5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXISFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJIkcKFUdldFNwYWNlTWVtYmVyUmVxdWVzdBIuCgRuYW1lGAEgASgJQiDgQQL6QRoKGG1lbW9zLmFwaS52MS9TcGFjZU1lbWJlciKGAQoYVXBkYXRlU3BhY2VNZW1iZXJSZXF1ZXN0EjQKDHNwYWNlX21lbWJlchgBIAEoCzIZLm1lbW9zLmFwaS52MS5TcGFjZU1lbWJlckID4EECEjQKC3VwZGF0ZV9tYXNrGAIgASgLMhouZ29vZ2xlLnByb3RvYnVmLkZpZWxkTWFza0ID4EECIkoKGERlbGV0ZVNwYWNlTWVtYmVyUmVxdWVzdBIuCgRuYW1lGAEgASgJQiDgQQL6QRoKGG1lbW9zLmFwaS52MS9TcGFjZU1lbWJlcjKzEgoMU3BhY2VTZXJ2aWNlEmsKC0NyZWF0ZVNwYWNlEiAubWVtb3MuYXBpLnYxLkNyZWF0ZVNwYWNlUmVxdWVzdBoTLm1lbW9zLmFwaS52MS5TcGFjZSIl2kEFc3BhY2WC0+STAhc6BXNwYWNlIg4vYXBpL3YxL3NwYWNlcxJqCgpMaXN0U3BhY2VzEh8ubWVtb3MuYXBpLnYxLkxpc3RTcGFjZXNSZXF1ZXN0GiAubWVtb3MuYXBpLnYxLkxpc3RTcGFjZXNSZXNwb25zZSIZ2kEAgtPkkwIQEg4vYXBpL3YxL3NwYWNlcxJmCghHZXRTcGFjZRIdLm1lbW9zLmFwaS52MS5HZXRTcGFjZVJlcXVlc3QaEy5tZW1vcy5hcGkudjEuU3BhY2UiJtpBBG5hbWWC0+STAhkSFy9hcGkvdjEve25hbWU9c3BhY2VzLyp9EoYBCgtVcGRhdGVTcGFjZRIgLm1lbW9zLmFwaS52MS5VcGRhdGVTcGFjZVJlcXVlc3QaEy5tZW1vcy5hcGkudjEuU3BhY2UiQNpBEXNwYWNlLHVwZGF0ZV9tYXNrgtPkkwImOgVzcGFjZTIdL2FwaS92MS97c3BhY2UubmFtZT1zcGFjZXMvKn0SbwoLRGVsZXRlU3BhY2USIC5tZW1vcy5hcGkudjEuRGVsZXRlU3BhY2VSZXF1ZXN0GhYuZ29vZ2xlLnByb3RvYnVmLkVtcHR5IibaQQRuYW1lgtPkkwIZKhcvYXBpL3YxL3tuYW1lPXNwYWNlcy8qfRK9AQoVQ3JlYXRlU3BhY2VJbnZpdGF0aW9uEioubWVtb3MuYXBpLnYxLkNyZWF0ZVNwYWNlSW52aXRhdGlvblJlcXVlc3QaHS5tZW1vcy5hcGkudjEuU3BhY2VJbnZpdGF0aW9uIlnaQRdwYXJlbnQsc3BhY2VfaW52aXRhdGlvboLT5JMCOToQc3BhY2VfaW52aXRhdGlvbiIlL2FwaS92MS97cGFyZW50PXNwYWNlcy8qfS9pbnZpdGF0aW9ucxKlAQoUTGlzdFNwYWNlSW52aXRhdGlvbnMSKS5tZW1vcy5hcGkudjEuTGlzdFNwYWNlSW52aXRhdGlvbnNSZXF1ZXN0GioubWVtb3MuYXBpLnYxLkxpc3RTcGFjZUludml0YXRpb25zUmVzcG9uc2UiNtpBBnBhcmVudILT5JMCJxIlL2FwaS92MS97cGFyZW50PXNwYWNlcy8qfS9pbnZpdGF0aW9ucxK1AQoYTGlzdFVzZXJTcGFjZUludml0YXRpb25zEi0ubWVtb3MuYXBpLnYxLkxpc3RVc2VyU3BhY2VJbnZpdGF0aW9uc1JlcXVlc3QaLi5tZW1vcy5hcGkudjEuTGlzdFVzZXJTcGFjZUludml0YXRpb25zUmVzcG9uc2UiOtpBBnBhcmVudILT5JMCKxIpL2FwaS92MS97cGFyZW50PXVzZXJzLyp9L3NwYWNlSW52aXRhdGlvbnMSkgEKEkdldFNwYWNlSW52aXRhdGlvbhInLm1lbW9zLmFwaS52MS5HZXRTcGFjZUludml0YXRpb25SZXF1ZXN0Gh0ubWVtb3MuYXBpLnYxLlNwYWNlSW52aXRhdGlvbiI02kEEbmFtZYLT5JMCJxIlL2FwaS92MS97bmFtZT1zcGFjZXMvKi9pbnZpdGF0aW9ucy8qfRKRAQoVRGVsZXRlU3BhY2VJbnZpdGF0aW9uEioubWVtb3MuYXBpLnYxLkRlbGV0ZVNwYWNlSW52aXRhdGlvblJlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiNNpBBG5hbWWC0+STAicqJS9hcGkvdjEve25hbWU9c3BhY2VzLyovaW52aXRhdGlvbnMvKn0SngEKFUFjY2VwdFNwYWNlSW52aXRhdGlvbhIqLm1lbW9zLmFwaS52MS5BY2NlcHRTcGFjZUludml0YXRpb25SZXF1ZXN0GhkubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyIj7aQQRuYW1lgtPkkwIxOgEqIiwvYXBpL3YxL3tuYW1lPXNwYWNlcy8qL2ludml0YXRpb25zLyp9OmFjY2VwdBKeAQoWRGVjbGluZVNwYWNlSW52aXRhdGlvbhIrLm1lbW9zLmFwaS52MS5EZWNsaW5lU3BhY2VJbnZpdGF0aW9uUmVxdWVzdBoWLmdvb2dsZS5wcm90b2J1Zi5FbXB0eSI/2kEEbmFtZYLT5JMCMjoBKiItL2FwaS92MS97bmFtZT1zcGFjZXMvKi9pbnZpdGF0aW9ucy8qfTpkZWNsaW5lEpUBChBMaXN0U3BhY2VNZW1iZXJzEiUubWVtb3MuYXBpLnYxLkxpc3RTcGFjZU1lbWJlcnNSZXF1ZXN0GiYubWVtb3MuYXBpLnYxLkxpc3RTcGFjZU1lbWJlcnNSZXNwb25zZSIy2kEGcGFyZW50gtPkkwIjEiEvYXBpL3YxL3twYXJlbnQ9c3BhY2VzLyp9L21lbWJlcnMSggEKDkdldFNwYWNlTWVtYmVyEiMubWVtb3MuYXBpLnYxLkdldFNwYWNlTWVtYmVyUmVxdWVzdBoZLm1lbW9zLmFwaS52MS5TcGFjZU1lbWJlciIw2kEEbmFtZYLT5JMCIxIhL2FwaS92MS97bmFtZT1zcGFjZXMvKi9tZW1iZXJzLyp9ErcBChFVcGRhdGVTcGFjZU1lbWJlchImLm1lbW9zLmFwaS52MS5VcGRhdGVTcGFjZU1lbWJlclJlcXVlc3QaGS5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXIiX9pBGHNwYWNlX21lbWJlcix1cGRhdGVfbWFza4LT5JMCPjoMc3BhY2VfbWVtYmVyMi4vYXBpL3YxL3tzcGFjZV9tZW1iZXIubmFtZT1zcGFjZXMvKi9tZW1iZXJzLyp9EoUBChFEZWxldGVTcGFjZU1lbWJlchImLm1lbW9zLmFwaS52MS5EZWxldGVTcGFjZU1lbWJlclJlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiMNpBBG5hbWWC0+STAiMqIS9hcGkvdjEve25hbWU9c3BhY2VzLyovbWVtYmVycy8qfUKpAQoQY29tLm1lbW9zLmFwaS52MUIRU3BhY2VTZXJ2aWNlUHJvdG9QAVowZ2l0aHViLmNvbS91c2VtZW1vcy9tZW1vcy9wcm90by9nZW4vYXBpL3YxO2FwaXYxogIDTUFYqgIMTWVtb3MuQXBpLlYxygIMTWVtb3NcQXBpXFYx4gIYTWVtb3NcQXBpXFYxXEdQQk1ldGFkYXRh6gIOTWVtb3M6OkFwaTo6VjFiBnByb3RvMw", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask]);
+ fileDesc("ChphcGkvdjEvc3BhY2Vfc2VydmljZS5wcm90bxIMbWVtb3MuYXBpLnYxIuEBCgVTcGFjZRIRCgRuYW1lGAEgASgJQgPgQQgSEgoFdGl0bGUYAiABKAlCA+BBAhIYCgtkZXNjcmlwdGlvbhgDIAEoCUID4EEBEj4KEWN1cnJlbnRfdXNlcl9yb2xlGAQgASgOMh4ubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyLlJvbGVCA+BBAxIZCgxtZW1iZXJfY291bnQYBSABKAVCA+BBAzo86kE5ChJtZW1vcy5hcGkudjEvU3BhY2USDnNwYWNlcy97c3BhY2V9GgRuYW1lKgZzcGFjZXMyBXNwYWNlIpACCgtTcGFjZU1lbWJlchIRCgRuYW1lGAEgASgJQgPgQQgSJwoEdXNlchgCIAEoCUIZ4EEC+kETChFtZW1vcy5hcGkudjEvVXNlchIxCgRyb2xlGAMgASgOMh4ubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyLlJvbGVCA+BBAiIxCgRSb2xlEhQKEFJPTEVfVU5TUEVDSUZJRUQQABIJCgVBRE1JThABEggKBFVTRVIQAjpf6kFcChhtZW1vcy5hcGkudjEvU3BhY2VNZW1iZXISH3NwYWNlcy97c3BhY2V9L21lbWJlcnMve21lbWJlcn0aBG5hbWUqDHNwYWNlTWVtYmVyczILc3BhY2VNZW1iZXIioQIKD1NwYWNlSW52aXRhdGlvbhIRCgRuYW1lGAEgASgJQgPgQQgSKgoHaW52aXRlZRgCIAEoCUIZ4EEC+kETChFtZW1vcy5hcGkudjEvVXNlchIxCgRyb2xlGAMgASgOMh4ubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyLlJvbGVCA+BBAhInCgVzcGFjZRgEIAEoCzITLm1lbW9zLmFwaS52MS5TcGFjZUID4EEDOnPqQXAKHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24SJ3NwYWNlcy97c3BhY2V9L2ludml0YXRpb25zL3tpbnZpdGF0aW9ufRoEbmFtZSoQc3BhY2VJbnZpdGF0aW9uczIPc3BhY2VJbnZpdGF0aW9uIlQKEkNyZWF0ZVNwYWNlUmVxdWVzdBInCgVzcGFjZRgBIAEoCzITLm1lbW9zLmFwaS52MS5TcGFjZUID4EECEhUKCHNwYWNlX2lkGAIgASgJQgPgQQEiRAoRTGlzdFNwYWNlc1JlcXVlc3QSFgoJcGFnZV9zaXplGAEgASgFQgPgQQESFwoKcGFnZV90b2tlbhgCIAEoCUID4EEBIlIKEkxpc3RTcGFjZXNSZXNwb25zZRIjCgZzcGFjZXMYASADKAsyEy5tZW1vcy5hcGkudjEuU3BhY2USFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJIjsKD0dldFNwYWNlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEm1lbW9zLmFwaS52MS9TcGFjZSJzChJVcGRhdGVTcGFjZVJlcXVlc3QSJwoFc3BhY2UYASABKAsyEy5tZW1vcy5hcGkudjEuU3BhY2VCA+BBAhI0Cgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2tCA+BBAiI+ChJEZWxldGVTcGFjZVJlcXVlc3QSKAoEbmFtZRgBIAEoCUIa4EEC+kEUChJtZW1vcy5hcGkudjEvU3BhY2UikgEKHENyZWF0ZVNwYWNlSW52aXRhdGlvblJlcXVlc3QSNAoGcGFyZW50GAEgASgJQiTgQQL6QR4SHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24SPAoQc3BhY2VfaW52aXRhdGlvbhgCIAEoCzIdLm1lbW9zLmFwaS52MS5TcGFjZUludml0YXRpb25CA+BBAiKEAQobTGlzdFNwYWNlSW52aXRhdGlvbnNSZXF1ZXN0EjQKBnBhcmVudBgBIAEoCUIk4EEC+kEeEhxtZW1vcy5hcGkudjEvU3BhY2VJbnZpdGF0aW9uEhYKCXBhZ2Vfc2l6ZRgCIAEoBUID4EEBEhcKCnBhZ2VfdG9rZW4YAyABKAlCA+BBASJxChxMaXN0U3BhY2VJbnZpdGF0aW9uc1Jlc3BvbnNlEjgKEXNwYWNlX2ludml0YXRpb25zGAEgAygLMh0ubWVtb3MuYXBpLnYxLlNwYWNlSW52aXRhdGlvbhIXCg9uZXh0X3BhZ2VfdG9rZW4YAiABKAkifQofTGlzdFVzZXJTcGFjZUludml0YXRpb25zUmVxdWVzdBIpCgZwYXJlbnQYASABKAlCGeBBAvpBEwoRbWVtb3MuYXBpLnYxL1VzZXISFgoJcGFnZV9zaXplGAIgASgFQgPgQQESFwoKcGFnZV90b2tlbhgDIAEoCUID4EEBInUKIExpc3RVc2VyU3BhY2VJbnZpdGF0aW9uc1Jlc3BvbnNlEjgKEXNwYWNlX2ludml0YXRpb25zGAEgAygLMh0ubWVtb3MuYXBpLnYxLlNwYWNlSW52aXRhdGlvbhIXCg9uZXh0X3BhZ2VfdG9rZW4YAiABKAkiTwoZR2V0U3BhY2VJbnZpdGF0aW9uUmVxdWVzdBIyCgRuYW1lGAEgASgJQiTgQQL6QR4KHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24iUgocRGVsZXRlU3BhY2VJbnZpdGF0aW9uUmVxdWVzdBIyCgRuYW1lGAEgASgJQiTgQQL6QR4KHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24iUgocQWNjZXB0U3BhY2VJbnZpdGF0aW9uUmVxdWVzdBIyCgRuYW1lGAEgASgJQiTgQQL6QR4KHG1lbW9zLmFwaS52MS9TcGFjZUludml0YXRpb24iUwodRGVjbGluZVNwYWNlSW52aXRhdGlvblJlcXVlc3QSMgoEbmFtZRgBIAEoCUIk4EEC+kEeChxtZW1vcy5hcGkudjEvU3BhY2VJbnZpdGF0aW9uInwKF0xpc3RTcGFjZU1lbWJlcnNSZXF1ZXN0EjAKBnBhcmVudBgBIAEoCUIg4EEC+kEaEhhtZW1vcy5hcGkudjEvU3BhY2VNZW1iZXISFgoJcGFnZV9zaXplGAIgASgFQgPgQQESFwoKcGFnZV90b2tlbhgDIAEoCUID4EEBImUKGExpc3RTcGFjZU1lbWJlcnNSZXNwb25zZRIwCg1zcGFjZV9tZW1iZXJzGAEgAygLMhkubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSJHChVHZXRTcGFjZU1lbWJlclJlcXVlc3QSLgoEbmFtZRgBIAEoCUIg4EEC+kEaChhtZW1vcy5hcGkudjEvU3BhY2VNZW1iZXIihgEKGFVwZGF0ZVNwYWNlTWVtYmVyUmVxdWVzdBI0CgxzcGFjZV9tZW1iZXIYASABKAsyGS5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXJCA+BBAhI0Cgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2tCA+BBAiJKChhEZWxldGVTcGFjZU1lbWJlclJlcXVlc3QSLgoEbmFtZRgBIAEoCUIg4EEC+kEaChhtZW1vcy5hcGkudjEvU3BhY2VNZW1iZXIysxIKDFNwYWNlU2VydmljZRJrCgtDcmVhdGVTcGFjZRIgLm1lbW9zLmFwaS52MS5DcmVhdGVTcGFjZVJlcXVlc3QaEy5tZW1vcy5hcGkudjEuU3BhY2UiJdpBBXNwYWNlgtPkkwIXOgVzcGFjZSIOL2FwaS92MS9zcGFjZXMSagoKTGlzdFNwYWNlcxIfLm1lbW9zLmFwaS52MS5MaXN0U3BhY2VzUmVxdWVzdBogLm1lbW9zLmFwaS52MS5MaXN0U3BhY2VzUmVzcG9uc2UiGdpBAILT5JMCEBIOL2FwaS92MS9zcGFjZXMSZgoIR2V0U3BhY2USHS5tZW1vcy5hcGkudjEuR2V0U3BhY2VSZXF1ZXN0GhMubWVtb3MuYXBpLnYxLlNwYWNlIibaQQRuYW1lgtPkkwIZEhcvYXBpL3YxL3tuYW1lPXNwYWNlcy8qfRKGAQoLVXBkYXRlU3BhY2USIC5tZW1vcy5hcGkudjEuVXBkYXRlU3BhY2VSZXF1ZXN0GhMubWVtb3MuYXBpLnYxLlNwYWNlIkDaQRFzcGFjZSx1cGRhdGVfbWFza4LT5JMCJjoFc3BhY2UyHS9hcGkvdjEve3NwYWNlLm5hbWU9c3BhY2VzLyp9Em8KC0RlbGV0ZVNwYWNlEiAubWVtb3MuYXBpLnYxLkRlbGV0ZVNwYWNlUmVxdWVzdBoWLmdvb2dsZS5wcm90b2J1Zi5FbXB0eSIm2kEEbmFtZYLT5JMCGSoXL2FwaS92MS97bmFtZT1zcGFjZXMvKn0SvQEKFUNyZWF0ZVNwYWNlSW52aXRhdGlvbhIqLm1lbW9zLmFwaS52MS5DcmVhdGVTcGFjZUludml0YXRpb25SZXF1ZXN0Gh0ubWVtb3MuYXBpLnYxLlNwYWNlSW52aXRhdGlvbiJZ2kEXcGFyZW50LHNwYWNlX2ludml0YXRpb26C0+STAjk6EHNwYWNlX2ludml0YXRpb24iJS9hcGkvdjEve3BhcmVudD1zcGFjZXMvKn0vaW52aXRhdGlvbnMSpQEKFExpc3RTcGFjZUludml0YXRpb25zEikubWVtb3MuYXBpLnYxLkxpc3RTcGFjZUludml0YXRpb25zUmVxdWVzdBoqLm1lbW9zLmFwaS52MS5MaXN0U3BhY2VJbnZpdGF0aW9uc1Jlc3BvbnNlIjbaQQZwYXJlbnSC0+STAicSJS9hcGkvdjEve3BhcmVudD1zcGFjZXMvKn0vaW52aXRhdGlvbnMStQEKGExpc3RVc2VyU3BhY2VJbnZpdGF0aW9ucxItLm1lbW9zLmFwaS52MS5MaXN0VXNlclNwYWNlSW52aXRhdGlvbnNSZXF1ZXN0Gi4ubWVtb3MuYXBpLnYxLkxpc3RVc2VyU3BhY2VJbnZpdGF0aW9uc1Jlc3BvbnNlIjraQQZwYXJlbnSC0+STAisSKS9hcGkvdjEve3BhcmVudD11c2Vycy8qfS9zcGFjZUludml0YXRpb25zEpIBChJHZXRTcGFjZUludml0YXRpb24SJy5tZW1vcy5hcGkudjEuR2V0U3BhY2VJbnZpdGF0aW9uUmVxdWVzdBodLm1lbW9zLmFwaS52MS5TcGFjZUludml0YXRpb24iNNpBBG5hbWWC0+STAicSJS9hcGkvdjEve25hbWU9c3BhY2VzLyovaW52aXRhdGlvbnMvKn0SkQEKFURlbGV0ZVNwYWNlSW52aXRhdGlvbhIqLm1lbW9zLmFwaS52MS5EZWxldGVTcGFjZUludml0YXRpb25SZXF1ZXN0GhYuZ29vZ2xlLnByb3RvYnVmLkVtcHR5IjTaQQRuYW1lgtPkkwInKiUvYXBpL3YxL3tuYW1lPXNwYWNlcy8qL2ludml0YXRpb25zLyp9Ep4BChVBY2NlcHRTcGFjZUludml0YXRpb24SKi5tZW1vcy5hcGkudjEuQWNjZXB0U3BhY2VJbnZpdGF0aW9uUmVxdWVzdBoZLm1lbW9zLmFwaS52MS5TcGFjZU1lbWJlciI+2kEEbmFtZYLT5JMCMToBKiIsL2FwaS92MS97bmFtZT1zcGFjZXMvKi9pbnZpdGF0aW9ucy8qfTphY2NlcHQSngEKFkRlY2xpbmVTcGFjZUludml0YXRpb24SKy5tZW1vcy5hcGkudjEuRGVjbGluZVNwYWNlSW52aXRhdGlvblJlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiP9pBBG5hbWWC0+STAjI6ASoiLS9hcGkvdjEve25hbWU9c3BhY2VzLyovaW52aXRhdGlvbnMvKn06ZGVjbGluZRKVAQoQTGlzdFNwYWNlTWVtYmVycxIlLm1lbW9zLmFwaS52MS5MaXN0U3BhY2VNZW1iZXJzUmVxdWVzdBomLm1lbW9zLmFwaS52MS5MaXN0U3BhY2VNZW1iZXJzUmVzcG9uc2UiMtpBBnBhcmVudILT5JMCIxIhL2FwaS92MS97cGFyZW50PXNwYWNlcy8qfS9tZW1iZXJzEoIBCg5HZXRTcGFjZU1lbWJlchIjLm1lbW9zLmFwaS52MS5HZXRTcGFjZU1lbWJlclJlcXVlc3QaGS5tZW1vcy5hcGkudjEuU3BhY2VNZW1iZXIiMNpBBG5hbWWC0+STAiMSIS9hcGkvdjEve25hbWU9c3BhY2VzLyovbWVtYmVycy8qfRK3AQoRVXBkYXRlU3BhY2VNZW1iZXISJi5tZW1vcy5hcGkudjEuVXBkYXRlU3BhY2VNZW1iZXJSZXF1ZXN0GhkubWVtb3MuYXBpLnYxLlNwYWNlTWVtYmVyIl/aQRhzcGFjZV9tZW1iZXIsdXBkYXRlX21hc2uC0+STAj46DHNwYWNlX21lbWJlcjIuL2FwaS92MS97c3BhY2VfbWVtYmVyLm5hbWU9c3BhY2VzLyovbWVtYmVycy8qfRKFAQoRRGVsZXRlU3BhY2VNZW1iZXISJi5tZW1vcy5hcGkudjEuRGVsZXRlU3BhY2VNZW1iZXJSZXF1ZXN0GhYuZ29vZ2xlLnByb3RvYnVmLkVtcHR5IjDaQQRuYW1lgtPkkwIjKiEvYXBpL3YxL3tuYW1lPXNwYWNlcy8qL21lbWJlcnMvKn1CqQEKEGNvbS5tZW1vcy5hcGkudjFCEVNwYWNlU2VydmljZVByb3RvUAFaMGdpdGh1Yi5jb20vdXNlbWVtb3MvbWVtb3MvcHJvdG8vZ2VuL2FwaS92MTthcGl2MaICA01BWKoCDE1lbW9zLkFwaS5WMcoCDE1lbW9zXEFwaVxWMeICGE1lbW9zXEFwaVxWMVxHUEJNZXRhZGF0YeoCDk1lbW9zOjpBcGk6OlYxYgZwcm90bzM", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask]);
/**
* Space is a collaboration boundary for placed memos.
@@ -44,6 +44,22 @@ export type Space = Message<"memos.api.v1.Space"> & {
* @generated from field: string description = 3;
*/
description: string;
+
+ /**
+ * Output only. The authenticated user's membership role in this space.
+ * ROLE_UNSPECIFIED when this Space is exposed as metadata-only.
+ *
+ * @generated from field: memos.api.v1.SpaceMember.Role current_user_role = 4;
+ */
+ currentUserRole: SpaceMember_Role;
+
+ /**
+ * Output only. The number of accepted members in this space. Pending
+ * invitations are excluded. Zero when this Space is exposed as metadata-only.
+ *
+ * @generated from field: int32 member_count = 5;
+ */
+ memberCount: number;
};
/**
diff --git a/web/tests/create-space-dialog.test.tsx b/web/tests/create-space-dialog.test.tsx
index 8be2ca7a..4434eb8e 100644
--- a/web/tests/create-space-dialog.test.tsx
+++ b/web/tests/create-space-dialog.test.tsx
@@ -5,7 +5,7 @@ import CreateSpaceDialog from "@/components/CreateSpaceDialog";
const mocks = vi.hoisted(() => ({
mutateAsync: vi.fn(),
onOpenChange: vi.fn(),
- selectSpace: vi.fn(),
+ onCreated: vi.fn(),
toastSuccess: vi.fn(),
isPending: false,
}));
@@ -14,10 +14,6 @@ vi.mock("react-hot-toast", () => ({
toast: { error: vi.fn(), success: mocks.toastSuccess },
}));
-vi.mock("@/contexts/SpaceContext", () => ({
- useSpaceContext: () => ({ selectSpace: mocks.selectSpace }),
-}));
-
vi.mock("@/hooks/useCurrentUser", () => ({
default: () => ({ name: "users/test" }),
}));
@@ -34,20 +30,31 @@ describe("CreateSpaceDialog", () => {
beforeEach(() => {
mocks.mutateAsync.mockReset().mockResolvedValue({ name: "spaces/product", title: "Product", description: "Plans" });
mocks.onOpenChange.mockClear();
- mocks.selectSpace.mockClear();
+ mocks.onCreated.mockClear();
mocks.toastSuccess.mockClear();
mocks.isPending = false;
});
- it("creates and immediately selects the new Space", async () => {
- render();
+ it("creates and reports the new Space to the caller", async () => {
+ render();
fireEvent.change(screen.getByLabelText("common.name"), { target: { value: " Product " } });
fireEvent.change(screen.getByLabelText("common.description"), { target: { value: " Plans " } });
fireEvent.click(screen.getByRole("button", { name: "common.create" }));
await waitFor(() => expect(mocks.mutateAsync).toHaveBeenCalledWith({ title: "Product", description: "Plans" }));
- expect(mocks.selectSpace).toHaveBeenCalledWith({ name: "spaces/product", title: "Product", description: "Plans" });
+ expect(mocks.onCreated).toHaveBeenCalledWith({ name: "spaces/product", title: "Product", description: "Plans" });
+ expect(mocks.onOpenChange).toHaveBeenCalledWith(false);
+ });
+
+ it("can create without activating the new Space", async () => {
+ render();
+
+ fireEvent.change(screen.getByLabelText("common.name"), { target: { value: "Product" } });
+ fireEvent.click(screen.getByRole("button", { name: "common.create" }));
+
+ await waitFor(() => expect(mocks.mutateAsync).toHaveBeenCalledOnce());
+ expect(mocks.onCreated).not.toHaveBeenCalled();
expect(mocks.onOpenChange).toHaveBeenCalledWith(false);
});
@@ -58,12 +65,12 @@ describe("CreateSpaceDialog", () => {
resolveCreate = resolve;
}),
);
- const view = render();
+ const view = render();
fireEvent.change(screen.getByLabelText("common.name"), { target: { value: "Product" } });
fireEvent.click(screen.getByRole("button", { name: "common.create" }));
mocks.isPending = true;
- view.rerender();
+ view.rerender();
fireEvent.click(screen.getByRole("button", { name: "Close" }));
expect(mocks.onOpenChange).not.toHaveBeenCalled();
expect(screen.getByRole("dialog")).toBeInTheDocument();
@@ -71,7 +78,7 @@ describe("CreateSpaceDialog", () => {
await act(async () => {
resolveCreate({ name: "spaces/product", title: "Product", description: "" });
});
- expect(mocks.selectSpace).toHaveBeenCalledWith({ name: "spaces/product", title: "Product", description: "" });
+ expect(mocks.onCreated).toHaveBeenCalledWith({ name: "spaces/product", title: "Product", description: "" });
expect(mocks.onOpenChange).toHaveBeenCalledWith(false);
});
});
diff --git a/web/tests/invite-space-member-dialog.test.tsx b/web/tests/invite-space-member-dialog.test.tsx
new file mode 100644
index 00000000..258505b9
--- /dev/null
+++ b/web/tests/invite-space-member-dialog.test.tsx
@@ -0,0 +1,144 @@
+import { act, fireEvent, render, screen } from "@testing-library/react";
+import type { ReactNode } from "react";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import InviteSpaceMemberDialog from "@/components/Settings/InviteSpaceMemberDialog";
+import { State } from "@/types/proto/api/v1/common_pb";
+import { type Space, SpaceMember_Role } from "@/types/proto/api/v1/space_service_pb";
+import type { User } from "@/types/proto/api/v1/user_service_pb";
+
+const state = vi.hoisted(() => ({
+ candidate: undefined as User | undefined,
+ requestedUsernames: [] as string[][],
+ mutateAsync: vi.fn(),
+ onOpenChange: vi.fn(),
+}));
+
+vi.mock("react-hot-toast", () => ({
+ default: { error: vi.fn(), success: vi.fn() },
+}));
+
+vi.mock("@/hooks/useSpaceQueries", () => ({
+ useCreateSpaceInvitation: () => ({ isPending: false, mutateAsync: state.mutateAsync }),
+}));
+
+vi.mock("@/hooks/useUserQueries", () => ({
+ useUsersByUsernames: (usernames: string[]) => {
+ state.requestedUsernames.push(usernames);
+ const username = usernames[0];
+ return {
+ data: new Map(username && state.candidate?.username === username ? [[username, state.candidate]] : []),
+ isFetching: false,
+ isSuccess: true,
+ };
+ },
+}));
+
+vi.mock("@/components/UserAvatar", () => ({
+ default: () => ,
+}));
+
+vi.mock("@/components/ui/dialog", () => ({
+ Dialog: ({ open, children }: { open: boolean; children: ReactNode }) => (open ? children : null),
+ DialogContent: ({ children }: { children: ReactNode }) => {children}
,
+ DialogDescription: ({ children }: { children: ReactNode }) => {children}
,
+ DialogFooter: ({ children }: { children: ReactNode }) => {children}
,
+ DialogHeader: ({ children }: { children: ReactNode }) => {children}
,
+ DialogTitle: ({ children }: { children: ReactNode }) => {children}
,
+}));
+
+vi.mock("@/components/ui/select", () => ({
+ Select: ({ value, onValueChange }: { value: string; onValueChange: (value: string) => void }) => (
+
+ ),
+ SelectContent: () => null,
+ SelectItem: () => null,
+ SelectTrigger: () => null,
+ SelectValue: () => null,
+}));
+
+vi.mock("@/utils/i18n", () => ({
+ useTranslate: () => (key: string) => {
+ const copy: Record = {
+ "setting.spaces.active-user": "Active Memos user",
+ "setting.spaces.invite-description": "Invite an existing Memos user. They must accept before joining the space.",
+ "setting.spaces.memos-user": "Memos user",
+ "setting.spaces.search-user-placeholder": "Search by exact username",
+ "setting.spaces.send-invitation": "Send invitation",
+ };
+ return copy[key] ?? key;
+ },
+}));
+
+const productSpace: Space = {
+ $typeName: "memos.api.v1.Space",
+ name: "spaces/product",
+ title: "Product",
+ description: "Product decisions",
+ currentUserRole: SpaceMember_Role.ADMIN,
+ memberCount: 1,
+};
+
+const alice: User = {
+ $typeName: "memos.api.v1.User",
+ name: "users/alice",
+ username: "alice",
+ displayName: "Alice",
+ email: "",
+ avatarUrl: "",
+ description: "",
+ password: "",
+ role: 3,
+ state: State.NORMAL,
+};
+
+describe("InviteSpaceMemberDialog", () => {
+ beforeEach(() => {
+ vi.useFakeTimers();
+ state.candidate = alice;
+ state.requestedUsernames = [];
+ state.mutateAsync.mockReset().mockResolvedValue(undefined);
+ state.onOpenChange.mockReset();
+ });
+
+ afterEach(() => {
+ vi.useRealTimers();
+ });
+
+ it("invites an exact active Memos user with the chosen role and explains consent", async () => {
+ render(
+ ,
+ );
+
+ expect(screen.getByText("Invite an existing Memos user. They must accept before joining the space.")).toBeInTheDocument();
+
+ fireEvent.change(screen.getByLabelText("Memos user"), { target: { value: " @alice " } });
+ act(() => vi.advanceTimersByTime(300));
+
+ expect(state.requestedUsernames.at(-1)).toEqual(["alice"]);
+ expect(screen.getByText(/@alice ยท Active Memos user/)).toBeInTheDocument();
+
+ fireEvent.click(screen.getByRole("button", { name: /Alice/ }));
+ fireEvent.change(screen.getByLabelText("role-select"), { target: { value: String(SpaceMember_Role.ADMIN) } });
+ fireEvent.click(screen.getByRole("button", { name: "Send invitation" }));
+ await act(async () => Promise.resolve());
+
+ expect(state.mutateAsync).toHaveBeenCalledWith({
+ parent: "spaces/product",
+ spaceInvitation: expect.objectContaining({
+ invitee: "users/alice",
+ role: SpaceMember_Role.ADMIN,
+ }),
+ });
+ expect(state.onOpenChange).toHaveBeenCalledWith(false);
+ });
+});
diff --git a/web/tests/live-memo-refresh.test.tsx b/web/tests/live-memo-refresh.test.tsx
index 0919ab01..0d3087ff 100644
--- a/web/tests/live-memo-refresh.test.tsx
+++ b/web/tests/live-memo-refresh.test.tsx
@@ -29,6 +29,12 @@ vi.mock("@/hooks/useMemoQueries", () => ({
},
}));
+vi.mock("@/hooks/useSpaceQueries", () => ({
+ spaceKeys: {
+ all: ["spaces"],
+ },
+}));
+
vi.mock("@/hooks/useUserQueries", () => ({
userKeys: {
stats: () => ["users", "stats"],
@@ -239,6 +245,23 @@ describe("useLiveMemoRefresh", () => {
expect(firstInvalidate).toHaveBeenCalledWith({ queryKey: ["attachments", "list"], refetchType: "active" });
expect(secondInvalidate).toHaveBeenCalledWith({ queryKey: ["attachments", "list"], refetchType: "active" });
});
+ expect(firstInvalidate).not.toHaveBeenCalledWith({ queryKey: ["spaces"], refetchType: "active" });
+ expect(secondInvalidate).not.toHaveBeenCalledWith({ queryKey: ["spaces"], refetchType: "active" });
+
+ firstInvalidate.mockClear();
+ secondInvalidate.mockClear();
+ act(() => {
+ streamControllers[0].enqueue(new TextEncoder().encode('data: {"type":"space.changed"}\n\n'));
+ });
+
+ await waitFor(() => {
+ for (const invalidate of [firstInvalidate, secondInvalidate]) {
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ["spaces"], refetchType: "active" });
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ["memos"], refetchType: "active" });
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ["users", "stats"], refetchType: "active" });
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ["attachments", "list"], refetchType: "active" });
+ }
+ });
first.unmount();
second.unmount();
@@ -289,13 +312,16 @@ describe("useLiveMemoRefresh", () => {
const fetchMock = vi.fn().mockImplementation(() => new Response(new Uint8Array(), { status: 200 }));
vi.stubGlobal("fetch", fetchMock);
- const hook = renderHook(() => useLiveMemoRefresh(), { wrapper: createWrapper(createQueryClient()) });
+ const queryClient = createQueryClient();
+ const invalidate = vi.spyOn(queryClient, "invalidateQueries");
+ const hook = renderHook(() => useLiveMemoRefresh(), { wrapper: createWrapper(queryClient) });
await flushAsyncWork();
expect(fetchMock).toHaveBeenCalledTimes(1);
await act(async () => vi.advanceTimersByTimeAsync(1000));
await flushAsyncWork();
expect(fetchMock).toHaveBeenCalledTimes(2);
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ["spaces"], refetchType: "active" });
await act(async () => vi.advanceTimersByTimeAsync(1000));
await flushAsyncWork();
diff --git a/web/tests/space-queries.test.tsx b/web/tests/space-queries.test.tsx
index 10ba4447..90427b65 100644
--- a/web/tests/space-queries.test.tsx
+++ b/web/tests/space-queries.test.tsx
@@ -3,18 +3,48 @@ import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import { act, renderHook, waitFor } from "@testing-library/react";
import type { ReactNode } from "react";
import { beforeEach, describe, expect, it, vi } from "vitest";
-import { spaceKeys, useCreateSpace, useSpaces } from "@/hooks/useSpaceQueries";
-import { SpaceSchema } from "@/types/proto/api/v1/space_service_pb";
+import {
+ spaceKeys,
+ useAcceptSpaceInvitation,
+ useCreateSpace,
+ useCreateSpaceInvitation,
+ useDeclineSpaceInvitation,
+ useDeleteSpace,
+ useDeleteSpaceInvitation,
+ useDeleteSpaceMember,
+ useSpaceInvitations,
+ useSpaceMembers,
+ useSpaces,
+ useUpdateSpace,
+ useUpdateSpaceMember,
+ useUserSpaceInvitations,
+} from "@/hooks/useSpaceQueries";
+import { SpaceInvitationSchema, SpaceMember_Role, SpaceMemberSchema, SpaceSchema } from "@/types/proto/api/v1/space_service_pb";
const clients = vi.hoisted(() => ({
+ acceptSpaceInvitation: vi.fn(),
createSpace: vi.fn(),
+ createSpaceInvitation: vi.fn(),
+ declineSpaceInvitation: vi.fn(),
+ deleteSpace: vi.fn(),
+ deleteSpaceInvitation: vi.fn(),
+ deleteSpaceMember: vi.fn(),
+ listSpaceInvitations: vi.fn(),
+ listSpaceMembers: vi.fn(),
listSpaces: vi.fn(),
+ listUserSpaceInvitations: vi.fn(),
+ updateSpace: vi.fn(),
+ updateSpaceMember: vi.fn(),
}));
vi.mock("@/connect", () => ({
spaceServiceClient: clients,
}));
+const VIEWER = "users/test";
+const OTHER_VIEWER = "users/other";
+const SPACE_NAME = "spaces/product";
+
const createQueryClient = () =>
new QueryClient({
defaultOptions: {
@@ -30,8 +60,9 @@ const createWrapper = (queryClient: QueryClient) =>
describe("Space queries", () => {
beforeEach(() => {
- clients.createSpace.mockReset();
- clients.listSpaces.mockReset();
+ for (const client of Object.values(clients)) {
+ client.mockReset();
+ }
});
it("loads every page so the switcher can show all available Spaces", async () => {
@@ -46,26 +77,302 @@ describe("Space queries", () => {
});
const queryClient = createQueryClient();
- const { result } = renderHook(() => useSpaces("users/test"), { wrapper: createWrapper(queryClient) });
+ const { result } = renderHook(() => useSpaces(VIEWER), { wrapper: createWrapper(queryClient) });
await waitFor(() => expect(result.current.data?.map((space) => space.name)).toEqual(["spaces/one", "spaces/two"]));
expect(clients.listSpaces).toHaveBeenNthCalledWith(1, { pageSize: 1000, pageToken: "" });
expect(clients.listSpaces).toHaveBeenNthCalledWith(2, { pageSize: 1000, pageToken: "next" });
});
- it("adds a created Space to the current user's cache", async () => {
- const createdSpace = create(SpaceSchema, { name: "spaces/product", title: "Product", description: "Plans" });
- clients.createSpace.mockResolvedValue(createdSpace);
+ it("drains member and invitation pages with viewer-scoped cache keys", async () => {
+ const admin = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/admin`,
+ user: "users/admin",
+ role: SpaceMember_Role.ADMIN,
+ });
+ const member = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/member`,
+ user: "users/member",
+ role: SpaceMember_Role.USER,
+ });
+ const firstInvitation = create(SpaceInvitationSchema, {
+ name: `${SPACE_NAME}/invitations/first`,
+ invitee: "users/first",
+ role: SpaceMember_Role.USER,
+ });
+ const secondInvitation = create(SpaceInvitationSchema, {
+ name: `${SPACE_NAME}/invitations/second`,
+ invitee: "users/second",
+ role: SpaceMember_Role.ADMIN,
+ });
+
+ clients.listSpaceMembers
+ .mockResolvedValueOnce({ spaceMembers: [admin], nextPageToken: "member-next" })
+ .mockResolvedValueOnce({ spaceMembers: [member], nextPageToken: "" });
+ clients.listSpaceInvitations
+ .mockResolvedValueOnce({ spaceInvitations: [firstInvitation], nextPageToken: "invitation-next" })
+ .mockResolvedValueOnce({ spaceInvitations: [secondInvitation], nextPageToken: "" });
+ clients.listUserSpaceInvitations
+ .mockResolvedValueOnce({ spaceInvitations: [firstInvitation], nextPageToken: "user-next" })
+ .mockResolvedValueOnce({ spaceInvitations: [secondInvitation], nextPageToken: "" });
+
const queryClient = createQueryClient();
- const { result } = renderHook(() => useCreateSpace("users/test"), { wrapper: createWrapper(queryClient) });
+ const { result } = renderHook(
+ () => ({
+ members: useSpaceMembers(VIEWER, SPACE_NAME),
+ spaceInvitations: useSpaceInvitations(VIEWER, SPACE_NAME),
+ userInvitations: useUserSpaceInvitations(VIEWER),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
+
+ await waitFor(() => {
+ expect(result.current.members.data).toHaveLength(2);
+ expect(result.current.spaceInvitations.data).toHaveLength(2);
+ expect(result.current.userInvitations.data).toHaveLength(2);
+ });
+ expect(clients.listSpaceMembers).toHaveBeenNthCalledWith(1, {
+ parent: SPACE_NAME,
+ pageSize: 1000,
+ pageToken: "",
+ });
+ expect(clients.listSpaceMembers).toHaveBeenNthCalledWith(2, {
+ parent: SPACE_NAME,
+ pageSize: 1000,
+ pageToken: "member-next",
+ });
+ expect(clients.listSpaceInvitations).toHaveBeenNthCalledWith(2, {
+ parent: SPACE_NAME,
+ pageSize: 1000,
+ pageToken: "invitation-next",
+ });
+ expect(clients.listUserSpaceInvitations).toHaveBeenNthCalledWith(2, {
+ parent: VIEWER,
+ pageSize: 1000,
+ pageToken: "user-next",
+ });
+ expect(spaceKeys.members(VIEWER, SPACE_NAME)).not.toEqual(spaceKeys.members(OTHER_VIEWER, SPACE_NAME));
+ expect(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME)).not.toEqual(spaceKeys.spaceInvitations(OTHER_VIEWER, SPACE_NAME));
+ expect(spaceKeys.userInvitations(VIEWER)).not.toEqual(spaceKeys.userInvitations(OTHER_VIEWER));
+ });
+
+ it("honors disabled query options without calling the service", async () => {
+ const queryClient = createQueryClient();
+ const { result } = renderHook(
+ () => ({
+ members: useSpaceMembers(VIEWER, SPACE_NAME, { enabled: false }),
+ spaceInvitations: useSpaceInvitations(VIEWER, SPACE_NAME, { enabled: false }),
+ userInvitations: useUserSpaceInvitations(VIEWER, { enabled: false }),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
+
+ await waitFor(() => expect(result.current.members.fetchStatus).toBe("idle"));
+ expect(clients.listSpaceMembers).not.toHaveBeenCalled();
+ expect(clients.listSpaceInvitations).not.toHaveBeenCalled();
+ expect(clients.listUserSpaceInvitations).not.toHaveBeenCalled();
+ });
+
+ it("creates, updates, and deletes Spaces in the current viewer cache", async () => {
+ const originalSpace = create(SpaceSchema, { name: SPACE_NAME, title: "Product", description: "Plans" });
+ const updatedSpace = create(SpaceSchema, { name: SPACE_NAME, title: "Roadmap", description: "Plans" });
+ const createdSpace = create(SpaceSchema, { name: "spaces/research", title: "Research", description: "Notes" });
+ const cachedMember = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/test`,
+ user: VIEWER,
+ role: SpaceMember_Role.ADMIN,
+ });
+ clients.createSpace.mockResolvedValue(createdSpace);
+ clients.updateSpace.mockResolvedValue(updatedSpace);
+ clients.deleteSpace.mockResolvedValue({});
+
+ const queryClient = createQueryClient();
+ queryClient.setQueryData(spaceKeys.list(VIEWER), [originalSpace]);
+ queryClient.setQueryData(spaceKeys.members(VIEWER, SPACE_NAME), [cachedMember]);
+ const { result } = renderHook(
+ () => ({
+ create: useCreateSpace(VIEWER),
+ update: useUpdateSpace(VIEWER),
+ remove: useDeleteSpace(VIEWER),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
await act(async () => {
- await result.current.mutateAsync({ title: "Product", description: "Plans" });
+ await result.current.create.mutateAsync({ title: "Research", description: "Notes" });
});
-
expect(clients.createSpace).toHaveBeenCalledWith({
- space: expect.objectContaining({ title: "Product", description: "Plans" }),
+ space: expect.objectContaining({ title: "Research", description: "Notes" }),
});
- expect(queryClient.getQueryData(spaceKeys.list("users/test"))).toEqual([createdSpace]);
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([originalSpace, createdSpace]);
+
+ await act(async () => {
+ await result.current.update.mutateAsync({
+ space: { name: SPACE_NAME, title: "Roadmap" },
+ updateMask: ["title"],
+ });
+ });
+ expect(clients.updateSpace).toHaveBeenCalledWith({
+ space: expect.objectContaining({ name: SPACE_NAME, title: "Roadmap" }),
+ updateMask: expect.objectContaining({ paths: ["title"] }),
+ });
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([updatedSpace, createdSpace]);
+
+ await act(async () => {
+ await result.current.remove.mutateAsync({ name: SPACE_NAME });
+ });
+ expect(clients.deleteSpace).toHaveBeenCalledWith({ name: SPACE_NAME });
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([createdSpace]);
+ expect(queryClient.getQueryState(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
+ });
+
+ it("synchronizes admin invitation caches after create and delete", async () => {
+ const invitation = create(SpaceInvitationSchema, {
+ name: `${SPACE_NAME}/invitations/member`,
+ invitee: "users/member",
+ role: SpaceMember_Role.USER,
+ });
+ clients.createSpaceInvitation.mockResolvedValue(invitation);
+ clients.deleteSpaceInvitation.mockResolvedValue({});
+
+ const queryClient = createQueryClient();
+ queryClient.setQueryData(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME), []);
+ queryClient.setQueryData(spaceKeys.userInvitations(VIEWER), [invitation]);
+ const { result } = renderHook(
+ () => ({
+ create: useCreateSpaceInvitation(VIEWER),
+ remove: useDeleteSpaceInvitation(VIEWER),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
+
+ await act(async () => {
+ await result.current.create.mutateAsync({
+ parent: SPACE_NAME,
+ spaceInvitation: { invitee: "users/member", role: SpaceMember_Role.USER },
+ });
+ });
+ expect(clients.createSpaceInvitation).toHaveBeenCalledWith({
+ parent: SPACE_NAME,
+ spaceInvitation: expect.objectContaining({ invitee: "users/member", role: SpaceMember_Role.USER }),
+ });
+ expect(queryClient.getQueryData(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME))).toEqual([invitation]);
+
+ await act(async () => {
+ await result.current.remove.mutateAsync({ name: invitation.name });
+ });
+ expect(clients.deleteSpaceInvitation).toHaveBeenCalledWith({ name: invitation.name });
+ expect(queryClient.getQueryData(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME))).toEqual([]);
+ expect(queryClient.getQueryData(spaceKeys.userInvitations(VIEWER))).toEqual([]);
+ });
+
+ it("refreshes Spaces and members while clearing accepted or declined invitations", async () => {
+ const acceptedSpace = create(SpaceSchema, { name: SPACE_NAME, title: "Product" });
+ const acceptedInvitation = create(SpaceInvitationSchema, {
+ name: `${SPACE_NAME}/invitations/test`,
+ invitee: VIEWER,
+ role: SpaceMember_Role.USER,
+ space: acceptedSpace,
+ });
+ const declinedInvitation = create(SpaceInvitationSchema, {
+ name: "spaces/research/invitations/test",
+ invitee: VIEWER,
+ role: SpaceMember_Role.USER,
+ });
+ const acceptedMember = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/test`,
+ user: VIEWER,
+ role: SpaceMember_Role.USER,
+ });
+ clients.acceptSpaceInvitation.mockResolvedValue(acceptedMember);
+ clients.declineSpaceInvitation.mockResolvedValue({});
+
+ const queryClient = createQueryClient();
+ queryClient.setQueryData(spaceKeys.list(VIEWER), []);
+ queryClient.setQueryData(spaceKeys.members(VIEWER, SPACE_NAME), []);
+ queryClient.setQueryData(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME), [acceptedInvitation]);
+ queryClient.setQueryData(spaceKeys.userInvitations(VIEWER), [acceptedInvitation, declinedInvitation]);
+ const { result } = renderHook(
+ () => ({
+ accept: useAcceptSpaceInvitation(VIEWER),
+ decline: useDeclineSpaceInvitation(VIEWER),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
+
+ await act(async () => {
+ await result.current.accept.mutateAsync({ name: acceptedInvitation.name });
+ });
+ expect(clients.acceptSpaceInvitation).toHaveBeenCalledWith({ name: acceptedInvitation.name });
+ // Invitation Space summaries omit membership-only fields and must not be
+ // promoted into the authoritative list while its refetch is in flight.
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([]);
+ expect(queryClient.getQueryData(spaceKeys.members(VIEWER, SPACE_NAME))).toEqual([acceptedMember]);
+ expect(queryClient.getQueryData(spaceKeys.spaceInvitations(VIEWER, SPACE_NAME))).toEqual([]);
+ expect(queryClient.getQueryData(spaceKeys.userInvitations(VIEWER))).toEqual([declinedInvitation]);
+ expect(queryClient.getQueryState(spaceKeys.list(VIEWER))?.isInvalidated).toBe(true);
+
+ await act(async () => {
+ await result.current.decline.mutateAsync({ name: declinedInvitation.name });
+ });
+ expect(clients.declineSpaceInvitation).toHaveBeenCalledWith({ name: declinedInvitation.name });
+ expect(queryClient.getQueryData(spaceKeys.userInvitations(VIEWER))).toEqual([]);
+ });
+
+ it("updates members and evicts a Space when the current viewer leaves", async () => {
+ const space = create(SpaceSchema, { name: SPACE_NAME, title: "Product" });
+ const originalMember = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/member`,
+ user: "users/member",
+ role: SpaceMember_Role.USER,
+ });
+ const updatedMember = create(SpaceMemberSchema, {
+ ...originalMember,
+ role: SpaceMember_Role.ADMIN,
+ });
+ const viewerMember = create(SpaceMemberSchema, {
+ name: `${SPACE_NAME}/members/test`,
+ user: VIEWER,
+ role: SpaceMember_Role.ADMIN,
+ });
+ clients.updateSpaceMember.mockResolvedValue(updatedMember);
+ clients.deleteSpaceMember.mockResolvedValue({});
+
+ const queryClient = createQueryClient();
+ queryClient.setQueryData(spaceKeys.list(VIEWER), [space]);
+ queryClient.setQueryData(spaceKeys.members(VIEWER, SPACE_NAME), [originalMember, viewerMember]);
+ const { result } = renderHook(
+ () => ({
+ update: useUpdateSpaceMember(VIEWER),
+ remove: useDeleteSpaceMember(VIEWER),
+ }),
+ { wrapper: createWrapper(queryClient) },
+ );
+
+ await act(async () => {
+ await result.current.update.mutateAsync({
+ spaceMember: { name: originalMember.name, role: SpaceMember_Role.ADMIN },
+ updateMask: ["role"],
+ });
+ });
+ expect(clients.updateSpaceMember).toHaveBeenCalledWith({
+ spaceMember: expect.objectContaining({ name: originalMember.name, role: SpaceMember_Role.ADMIN }),
+ updateMask: expect.objectContaining({ paths: ["role"] }),
+ });
+ expect(queryClient.getQueryData(spaceKeys.members(VIEWER, SPACE_NAME))).toEqual([updatedMember, viewerMember]);
+
+ await act(async () => {
+ await result.current.remove.mutateAsync({ name: originalMember.name });
+ });
+ expect(queryClient.getQueryData(spaceKeys.members(VIEWER, SPACE_NAME))).toEqual([viewerMember]);
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([space]);
+ expect(queryClient.getQueryState(spaceKeys.list(VIEWER))?.isInvalidated).toBe(true);
+
+ await act(async () => {
+ await result.current.remove.mutateAsync({ name: viewerMember.name });
+ });
+ expect(clients.deleteSpaceMember).toHaveBeenLastCalledWith({ name: viewerMember.name });
+ expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([]);
+ expect(queryClient.getQueryState(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
});
});
diff --git a/web/tests/space-settings-shell.test.ts b/web/tests/space-settings-shell.test.ts
new file mode 100644
index 00000000..6e4cdad6
--- /dev/null
+++ b/web/tests/space-settings-shell.test.ts
@@ -0,0 +1,21 @@
+import { describe, expect, it } from "vitest";
+import { isSettingSectionKey, SETTINGS_SECTIONS } from "@/components/Settings/settingSections";
+import enTranslation from "@/locales/en.json";
+
+describe("Spaces settings shell", () => {
+ it("registers Spaces as a basic settings section", () => {
+ expect(isSettingSectionKey("spaces")).toBe(true);
+ expect(SETTINGS_SECTIONS.find((section) => section.key === "spaces")).toMatchObject({
+ scope: "basic",
+ labelKey: "setting.spaces.label",
+ });
+ });
+
+ it("defines the English settings copy used as the locale fallback", () => {
+ expect(enTranslation.setting.spaces).toMatchObject({
+ description: "View spaces you belong to and manage members and invitations.",
+ label: "Spaces",
+ title: "Spaces",
+ });
+ });
+});
diff --git a/web/tests/space-switcher.test.tsx b/web/tests/space-switcher.test.tsx
index 9242031a..b820effe 100644
--- a/web/tests/space-switcher.test.tsx
+++ b/web/tests/space-switcher.test.tsx
@@ -18,7 +18,15 @@ vi.mock("@/components/MemosLogo", () => ({
}));
vi.mock("@/components/CreateSpaceDialog", () => ({
- default: ({ open }: { open: boolean }) => (open ? Create Space dialog
: null),
+ default: ({ open, onCreated }: { open: boolean; onCreated?: (space: (typeof spaceState.spaces)[number]) => void }) =>
+ open ? (
+
+ Create Space dialog
+
+
+ ) : null,
}));
vi.mock("@/contexts/SpaceContext", () => ({
@@ -86,5 +94,7 @@ describe("SpaceSwitcher", () => {
fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));
fireEvent.click(await screen.findByRole("menuitem", { name: "space.create" }));
expect(screen.getByRole("dialog", { name: "" })).toHaveTextContent("Create Space dialog");
+ fireEvent.click(screen.getByRole("button", { name: "Complete create" }));
+ expect(spaceState.selectSpace).toHaveBeenCalledWith(spaceState.spaces[0]);
});
});
diff --git a/web/tests/spaces-section.test.tsx b/web/tests/spaces-section.test.tsx
new file mode 100644
index 00000000..b099d157
--- /dev/null
+++ b/web/tests/spaces-section.test.tsx
@@ -0,0 +1,260 @@
+import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
+import { MemoryRouter, useLocation } from "react-router-dom";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import SpacesSection from "@/components/Settings/SpacesSection";
+import type { Space, SpaceInvitation, SpaceMember } from "@/types/proto/api/v1/space_service_pb";
+
+const state = vi.hoisted(() => ({
+ viewerName: "users/alice",
+ viewerInstanceRole: 3,
+ spaces: [] as Space[],
+ receivedInvitations: [] as SpaceInvitation[],
+ members: [] as SpaceMember[],
+ managedInvitations: [] as SpaceInvitation[],
+ usersByName: new Map(),
+ acceptInvitation: vi.fn(),
+ declineInvitation: vi.fn(),
+ updateSpace: vi.fn(),
+ deleteSpace: vi.fn(),
+ updateMember: vi.fn(),
+ deleteMember: vi.fn(),
+ deleteInvitation: vi.fn(),
+ selectAmbientSpace: vi.fn(),
+}));
+
+vi.mock("react-hot-toast", () => ({
+ default: { error: vi.fn(), success: vi.fn() },
+}));
+
+vi.mock("@/hooks/useCurrentUser", () => ({
+ default: () => ({ name: state.viewerName, role: state.viewerInstanceRole }),
+}));
+
+vi.mock("@/hooks/useSpaceQueries", () => ({
+ useSpaces: () => ({ data: state.spaces, isError: false, isLoading: false, isSuccess: true }),
+ useUserSpaceInvitations: () => ({ data: state.receivedInvitations, isLoading: false }),
+ useAcceptSpaceInvitation: () => ({ isPending: false, mutateAsync: state.acceptInvitation }),
+ useDeclineSpaceInvitation: () => ({ isPending: false, mutateAsync: state.declineInvitation }),
+ useSpaceMembers: () => ({ data: state.members, isError: false, isLoading: false }),
+ useSpaceInvitations: () => ({ data: state.managedInvitations, isLoading: false }),
+ useUpdateSpace: () => ({ isPending: false, mutateAsync: state.updateSpace }),
+ useDeleteSpace: () => ({ isPending: false, mutateAsync: state.deleteSpace }),
+ useUpdateSpaceMember: () => ({ isPending: false, mutateAsync: state.updateMember }),
+ useDeleteSpaceMember: () => ({ isPending: false, mutateAsync: state.deleteMember }),
+ useDeleteSpaceInvitation: () => ({ isPending: false, mutateAsync: state.deleteInvitation }),
+}));
+
+vi.mock("@/hooks/useUserQueries", () => ({
+ useUsersByUsernames: () => ({ data: state.usersByName }),
+}));
+
+vi.mock("@/contexts/SpaceContext", () => ({
+ useSpaceContext: () => ({ selectSpace: state.selectAmbientSpace }),
+}));
+
+vi.mock("@/components/SpaceMark", () => ({
+ default: ({ space }: { space?: { title?: string } }) => {space?.title?.slice(0, 1) ?? "S"},
+}));
+
+vi.mock("@/components/UserAvatar", () => ({
+ default: () => ,
+}));
+
+vi.mock("@/components/CreateSpaceDialog", () => ({
+ default: ({ open, onCreated }: { open: boolean; onCreated?: (space: Space) => void }) =>
+ open ? (
+
+
+
+ ) : null,
+}));
+
+vi.mock("@/components/Settings/InviteSpaceMemberDialog", () => ({
+ default: ({ open }: { open: boolean }) => (open ? invite-member-dialog
: null),
+}));
+
+vi.mock("@/components/ConfirmDialog", () => ({
+ default: ({ open, confirmLabel, onConfirm }: { open: boolean; confirmLabel: string; onConfirm: () => void | Promise }) =>
+ open ? (
+
+
+
+ ) : null,
+}));
+
+vi.mock("@/utils/i18n", () => ({
+ useTranslate: () => (key: string) => key,
+}));
+
+const adminSpace: Space = {
+ $typeName: "memos.api.v1.Space",
+ name: "spaces/product",
+ title: "Product",
+ description: "Product decisions",
+ currentUserRole: 1,
+ memberCount: 2,
+};
+
+const userSpace: Space = {
+ ...adminSpace,
+ currentUserRole: 2,
+};
+
+const adminMember: SpaceMember = {
+ $typeName: "memos.api.v1.SpaceMember",
+ name: "spaces/product/members/alice",
+ user: "users/alice",
+ role: 1,
+};
+
+const ordinaryMember: SpaceMember = {
+ $typeName: "memos.api.v1.SpaceMember",
+ name: "spaces/product/members/bob",
+ user: "users/bob",
+ role: 2,
+};
+
+const receivedInvitation: SpaceInvitation = {
+ $typeName: "memos.api.v1.SpaceInvitation",
+ name: "spaces/research/invitations/alice",
+ invitee: "users/alice",
+ role: 2,
+ space: {
+ $typeName: "memos.api.v1.Space",
+ name: "spaces/research",
+ title: "Research",
+ description: "Research notes",
+ currentUserRole: 0,
+ memberCount: 0,
+ },
+};
+
+const pendingInvitation: SpaceInvitation = {
+ $typeName: "memos.api.v1.SpaceInvitation",
+ name: "spaces/product/invitations/carol",
+ invitee: "users/carol",
+ role: 2,
+ space: adminSpace,
+};
+
+const LocationProbe = () => {
+ const location = useLocation();
+ return ;
+};
+
+const renderSection = (entry = "/setting#spaces") =>
+ render(
+
+
+
+ ,
+ );
+
+describe("SpacesSection", () => {
+ beforeEach(() => {
+ state.spaces = [];
+ state.viewerInstanceRole = 3;
+ state.receivedInvitations = [];
+ state.members = [];
+ state.managedInvitations = [];
+ state.usersByName = new Map();
+ state.acceptInvitation.mockReset().mockResolvedValue(undefined);
+ state.declineInvitation.mockReset().mockResolvedValue(undefined);
+ state.updateSpace.mockReset().mockResolvedValue(undefined);
+ state.deleteSpace.mockReset().mockResolvedValue(undefined);
+ state.updateMember.mockReset().mockResolvedValue(undefined);
+ state.deleteMember.mockReset().mockResolvedValue(undefined);
+ state.deleteInvitation.mockReset().mockResolvedValue(undefined);
+ state.selectAmbientSpace.mockReset();
+ });
+
+ it("separates pending invitations from joined spaces and uses exact invitation resource names", async () => {
+ state.spaces = [adminSpace];
+ state.receivedInvitations = [receivedInvitation];
+
+ renderSection();
+
+ const invitationsSection = screen.getByRole("heading", { name: "setting.spaces.invitations" }).closest("section");
+ const joinedSection = screen.getByRole("heading", { name: "setting.spaces.your-spaces" }).closest("section");
+ expect(invitationsSection).not.toBeNull();
+ expect(joinedSection).not.toBeNull();
+ expect(within(invitationsSection!).getByText("Research")).toBeInTheDocument();
+ expect(within(invitationsSection!).queryByText("Product")).not.toBeInTheDocument();
+ expect(within(joinedSection!).getByText("Product")).toBeInTheDocument();
+ expect(within(joinedSection!).queryByText("Research")).not.toBeInTheDocument();
+
+ fireEvent.click(within(invitationsSection!).getByRole("button", { name: "setting.spaces.accept" }));
+ await waitFor(() => expect(state.acceptInvitation).toHaveBeenCalledWith({ name: "spaces/research/invitations/alice" }));
+
+ fireEvent.click(within(invitationsSection!).getByRole("button", { name: "setting.spaces.decline" }));
+ await waitFor(() => expect(state.declineInvitation).toHaveBeenCalledWith({ name: "spaces/research/invitations/alice" }));
+ });
+
+ it("shows governance controls to Space admins and cancels the exact pending invitation", async () => {
+ state.spaces = [adminSpace];
+ state.members = [adminMember, ordinaryMember];
+ state.managedInvitations = [pendingInvitation];
+
+ renderSection("/setting?space=spaces%2Fproduct#spaces");
+
+ expect(screen.getByLabelText("common.name")).not.toHaveAttribute("readonly");
+ expect(screen.getByRole("button", { name: "setting.spaces.save-changes" })).toBeInTheDocument();
+ expect(screen.getByRole("button", { name: "setting.spaces.delete-space" })).toBeInTheDocument();
+
+ fireEvent.click(screen.getByRole("tab", { name: /setting\.spaces\.members/ }));
+ expect(screen.getByRole("button", { name: "setting.spaces.invite-member" })).toBeInTheDocument();
+ expect(screen.getByRole("button", { name: "setting.spaces.remove" })).toBeInTheDocument();
+ expect(screen.getByRole("heading", { name: "setting.spaces.pending-invitations" })).toBeInTheDocument();
+ fireEvent.click(screen.getByRole("button", { name: "setting.spaces.cancel-invitation" }));
+ fireEvent.click(within(screen.getByRole("dialog")).getByRole("button", { name: "setting.spaces.cancel-invitation" }));
+ await waitFor(() => expect(state.deleteInvitation).toHaveBeenCalledWith({ name: "spaces/product/invitations/carol" }));
+ });
+
+ it("keeps ordinary Space members read-only and hides governance controls", () => {
+ // Instance administrators do not implicitly receive Space governance rights.
+ state.viewerInstanceRole = 2;
+ state.spaces = [userSpace];
+ state.members = [{ ...ordinaryMember, name: "spaces/product/members/alice", user: "users/alice" }, adminMember];
+ state.managedInvitations = [pendingInvitation];
+
+ renderSection("/setting?space=spaces%2Fproduct#spaces");
+
+ expect(screen.getByLabelText("common.name")).toHaveAttribute("readonly");
+ expect(screen.queryByRole("button", { name: "setting.spaces.save-changes" })).not.toBeInTheDocument();
+ expect(screen.queryByRole("button", { name: "setting.spaces.delete-space" })).not.toBeInTheDocument();
+ expect(screen.getByRole("button", { name: "setting.spaces.leave-space" })).toBeInTheDocument();
+
+ fireEvent.click(screen.getByRole("tab", { name: /setting\.spaces\.members/ }));
+ expect(screen.queryByRole("button", { name: "setting.spaces.invite-member" })).not.toBeInTheDocument();
+ expect(screen.queryByRole("button", { name: "setting.spaces.remove" })).not.toBeInTheDocument();
+ expect(screen.queryByRole("heading", { name: "setting.spaces.pending-invitations" })).not.toBeInTheDocument();
+ });
+
+ it("navigates to a newly created Space for management without switching ambient Space", async () => {
+ renderSection();
+
+ fireEvent.click(screen.getAllByRole("button", { name: "setting.spaces.create-space" })[0]);
+ fireEvent.click(screen.getByRole("button", { name: "complete-create" }));
+
+ await waitFor(() => expect(screen.getByTestId("location")).toHaveTextContent("/setting?space=spaces%2Fcreated#spaces"));
+ expect(state.selectAmbientSpace).not.toHaveBeenCalled();
+ });
+});