From 854d893fc6021505ade0d3ea5fe7ccad06a2ae56 Mon Sep 17 00:00:00 2001 From: ABird Date: Wed, 26 Aug 2026 22:20:40 +0800 Subject: [PATCH] feat(spaces): add settings management (#6234) --- docs/design/multi-spaces.md | 14 +- proto/api/v1/space_service.proto | 8 + proto/gen/api/v1/space_service.pb.go | 129 ++-- proto/gen/openapi.yaml | 18 + server/router/api/v1/space_service.go | 18 +- .../router/api/v1/space_service_converters.go | 12 +- server/router/api/v1/space_service_test.go | 24 +- server/router/api/v1/sse_hub.go | 12 +- server/router/api/v1/sse_hub_test.go | 16 + server/router/api/v1/sse_service_test.go | 21 +- store/db/mysql/space.go | 40 +- store/db/postgres/space.go | 37 +- store/db/sqlite/space.go | 37 +- store/space.go | 11 +- store/test/space_test.go | 20 + web/src/components/AppSidebar/AppSidebar.tsx | 4 +- .../components/AppSidebar/SpaceSwitcher.tsx | 27 +- web/src/components/CreateSpaceDialog.tsx | 20 +- .../Settings/InviteSpaceMemberDialog.tsx | 193 +++++ web/src/components/Settings/SpacesSection.tsx | 731 ++++++++++++++++++ .../components/Settings/settingSections.ts | 10 + web/src/components/SpaceMark.tsx | 35 + web/src/hooks/useLiveMemoRefresh.ts | 27 +- web/src/hooks/useSpaceQueries.ts | 343 +++++++- web/src/locales/en.json | 81 ++ .../types/proto/api/v1/space_service_pb.ts | 18 +- web/tests/create-space-dialog.test.tsx | 31 +- web/tests/invite-space-member-dialog.test.tsx | 144 ++++ web/tests/live-memo-refresh.test.tsx | 28 +- web/tests/space-queries.test.tsx | 333 +++++++- web/tests/space-settings-shell.test.ts | 21 + web/tests/space-switcher.test.tsx | 12 +- web/tests/spaces-section.test.tsx | 260 +++++++ 33 files changed, 2560 insertions(+), 175 deletions(-) create mode 100644 web/src/components/Settings/InviteSpaceMemberDialog.tsx create mode 100644 web/src/components/Settings/SpacesSection.tsx create mode 100644 web/src/components/SpaceMark.tsx create mode 100644 web/tests/invite-space-member-dialog.test.tsx create mode 100644 web/tests/space-settings-shell.test.ts create mode 100644 web/tests/spaces-section.test.tsx diff --git a/docs/design/multi-spaces.md b/docs/design/multi-spaces.md index b5806db2..bf6bffb1 100644 --- a/docs/design/multi-spaces.md +++ b/docs/design/multi-spaces.md @@ -35,7 +35,7 @@ Every memo remains an author-owned, independent resource. Placement, audience, a - Space archival or restoration. - Guests, email or external-user invitations, open enrollment, federation, or public Space discovery. - A generated default Space. -- UI/UX design or a redesign of global surfaces. +- Re-scoping user-global surfaces such as Inbox and user profiles around a Space. ## Research @@ -52,7 +52,7 @@ The research supports four choices: - Make Space one first-class resource with explicit membership and roles, gated by invitee acceptance. - Keep placement, audience, authorship, and distribution independent. - Represent Unassigned as a real absence of placement. -- Eventually make Spaces visible in normal browsing and creation flows, while deferring UI/UX here. +- Make Spaces visible in normal browsing, creation, and management flows while keeping user-global surfaces independent of the current Space. Sources: [Discourse category permissions](https://meta.discourse.org/t/understanding-groups-and-category-permissions/87678), [Discourse post ownership](https://meta.discourse.org/t/changing-ownership-of-posts/276672), [Notion Teamspaces](https://www.notion.com/help/intro-to-teamspaces), [Notion sharing and permissions](https://www.notion.com/help/sharing-and-permissions), [Mastodon post visibility](https://docs.joinmastodon.org/user/posting/), and [Mastodon Lists](https://docs.joinmastodon.org/entities/List/). @@ -158,6 +158,8 @@ A dedicated Space service provides create, list, get, update, and hard-delete op Listing Spaces returns only Spaces in which the caller has active membership; no application-wide Space listing or archive API is added. An authenticated non-member, including a pending invitee, receives `NotFound` for Space metadata, members, and feed requests. +Space responses returned through membership-authorized operations include the authenticated user's membership role and the accepted-member count as output-only projections. Metadata-only Space summaries, such as the summary carried by an invitation, use the default role and count values. + Memo responses gain an optional Space resource name, and `Visibility` adds `SPACE = 4` without renumbering existing values. The domain-to-v1 mapping is Author to `PRIVATE`, Instance to `PROTECTED`, Public to `PUBLIC`, and Space to `SPACE`. `VISIBILITY_UNSPECIFIED` remains an input sentinel: create treats it as `PRIVATE`, an explicit visibility update rejects it, and responses never return it. Visibility values are named domains and must not be compared numerically. The global default memo visibility setting continues to accept only `PRIVATE`, `PROTECTED`, and `PUBLIC`, because it cannot identify a Space. Memo listing gains explicit all-readable, Unassigned, and Space scopes. Space scope requires active membership. Existing global and Space feeds exclude comments by default, and Space identity is not added to the CEL filter schema. @@ -166,6 +168,10 @@ Placement and audience use the existing memo update mechanism so the memo author MCP memo operations reuse the same memo policy; Space management is not exposed through MCP in the initial version. +### UI shape + +The active Space scopes collaborative resource browsing and creation, including Home and attachment lists. Inbox and user profiles remain user-global and their routes do not inherit the active Space. Global Settings provides a Spaces section for viewing received invitations and managing joined Spaces, metadata, members, roles, and pending invitations; it is a management surface rather than another Space switcher. + ### Security invariants Before `SPACE` can be stored, one shared, memo-local, fail-closed policy must cover point reads, lists and counts, files, reactions, relations, notifications, email, webhooks, shares, search, statistics, public feeds, and MCP. Child resources resolve the memo they directly belong to. Application `ADMIN` receives no implicit bypass. @@ -181,7 +187,7 @@ OR SPACE + active membership in memo.space_id CEL filters may only narrow this predicate. Space membership is checked per request or through immediately invalidated cache state. Write paths validate membership and placement as part of their ordinary operation. Missing or unreadable notification subjects and relation endpoints fail closed without leaking partial metadata. Broader serialization between concurrent membership, placement, and memo mutations remains deferred. -Live refresh is an authenticated, subject-free cache-invalidation channel. Successful memo, reaction, Space, invitation, and membership mutations broadcast only `{"type":"memo.changed"}` to connected clients. The event carries no resource name, audience, actor, invitation, or membership data; clients invalidate memo-backed caches and refetch through ordinary authorization. SSE does not materialize recipient sets or perform memo-level authorization. +Live refresh is an authenticated, subject-free cache-invalidation channel. Successful memo and reaction mutations broadcast `{"type":"memo.changed"}`; successful Space, invitation, and membership mutations broadcast `{"type":"space.changed"}`. Neither event carries a resource name, audience, actor, invitation, or membership data. Clients invalidate the corresponding Space- and memo-backed caches and refetch through ordinary authorization. SSE does not materialize recipient sets or perform memo-level authorization. Notifications are authorized when presented. Email and user webhook payloads are authorized before entering the existing asynchronous queue; the initial version does not cancel a prepared delivery when access changes while it is queued. A comment webhook requires both the comment and its context memo to be readable by the webhook owner when the event is prepared. A deleted-memo webhook is built only from an author-readable pre-delete snapshot. @@ -207,6 +213,4 @@ Files for `PRIVATE`, `PROTECTED`, and `SPACE` memos use `private, no-store`; pub ## Deferred design -UI/UX is explicitly out of scope, including navigation, editor controls, membership screens, warnings, and confirmation flows. - Email and external-user invitations, invitation expiration, inviter attribution, invitation history, open enrollment, account erasure beyond the membership guard, notification delivery and retention policy, application-admin moderation and recovery, audit history, soft deletion, restoration, retryable external-object cleanup, delivery-time cancellation of queued email/webhooks, broader concurrent-mutation hardening, and asynchronous deletion of very large Spaces remain deferred. Later work must preserve invitee consent, independent memo authorization, non-propagating relations, and explicit Space aggregate deletion unless this design is revisited. diff --git a/proto/api/v1/space_service.proto b/proto/api/v1/space_service.proto index 54fac983..22b4f339 100644 --- a/proto/api/v1/space_service.proto +++ b/proto/api/v1/space_service.proto @@ -149,6 +149,14 @@ message Space { // Optional. A description of the space. string description = 3 [(google.api.field_behavior) = OPTIONAL]; + + // Output only. The authenticated user's membership role in this space. + // ROLE_UNSPECIFIED when this Space is exposed as metadata-only. + SpaceMember.Role current_user_role = 4 [(google.api.field_behavior) = OUTPUT_ONLY]; + + // Output only. The number of accepted members in this space. Pending + // invitations are excluded. Zero when this Space is exposed as metadata-only. + int32 member_count = 5 [(google.api.field_behavior) = OUTPUT_ONLY]; } // SpaceMember is a user's membership and governance role in a space. diff --git a/proto/gen/api/v1/space_service.pb.go b/proto/gen/api/v1/space_service.pb.go index 62337726..aa5ddbbc 100644 --- a/proto/gen/api/v1/space_service.pb.go +++ b/proto/gen/api/v1/space_service.pb.go @@ -81,7 +81,13 @@ type Space struct { // Required. The human-readable title. Title string `protobuf:"bytes,2,opt,name=title,proto3" json:"title,omitempty"` // Optional. A description of the space. - Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"` + Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"` + // Output only. The authenticated user's membership role in this space. + // ROLE_UNSPECIFIED when this Space is exposed as metadata-only. + CurrentUserRole SpaceMember_Role `protobuf:"varint,4,opt,name=current_user_role,json=currentUserRole,proto3,enum=memos.api.v1.SpaceMember_Role" json:"current_user_role,omitempty"` + // Output only. The number of accepted members in this space. Pending + // invitations are excluded. Zero when this Space is exposed as metadata-only. + MemberCount int32 `protobuf:"varint,5,opt,name=member_count,json=memberCount,proto3" json:"member_count,omitempty"` unknownFields protoimpl.UnknownFields sizeCache protoimpl.SizeCache } @@ -137,6 +143,20 @@ func (x *Space) GetDescription() string { return "" } +func (x *Space) GetCurrentUserRole() SpaceMember_Role { + if x != nil { + return x.CurrentUserRole + } + return SpaceMember_ROLE_UNSPECIFIED +} + +func (x *Space) GetMemberCount() int32 { + if x != nil { + return x.MemberCount + } + return 0 +} + // SpaceMember is a user's membership and governance role in a space. type SpaceMember struct { state protoimpl.MessageState `protogen:"open.v1"` @@ -1306,11 +1326,13 @@ var File_api_v1_space_service_proto protoreflect.FileDescriptor const file_api_v1_space_service_proto_rawDesc = "" + "\n" + - "\x1aapi/v1/space_service.proto\x12\fmemos.api.v1\x1a\x1cgoogle/api/annotations.proto\x1a\x17google/api/client.proto\x1a\x1fgoogle/api/field_behavior.proto\x1a\x19google/api/resource.proto\x1a\x1bgoogle/protobuf/empty.proto\x1a google/protobuf/field_mask.proto\"\xa0\x01\n" + + "\x1aapi/v1/space_service.proto\x12\fmemos.api.v1\x1a\x1cgoogle/api/annotations.proto\x1a\x17google/api/client.proto\x1a\x1fgoogle/api/field_behavior.proto\x1a\x19google/api/resource.proto\x1a\x1bgoogle/protobuf/empty.proto\x1a google/protobuf/field_mask.proto\"\x99\x02\n" + "\x05Space\x12\x17\n" + "\x04name\x18\x01 \x01(\tB\x03\xe0A\bR\x04name\x12\x19\n" + "\x05title\x18\x02 \x01(\tB\x03\xe0A\x02R\x05title\x12%\n" + - "\vdescription\x18\x03 \x01(\tB\x03\xe0A\x01R\vdescription:<\xeaA9\n" + + "\vdescription\x18\x03 \x01(\tB\x03\xe0A\x01R\vdescription\x12O\n" + + "\x11current_user_role\x18\x04 \x01(\x0e2\x1e.memos.api.v1.SpaceMember.RoleB\x03\xe0A\x03R\x0fcurrentUserRole\x12&\n" + + "\fmember_count\x18\x05 \x01(\x05B\x03\xe0A\x03R\vmemberCount:<\xeaA9\n" + "\x12memos.api.v1/Space\x12\x0espaces/{space}\x1a\x04name*\x06spaces2\x05space\"\xa2\x02\n" + "\vSpaceMember\x12\x17\n" + "\x04name\x18\x01 \x01(\tB\x03\xe0A\bR\x04name\x12-\n" + @@ -1462,56 +1484,57 @@ var file_api_v1_space_service_proto_goTypes = []any{ (*emptypb.Empty)(nil), // 25: google.protobuf.Empty } var file_api_v1_space_service_proto_depIdxs = []int32{ - 0, // 0: memos.api.v1.SpaceMember.role:type_name -> memos.api.v1.SpaceMember.Role - 0, // 1: memos.api.v1.SpaceInvitation.role:type_name -> memos.api.v1.SpaceMember.Role - 1, // 2: memos.api.v1.SpaceInvitation.space:type_name -> memos.api.v1.Space - 1, // 3: memos.api.v1.CreateSpaceRequest.space:type_name -> memos.api.v1.Space - 1, // 4: memos.api.v1.ListSpacesResponse.spaces:type_name -> memos.api.v1.Space - 1, // 5: memos.api.v1.UpdateSpaceRequest.space:type_name -> memos.api.v1.Space - 24, // 6: memos.api.v1.UpdateSpaceRequest.update_mask:type_name -> google.protobuf.FieldMask - 3, // 7: memos.api.v1.CreateSpaceInvitationRequest.space_invitation:type_name -> memos.api.v1.SpaceInvitation - 3, // 8: memos.api.v1.ListSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation - 3, // 9: memos.api.v1.ListUserSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation - 2, // 10: memos.api.v1.ListSpaceMembersResponse.space_members:type_name -> memos.api.v1.SpaceMember - 2, // 11: memos.api.v1.UpdateSpaceMemberRequest.space_member:type_name -> memos.api.v1.SpaceMember - 24, // 12: memos.api.v1.UpdateSpaceMemberRequest.update_mask:type_name -> google.protobuf.FieldMask - 4, // 13: memos.api.v1.SpaceService.CreateSpace:input_type -> memos.api.v1.CreateSpaceRequest - 5, // 14: memos.api.v1.SpaceService.ListSpaces:input_type -> memos.api.v1.ListSpacesRequest - 7, // 15: memos.api.v1.SpaceService.GetSpace:input_type -> memos.api.v1.GetSpaceRequest - 8, // 16: memos.api.v1.SpaceService.UpdateSpace:input_type -> memos.api.v1.UpdateSpaceRequest - 9, // 17: memos.api.v1.SpaceService.DeleteSpace:input_type -> memos.api.v1.DeleteSpaceRequest - 10, // 18: memos.api.v1.SpaceService.CreateSpaceInvitation:input_type -> memos.api.v1.CreateSpaceInvitationRequest - 11, // 19: memos.api.v1.SpaceService.ListSpaceInvitations:input_type -> memos.api.v1.ListSpaceInvitationsRequest - 13, // 20: memos.api.v1.SpaceService.ListUserSpaceInvitations:input_type -> memos.api.v1.ListUserSpaceInvitationsRequest - 15, // 21: memos.api.v1.SpaceService.GetSpaceInvitation:input_type -> memos.api.v1.GetSpaceInvitationRequest - 16, // 22: memos.api.v1.SpaceService.DeleteSpaceInvitation:input_type -> memos.api.v1.DeleteSpaceInvitationRequest - 17, // 23: memos.api.v1.SpaceService.AcceptSpaceInvitation:input_type -> memos.api.v1.AcceptSpaceInvitationRequest - 18, // 24: memos.api.v1.SpaceService.DeclineSpaceInvitation:input_type -> memos.api.v1.DeclineSpaceInvitationRequest - 19, // 25: memos.api.v1.SpaceService.ListSpaceMembers:input_type -> memos.api.v1.ListSpaceMembersRequest - 21, // 26: memos.api.v1.SpaceService.GetSpaceMember:input_type -> memos.api.v1.GetSpaceMemberRequest - 22, // 27: memos.api.v1.SpaceService.UpdateSpaceMember:input_type -> memos.api.v1.UpdateSpaceMemberRequest - 23, // 28: memos.api.v1.SpaceService.DeleteSpaceMember:input_type -> memos.api.v1.DeleteSpaceMemberRequest - 1, // 29: memos.api.v1.SpaceService.CreateSpace:output_type -> memos.api.v1.Space - 6, // 30: memos.api.v1.SpaceService.ListSpaces:output_type -> memos.api.v1.ListSpacesResponse - 1, // 31: memos.api.v1.SpaceService.GetSpace:output_type -> memos.api.v1.Space - 1, // 32: memos.api.v1.SpaceService.UpdateSpace:output_type -> memos.api.v1.Space - 25, // 33: memos.api.v1.SpaceService.DeleteSpace:output_type -> google.protobuf.Empty - 3, // 34: memos.api.v1.SpaceService.CreateSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation - 12, // 35: memos.api.v1.SpaceService.ListSpaceInvitations:output_type -> memos.api.v1.ListSpaceInvitationsResponse - 14, // 36: memos.api.v1.SpaceService.ListUserSpaceInvitations:output_type -> memos.api.v1.ListUserSpaceInvitationsResponse - 3, // 37: memos.api.v1.SpaceService.GetSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation - 25, // 38: memos.api.v1.SpaceService.DeleteSpaceInvitation:output_type -> google.protobuf.Empty - 2, // 39: memos.api.v1.SpaceService.AcceptSpaceInvitation:output_type -> memos.api.v1.SpaceMember - 25, // 40: memos.api.v1.SpaceService.DeclineSpaceInvitation:output_type -> google.protobuf.Empty - 20, // 41: memos.api.v1.SpaceService.ListSpaceMembers:output_type -> memos.api.v1.ListSpaceMembersResponse - 2, // 42: memos.api.v1.SpaceService.GetSpaceMember:output_type -> memos.api.v1.SpaceMember - 2, // 43: memos.api.v1.SpaceService.UpdateSpaceMember:output_type -> memos.api.v1.SpaceMember - 25, // 44: memos.api.v1.SpaceService.DeleteSpaceMember:output_type -> google.protobuf.Empty - 29, // [29:45] is the sub-list for method output_type - 13, // [13:29] is the sub-list for method input_type - 13, // [13:13] is the sub-list for extension type_name - 13, // [13:13] is the sub-list for extension extendee - 0, // [0:13] is the sub-list for field type_name + 0, // 0: memos.api.v1.Space.current_user_role:type_name -> memos.api.v1.SpaceMember.Role + 0, // 1: memos.api.v1.SpaceMember.role:type_name -> memos.api.v1.SpaceMember.Role + 0, // 2: memos.api.v1.SpaceInvitation.role:type_name -> memos.api.v1.SpaceMember.Role + 1, // 3: memos.api.v1.SpaceInvitation.space:type_name -> memos.api.v1.Space + 1, // 4: memos.api.v1.CreateSpaceRequest.space:type_name -> memos.api.v1.Space + 1, // 5: memos.api.v1.ListSpacesResponse.spaces:type_name -> memos.api.v1.Space + 1, // 6: memos.api.v1.UpdateSpaceRequest.space:type_name -> memos.api.v1.Space + 24, // 7: memos.api.v1.UpdateSpaceRequest.update_mask:type_name -> google.protobuf.FieldMask + 3, // 8: memos.api.v1.CreateSpaceInvitationRequest.space_invitation:type_name -> memos.api.v1.SpaceInvitation + 3, // 9: memos.api.v1.ListSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation + 3, // 10: memos.api.v1.ListUserSpaceInvitationsResponse.space_invitations:type_name -> memos.api.v1.SpaceInvitation + 2, // 11: memos.api.v1.ListSpaceMembersResponse.space_members:type_name -> memos.api.v1.SpaceMember + 2, // 12: memos.api.v1.UpdateSpaceMemberRequest.space_member:type_name -> memos.api.v1.SpaceMember + 24, // 13: memos.api.v1.UpdateSpaceMemberRequest.update_mask:type_name -> google.protobuf.FieldMask + 4, // 14: memos.api.v1.SpaceService.CreateSpace:input_type -> memos.api.v1.CreateSpaceRequest + 5, // 15: memos.api.v1.SpaceService.ListSpaces:input_type -> memos.api.v1.ListSpacesRequest + 7, // 16: memos.api.v1.SpaceService.GetSpace:input_type -> memos.api.v1.GetSpaceRequest + 8, // 17: memos.api.v1.SpaceService.UpdateSpace:input_type -> memos.api.v1.UpdateSpaceRequest + 9, // 18: memos.api.v1.SpaceService.DeleteSpace:input_type -> memos.api.v1.DeleteSpaceRequest + 10, // 19: memos.api.v1.SpaceService.CreateSpaceInvitation:input_type -> memos.api.v1.CreateSpaceInvitationRequest + 11, // 20: memos.api.v1.SpaceService.ListSpaceInvitations:input_type -> memos.api.v1.ListSpaceInvitationsRequest + 13, // 21: memos.api.v1.SpaceService.ListUserSpaceInvitations:input_type -> memos.api.v1.ListUserSpaceInvitationsRequest + 15, // 22: memos.api.v1.SpaceService.GetSpaceInvitation:input_type -> memos.api.v1.GetSpaceInvitationRequest + 16, // 23: memos.api.v1.SpaceService.DeleteSpaceInvitation:input_type -> memos.api.v1.DeleteSpaceInvitationRequest + 17, // 24: memos.api.v1.SpaceService.AcceptSpaceInvitation:input_type -> memos.api.v1.AcceptSpaceInvitationRequest + 18, // 25: memos.api.v1.SpaceService.DeclineSpaceInvitation:input_type -> memos.api.v1.DeclineSpaceInvitationRequest + 19, // 26: memos.api.v1.SpaceService.ListSpaceMembers:input_type -> memos.api.v1.ListSpaceMembersRequest + 21, // 27: memos.api.v1.SpaceService.GetSpaceMember:input_type -> memos.api.v1.GetSpaceMemberRequest + 22, // 28: memos.api.v1.SpaceService.UpdateSpaceMember:input_type -> memos.api.v1.UpdateSpaceMemberRequest + 23, // 29: memos.api.v1.SpaceService.DeleteSpaceMember:input_type -> memos.api.v1.DeleteSpaceMemberRequest + 1, // 30: memos.api.v1.SpaceService.CreateSpace:output_type -> memos.api.v1.Space + 6, // 31: memos.api.v1.SpaceService.ListSpaces:output_type -> memos.api.v1.ListSpacesResponse + 1, // 32: memos.api.v1.SpaceService.GetSpace:output_type -> memos.api.v1.Space + 1, // 33: memos.api.v1.SpaceService.UpdateSpace:output_type -> memos.api.v1.Space + 25, // 34: memos.api.v1.SpaceService.DeleteSpace:output_type -> google.protobuf.Empty + 3, // 35: memos.api.v1.SpaceService.CreateSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation + 12, // 36: memos.api.v1.SpaceService.ListSpaceInvitations:output_type -> memos.api.v1.ListSpaceInvitationsResponse + 14, // 37: memos.api.v1.SpaceService.ListUserSpaceInvitations:output_type -> memos.api.v1.ListUserSpaceInvitationsResponse + 3, // 38: memos.api.v1.SpaceService.GetSpaceInvitation:output_type -> memos.api.v1.SpaceInvitation + 25, // 39: memos.api.v1.SpaceService.DeleteSpaceInvitation:output_type -> google.protobuf.Empty + 2, // 40: memos.api.v1.SpaceService.AcceptSpaceInvitation:output_type -> memos.api.v1.SpaceMember + 25, // 41: memos.api.v1.SpaceService.DeclineSpaceInvitation:output_type -> google.protobuf.Empty + 20, // 42: memos.api.v1.SpaceService.ListSpaceMembers:output_type -> memos.api.v1.ListSpaceMembersResponse + 2, // 43: memos.api.v1.SpaceService.GetSpaceMember:output_type -> memos.api.v1.SpaceMember + 2, // 44: memos.api.v1.SpaceService.UpdateSpaceMember:output_type -> memos.api.v1.SpaceMember + 25, // 45: memos.api.v1.SpaceService.DeleteSpaceMember:output_type -> google.protobuf.Empty + 30, // [30:46] is the sub-list for method output_type + 14, // [14:30] is the sub-list for method input_type + 14, // [14:14] is the sub-list for extension type_name + 14, // [14:14] is the sub-list for extension extendee + 0, // [0:14] is the sub-list for field type_name } func init() { file_api_v1_space_service_proto_init() } diff --git a/proto/gen/openapi.yaml b/proto/gen/openapi.yaml index 64db8508..65dfa8d5 100644 --- a/proto/gen/openapi.yaml +++ b/proto/gen/openapi.yaml @@ -4376,6 +4376,24 @@ components: description: type: string description: Optional. A description of the space. + currentUserRole: + readOnly: true + enum: + - ROLE_UNSPECIFIED + - ADMIN + - USER + type: string + description: |- + Output only. The authenticated user's membership role in this space. + ROLE_UNSPECIFIED when this Space is exposed as metadata-only. + format: enum + memberCount: + readOnly: true + type: integer + description: |- + Output only. The number of accepted members in this space. Pending + invitations are excluded. Zero when this Space is exposed as metadata-only. + format: int32 description: Space is a collaboration boundary for placed memos. SpaceInvitation: required: diff --git a/server/router/api/v1/space_service.go b/server/router/api/v1/space_service.go index cd326fd8..ea80868a 100644 --- a/server/router/api/v1/space_service.go +++ b/server/router/api/v1/space_service.go @@ -106,7 +106,7 @@ func (s *APIV1Service) CreateSpace(ctx context.Context, request *v1pb.CreateSpac if err != nil { return nil, mapSpaceMutationError(err, "failed to create space") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return convertSpaceFromStore(created), nil } @@ -212,7 +212,7 @@ func (s *APIV1Service) UpdateSpace(ctx context.Context, request *v1pb.UpdateSpac if updated == nil { return nil, status.Error(codes.NotFound, "space not found") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return convertSpaceFromStore(updated), nil } @@ -234,7 +234,7 @@ func (s *APIV1Service) DeleteSpace(ctx context.Context, request *v1pb.DeleteSpac if err != nil { return nil, mapSpaceMutationError(err, "failed to delete space") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() if err := s.cleanupDeletedAttachmentStorage(ctx, deleteResult.Attachments); err != nil { return nil, status.Errorf(codes.Internal, "space was deleted but attachment storage cleanup failed: %v", err) } @@ -288,7 +288,7 @@ func (s *APIV1Service) CreateSpaceInvitation(ctx context.Context, request *v1pb. if err != nil { return nil, mapSpaceMutationError(err, "failed to create space invitation") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return convertSpaceInvitationFromStore(space, targetUser, created), nil } @@ -500,7 +500,7 @@ func (s *APIV1Service) DeleteSpaceInvitation(ctx context.Context, request *v1pb. }, currentUser.ID); err != nil { return nil, mapSpaceMutationError(err, "failed to revoke space invitation") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return &emptypb.Empty{}, nil } @@ -522,7 +522,7 @@ func (s *APIV1Service) AcceptSpaceInvitation(ctx context.Context, request *v1pb. if err != nil { return nil, mapSpaceMutationError(err, "failed to accept space invitation") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return convertSpaceMemberFromStore(space, currentUser, member), nil } @@ -543,7 +543,7 @@ func (s *APIV1Service) DeclineSpaceInvitation(ctx context.Context, request *v1pb if err := s.Store.DeclineSpaceInvitation(ctx, &store.DeclineSpaceInvitation{SpaceID: invitation.SpaceID, UserID: currentUser.ID}, currentUser.ID); err != nil { return nil, mapSpaceMutationError(err, "failed to decline space invitation") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return &emptypb.Empty{}, nil } @@ -712,7 +712,7 @@ func (s *APIV1Service) UpdateSpaceMember(ctx context.Context, request *v1pb.Upda if updated == nil { return nil, status.Error(codes.NotFound, "space member not found") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return convertSpaceMemberFromStore(space, targetUser, updated), nil } @@ -738,6 +738,6 @@ func (s *APIV1Service) DeleteSpaceMember(ctx context.Context, request *v1pb.Dele }, currentUser.ID); err != nil { return nil, mapSpaceMutationError(err, "failed to delete space member") } - s.SSEHub.publishMemoChanged() + s.SSEHub.publishSpaceChanged() return &emptypb.Empty{}, nil } diff --git a/server/router/api/v1/space_service_converters.go b/server/router/api/v1/space_service_converters.go index 14b7cdce..7bda669f 100644 --- a/server/router/api/v1/space_service_converters.go +++ b/server/router/api/v1/space_service_converters.go @@ -18,6 +18,16 @@ func buildSpaceInvitationName(spaceUID, username string) string { } func convertSpaceFromStore(space *store.Space) *v1pb.Space { + converted := convertSpaceMetadataFromStore(space) + if converted == nil { + return nil + } + converted.CurrentUserRole = convertSpaceMemberRoleFromStore(space.CurrentUserRole) + converted.MemberCount = space.MemberCount + return converted +} + +func convertSpaceMetadataFromStore(space *store.Space) *v1pb.Space { if space == nil { return nil } @@ -69,6 +79,6 @@ func convertSpaceInvitationFromStore(space *store.Space, user *store.User, invit Name: buildSpaceInvitationName(space.UID, user.Username), Invitee: BuildUserName(user.Username), Role: convertSpaceMemberRoleFromStore(invitation.Role), - Space: convertSpaceFromStore(space), + Space: convertSpaceMetadataFromStore(space), } } diff --git a/server/router/api/v1/space_service_test.go b/server/router/api/v1/space_service_test.go index 10c77a92..34d7dad5 100644 --- a/server/router/api/v1/space_service_test.go +++ b/server/router/api/v1/space_service_test.go @@ -66,6 +66,8 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) { require.NoError(t, err) require.Equal(t, "spaces/team-notes", space.Name) require.Equal(t, "Team notes", space.Title) + require.Equal(t, v1pb.SpaceMember_ADMIN, space.CurrentUserRole) + require.Equal(t, int32(1), space.MemberCount) _, err = service.CreateSpace(userCtx(ctx, owner.ID), &v1pb.CreateSpaceRequest{ SpaceId: "team-notes", Space: &v1pb.Space{Title: "Duplicate"}, @@ -89,7 +91,11 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) { }) require.NoError(t, err) require.Equal(t, "spaces/team-notes/invitations/space-member", invitation.Name) - require.Equal(t, space, invitation.Space, "the invitation must identify the Space without granting membership access") + require.Equal(t, space.Name, invitation.Space.Name, "the invitation must identify the Space without granting membership access") + require.Equal(t, space.Title, invitation.Space.Title) + require.Equal(t, space.Description, invitation.Space.Description) + require.Equal(t, v1pb.SpaceMember_ROLE_UNSPECIFIED, invitation.Space.CurrentUserRole) + require.Zero(t, invitation.Space.MemberCount) _, err = service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name}) require.Equal(t, codes.NotFound, status.Code(err), "a pending invitation must not grant Space access") @@ -122,8 +128,22 @@ func TestSpaceServiceMembershipVisibilityAndGovernance(t *testing.T) { _, err = service.GetSpaceInvitation(userCtx(ctx, owner.ID), &v1pb.GetSpaceInvitationRequest{Name: invitation.Name}) require.Equal(t, codes.NotFound, status.Code(err)) - _, err = service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name}) + memberSpace, err := service.GetSpace(userCtx(ctx, member.ID), &v1pb.GetSpaceRequest{Name: space.Name}) require.NoError(t, err) + require.Equal(t, v1pb.SpaceMember_USER, memberSpace.CurrentUserRole) + require.Equal(t, int32(2), memberSpace.MemberCount) + memberSpaces, err := service.ListSpaces(userCtx(ctx, member.ID), &v1pb.ListSpacesRequest{}) + require.NoError(t, err) + require.Len(t, memberSpaces.Spaces, 1) + require.Equal(t, v1pb.SpaceMember_USER, memberSpaces.Spaces[0].CurrentUserRole) + require.Equal(t, int32(2), memberSpaces.Spaces[0].MemberCount) + updatedSpace, err := service.UpdateSpace(userCtx(ctx, owner.ID), &v1pb.UpdateSpaceRequest{ + Space: &v1pb.Space{Name: space.Name, Title: "Updated team notes"}, + UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}}, + }) + require.NoError(t, err) + require.Equal(t, v1pb.SpaceMember_ADMIN, updatedSpace.CurrentUserRole) + require.Equal(t, int32(2), updatedSpace.MemberCount) _, err = service.UpdateSpace(userCtx(ctx, member.ID), &v1pb.UpdateSpaceRequest{ Space: &v1pb.Space{Name: space.Name, Title: "not allowed"}, UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}}, diff --git a/server/router/api/v1/sse_hub.go b/server/router/api/v1/sse_hub.go index 765a585d..e624dbc0 100644 --- a/server/router/api/v1/sse_hub.go +++ b/server/router/api/v1/sse_hub.go @@ -5,6 +5,7 @@ import "sync" const ( sseClientEventBufferSize = 32 memoChangedSSEFrame = "data: {\"type\":\"memo.changed\"}\n\n" + spaceChangedSSEFrame = "data: {\"type\":\"space.changed\"}\n\n" ) // SSEClient represents a single SSE connection. @@ -78,8 +79,17 @@ func (h *SSEHub) Close() { // Slow clients with a full buffer are disconnected so they can reconnect and // resynchronize instead of silently missing an event. func (h *SSEHub) publishMemoChanged() { - frame := []byte(memoChangedSSEFrame) + h.publish([]byte(memoChangedSSEFrame)) +} +// publishSpaceChanged tells connected clients to refresh Space-backed caches +// and caches whose visibility or presentation depends on Space state. +// Like memo.changed, the event carries no authorization-sensitive data. +func (h *SSEHub) publishSpaceChanged() { + h.publish([]byte(spaceChangedSSEFrame)) +} + +func (h *SSEHub) publish(frame []byte) { var slowClients []*SSEClient h.mu.RLock() for c := range h.clients { diff --git a/server/router/api/v1/sse_hub_test.go b/server/router/api/v1/sse_hub_test.go index 5e25976a..06f01ebf 100644 --- a/server/router/api/v1/sse_hub_test.go +++ b/server/router/api/v1/sse_hub_test.go @@ -83,6 +83,22 @@ func TestSSEHubPublishMemoChangedBroadcastsToSubscribers(t *testing.T) { } } +func TestSSEHubPublishSpaceChangedBroadcastsDistinctFrame(t *testing.T) { + hub := NewSSEHub() + first := hub.Subscribe() + defer hub.Unsubscribe(first) + second := hub.Subscribe() + defer hub.Unsubscribe(second) + + hub.publishSpaceChanged() + + for _, client := range []*SSEClient{first, second} { + frame := string(mustReceive(t, client.events, time.Second)) + assert.Equal(t, spaceChangedSSEFrame, frame) + assert.NotEqual(t, memoChangedSSEFrame, frame) + } +} + func TestSSEHubSlowClientIsDisconnected(t *testing.T) { hub := NewSSEHub() slow := hub.Subscribe() diff --git a/server/router/api/v1/sse_service_test.go b/server/router/api/v1/sse_service_test.go index fd13bc14..454c3e6d 100644 --- a/server/router/api/v1/sse_service_test.go +++ b/server/router/api/v1/sse_service_test.go @@ -57,6 +57,11 @@ func requireMemoChanged(t *testing.T, ch <-chan []byte) { require.Equal(t, memoChangedSSEFrame, string(mustReceive(t, ch, time.Second))) } +func requireSpaceChanged(t *testing.T, ch <-chan []byte) { + t.Helper() + require.Equal(t, spaceChangedSSEFrame, string(mustReceive(t, ch, time.Second))) +} + func requireNoMemoChanged(t *testing.T, ch <-chan []byte) { t.Helper() select { @@ -223,7 +228,7 @@ func TestDeleteAttachmentPublishesBeforeStorageCleanupFailure(t *testing.T) { require.Nil(t, storedAttachment, "the database deletion must remain committed") } -func TestSpaceMutationsPublishMemoChanged(t *testing.T) { +func TestSpaceMutationsPublishSpaceChanged(t *testing.T) { ctx := context.Background() svc := newIntegrationService(t) owner := createSpaceTestUser(ctx, t, svc, "sse-space-owner", store.RoleAdmin) @@ -237,7 +242,7 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) { Space: &v1pb.Space{Title: "SSE Space"}, }) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) space.Title = "Renamed SSE Space" _, err = svc.UpdateSpace(ownerCtx, &v1pb.UpdateSpaceRequest{ @@ -245,17 +250,17 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) { UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}}, }) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) invitation, err := svc.CreateSpaceInvitation(ownerCtx, &v1pb.CreateSpaceInvitationRequest{ Parent: space.Name, SpaceInvitation: &v1pb.SpaceInvitation{Invitee: BuildUserName(member.Username), Role: v1pb.SpaceMember_USER}, }) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) membership, err := svc.AcceptSpaceInvitation(userCtx(ctx, member.ID), &v1pb.AcceptSpaceInvitationRequest{Name: invitation.Name}) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) membership.Role = v1pb.SpaceMember_ADMIN _, err = svc.UpdateSpaceMember(ownerCtx, &v1pb.UpdateSpaceMemberRequest{ @@ -263,15 +268,15 @@ func TestSpaceMutationsPublishMemoChanged(t *testing.T) { UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"role"}}, }) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) _, err = svc.DeleteSpaceMember(ownerCtx, &v1pb.DeleteSpaceMemberRequest{Name: membership.Name}) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) _, err = svc.DeleteSpace(ownerCtx, &v1pb.DeleteSpaceRequest{Name: space.Name}) require.NoError(t, err) - requireMemoChanged(t, client.events) + requireSpaceChanged(t, client.events) } func TestUpdateMemoSSEBroadcastsToAllSubscribers(t *testing.T) { diff --git a/store/db/mysql/space.go b/store/db/mysql/space.go index 57b02d28..25c64461 100644 --- a/store/db/mysql/space.go +++ b/store/db/mysql/space.go @@ -45,6 +45,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int if err != nil { return nil, err } + space.CurrentUserRole = store.SpaceMemberRoleAdmin + space.MemberCount = 1 if err := tx.Commit(); err != nil { return nil, err } @@ -53,6 +55,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) { where, args := []string{"1 = 1"}, []any{} + selectFields := "space.id, space.uid, space.title, space.description" + joins := "" + groupBy := "" if find.ID != nil { where, args = append(where, "space.id = ?"), append(args, *find.ID) } @@ -68,10 +73,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp where, args = append(where, "space.uid = ?"), append(args, *find.UID) } if find.MemberUserID != nil { - where, args = append(where, "EXISTS (SELECT 1 FROM space_member sm JOIN user u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = ? AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')"), append(args, *find.MemberUserID) + selectFields += ", viewer_member.role, COUNT(active_member.user_id)" + joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id + JOIN user viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'` + where = append(where, "viewer_member.user_id = ?", "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'") + args = append(args, *find.MemberUserID) + groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role" } - query := `SELECT space.id, space.uid, space.title, space.description - FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC` + query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC" query = appendMySQLLimit(query, find.Limit, find.Offset) rows, err := d.db.QueryContext(ctx, query, args...) if err != nil { @@ -81,7 +92,7 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp spaces := []*store.Space{} for rows.Next() { space := &store.Space{} - if err := scanMySQLSpace(rows, space); err != nil { + if err := scanMySQLSpaceWithSummary(rows, space, find.MemberUserID != nil); err != nil { return nil, err } spaces = append(spaces, space) @@ -116,6 +127,9 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs if err != nil { return nil, err } + if err := populateMySQLSpaceSummary(ctx, tx, space, actorUserID); err != nil { + return nil, err + } if err := tx.Commit(); err != nil { return nil, err } @@ -423,6 +437,24 @@ func scanMySQLSpace(row mysqlRowScanner, space *store.Space) error { return row.Scan(&space.ID, &space.UID, &space.Title, &space.Description) } +func scanMySQLSpaceWithSummary(row mysqlRowScanner, space *store.Space, withSummary bool) error { + if !withSummary { + return scanMySQLSpace(row, space) + } + return row.Scan(&space.ID, &space.UID, &space.Title, &space.Description, &space.CurrentUserRole, &space.MemberCount) +} + +func populateMySQLSpaceSummary(ctx context.Context, tx *sql.Tx, space *store.Space, userID int32) error { + return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id) + FROM space_member viewer_member + JOIN user viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL' + WHERE viewer_member.space_id = ? AND viewer_member.user_id = ? AND viewer_member.status = 'ACTIVE' + AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL' + GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount) +} + func getMySQLSpace(ctx context.Context, tx *sql.Tx, id int32) (*store.Space, error) { space := &store.Space{} return space, scanMySQLSpace(tx.QueryRowContext(ctx, `SELECT id, uid, title, description FROM space WHERE id = ?`, id), space) diff --git a/store/db/postgres/space.go b/store/db/postgres/space.go index d53acd33..8fceb2c6 100644 --- a/store/db/postgres/space.go +++ b/store/db/postgres/space.go @@ -36,6 +36,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int if _, err := tx.ExecContext(ctx, "INSERT INTO space_member (space_id, user_id, status, role) VALUES ($1, $2, $3, $4)", space.ID, creatorID, store.SpaceMemberStatusActive, store.SpaceMemberRoleAdmin); err != nil { return nil, err } + space.CurrentUserRole = store.SpaceMemberRoleAdmin + space.MemberCount = 1 if err := tx.Commit(); err != nil { return nil, err } @@ -44,6 +46,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) { where, args := []string{"1 = 1"}, []any{} + selectFields := "space.id, space.uid, space.title, space.description" + joins := "" + groupBy := "" add := func(condition string, value any) { args = append(args, value) where = append(where, fmt.Sprintf(condition, placeholder(len(args)))) @@ -63,10 +68,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp add("space.uid = %s", *find.UID) } if find.MemberUserID != nil { - add(`EXISTS (SELECT 1 FROM space_member sm JOIN "user" u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = %s AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')`, *find.MemberUserID) + selectFields += ", viewer_member.role, COUNT(active_member.user_id)" + joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id + JOIN "user" viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN "user" active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'` + add("viewer_member.user_id = %s", *find.MemberUserID) + where = append(where, "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'") + groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role" } - query := `SELECT space.id, space.uid, space.title, space.description - FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC` + query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC" query = appendPostgresLimit(query, find.Limit, find.Offset) rows, err := d.db.QueryContext(ctx, query, args...) if err != nil { @@ -76,7 +87,11 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp spaces := []*store.Space{} for rows.Next() { space := &store.Space{} - if err := rows.Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil { + scanTargets := []any{&space.ID, &space.UID, &space.Title, &space.Description} + if find.MemberUserID != nil { + scanTargets = append(scanTargets, &space.CurrentUserRole, &space.MemberCount) + } + if err := rows.Scan(scanTargets...); err != nil { return nil, err } spaces = append(spaces, space) @@ -113,12 +128,26 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs if err := tx.QueryRowContext(ctx, query, args...).Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil { return nil, err } + if err := populatePostgresSpaceSummary(ctx, tx, space, actorUserID); err != nil { + return nil, err + } if err := tx.Commit(); err != nil { return nil, err } return space, nil } +func populatePostgresSpaceSummary(ctx context.Context, tx *sql.Tx, space *store.Space, userID int32) error { + return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id) + FROM space_member viewer_member + JOIN "user" viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN "user" active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL' + WHERE viewer_member.space_id = $1 AND viewer_member.user_id = $2 AND viewer_member.status = 'ACTIVE' + AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL' + GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount) +} + func (d *DB) CreateSpaceInvitation(ctx context.Context, create *store.SpaceInvitation, actorUserID int32) (*store.SpaceInvitation, error) { tx, err := d.db.BeginTx(ctx, nil) if err != nil { diff --git a/store/db/sqlite/space.go b/store/db/sqlite/space.go index 021dd914..1bb22471 100644 --- a/store/db/sqlite/space.go +++ b/store/db/sqlite/space.go @@ -37,6 +37,8 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int if _, err := tx.ExecContext(ctx, "INSERT INTO space_member (space_id, user_id, status, role) VALUES (?, ?, ?, ?)", space.ID, creatorID, store.SpaceMemberStatusActive, store.SpaceMemberRoleAdmin); err != nil { return nil, errors.Wrap(err, "failed to create initial space admin") } + space.CurrentUserRole = store.SpaceMemberRoleAdmin + space.MemberCount = 1 if err := tx.Commit(); err != nil { return nil, errors.Wrap(err, "failed to commit space create transaction") } @@ -45,6 +47,9 @@ func (d *DB) CreateSpace(ctx context.Context, create *store.Space, creatorID int func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Space, error) { where, args := []string{"1 = 1"}, []any{} + selectFields := "space.id, space.uid, space.title, space.description" + joins := "" + groupBy := "" if find.ID != nil { where, args = append(where, "space.id = ?"), append(args, *find.ID) } @@ -60,10 +65,16 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp where, args = append(where, "space.uid = ?"), append(args, *find.UID) } if find.MemberUserID != nil { - where, args = append(where, "EXISTS (SELECT 1 FROM space_member sm JOIN user u ON u.id = sm.user_id WHERE sm.space_id = space.id AND sm.user_id = ? AND sm.status = 'ACTIVE' AND sm.role IN ('ADMIN', 'USER') AND u.row_status = 'NORMAL')"), append(args, *find.MemberUserID) + selectFields += ", viewer_member.role, COUNT(active_member.user_id)" + joins = ` JOIN space_member viewer_member ON viewer_member.space_id = space.id + JOIN user viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = space.id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL'` + where = append(where, "viewer_member.user_id = ?", "viewer_member.status = 'ACTIVE'", "viewer_member.role IN ('ADMIN', 'USER')", "viewer_user.row_status = 'NORMAL'") + args = append(args, *find.MemberUserID) + groupBy = " GROUP BY space.id, space.uid, space.title, space.description, viewer_member.role" } - query := `SELECT space.id, space.uid, space.title, space.description - FROM space WHERE ` + strings.Join(where, " AND ") + ` ORDER BY space.id DESC` + query := "SELECT " + selectFields + " FROM space" + joins + " WHERE " + strings.Join(where, " AND ") + groupBy + " ORDER BY space.id DESC" query = appendSQLiteLimit(query, find.Limit, find.Offset) rows, err := d.db.QueryContext(ctx, query, args...) if err != nil { @@ -73,7 +84,11 @@ func (d *DB) ListSpaces(ctx context.Context, find *store.FindSpace) ([]*store.Sp spaces := []*store.Space{} for rows.Next() { space := &store.Space{} - if err := rows.Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil { + scanTargets := []any{&space.ID, &space.UID, &space.Title, &space.Description} + if find.MemberUserID != nil { + scanTargets = append(scanTargets, &space.CurrentUserRole, &space.MemberCount) + } + if err := rows.Scan(scanTargets...); err != nil { return nil, err } spaces = append(spaces, space) @@ -104,12 +119,26 @@ func (d *DB) UpdateSpace(ctx context.Context, update *store.UpdateSpace, actorUs if err := tx.QueryRowContext(ctx, query, args...).Scan(&space.ID, &space.UID, &space.Title, &space.Description); err != nil { return nil, err } + if err := populateSQLiteSpaceSummary(ctx, tx, space, actorUserID); err != nil { + return nil, err + } if err := tx.Commit(); err != nil { return nil, err } return space, nil } +func populateSQLiteSpaceSummary(ctx context.Context, tx dbExecutor, space *store.Space, userID int32) error { + return tx.QueryRowContext(ctx, `SELECT viewer_member.role, COUNT(active_member.user_id) + FROM space_member viewer_member + JOIN user viewer_user ON viewer_user.id = viewer_member.user_id + JOIN space_member active_member ON active_member.space_id = viewer_member.space_id AND active_member.status = 'ACTIVE' AND active_member.role IN ('ADMIN', 'USER') + JOIN user active_user ON active_user.id = active_member.user_id AND active_user.row_status = 'NORMAL' + WHERE viewer_member.space_id = ? AND viewer_member.user_id = ? AND viewer_member.status = 'ACTIVE' + AND viewer_member.role IN ('ADMIN', 'USER') AND viewer_user.row_status = 'NORMAL' + GROUP BY viewer_member.role`, space.ID, userID).Scan(&space.CurrentUserRole, &space.MemberCount) +} + func (d *DB) CreateSpaceInvitation(ctx context.Context, create *store.SpaceInvitation, actorUserID int32) (*store.SpaceInvitation, error) { tx, err := d.db.BeginTx(ctx, nil) if err != nil { diff --git a/store/space.go b/store/space.go index 98a57d02..e194fea4 100644 --- a/store/space.go +++ b/store/space.go @@ -68,13 +68,16 @@ func (r SpaceMemberRole) IsActiveMember() bool { type Space struct { ID int32 - UID string - Title string - Description string + UID string + Title string + Description string + CurrentUserRole SpaceMemberRole + MemberCount int32 } // FindSpace selects spaces. MemberUserID restricts results to spaces where the -// user has a membership and is applied before pagination. +// user has a membership, populates the viewer summary, and is applied before +// pagination. type FindSpace struct { ID *int32 IDList []int32 diff --git a/store/test/space_test.go b/store/test/space_test.go index da46009a..f766f2c6 100644 --- a/store/test/space_test.go +++ b/store/test/space_test.go @@ -21,6 +21,8 @@ func TestSpaceStoreMembershipGuards(t *testing.T) { space, err := ts.CreateSpace(ctx, &store.Space{UID: "space-store", Title: "Store Space"}, owner.ID) require.NoError(t, err) + require.Equal(t, store.SpaceMemberRoleAdmin, space.CurrentUserRole) + require.Equal(t, int32(1), space.MemberCount) ownerMembership, err := ts.GetSpaceMember(ctx, &store.FindSpaceMember{SpaceID: &space.ID, UserID: &owner.ID, ViewerUserID: &owner.ID}) require.NoError(t, err) @@ -29,6 +31,24 @@ func TestSpaceStoreMembershipGuards(t *testing.T) { created, err := createSpaceMemberForTest(ctx, ts, &store.SpaceMember{SpaceID: space.ID, UserID: member.ID, Role: store.SpaceMemberRoleUser}, owner.ID) require.NoError(t, err) require.Equal(t, member.ID, created.UserID) + ownerSpaces, err := ts.ListSpaces(ctx, &store.FindSpace{MemberUserID: &owner.ID}) + require.NoError(t, err) + require.Len(t, ownerSpaces, 1) + require.Equal(t, store.SpaceMemberRoleAdmin, ownerSpaces[0].CurrentUserRole) + require.Equal(t, int32(2), ownerSpaces[0].MemberCount) + memberSpace, err := ts.GetSpace(ctx, &store.FindSpace{UID: &space.UID, MemberUserID: &member.ID}) + require.NoError(t, err) + require.Equal(t, store.SpaceMemberRoleUser, memberSpace.CurrentUserRole) + require.Equal(t, int32(2), memberSpace.MemberCount) + unscopedSpace, err := ts.GetSpace(ctx, &store.FindSpace{UID: &space.UID}) + require.NoError(t, err) + require.Empty(t, unscopedSpace.CurrentUserRole) + require.Zero(t, unscopedSpace.MemberCount) + updatedTitle := "Updated Store Space" + updatedSpace, err := ts.UpdateSpace(ctx, &store.UpdateSpace{ID: space.ID, Title: &updatedTitle}, owner.ID) + require.NoError(t, err) + require.Equal(t, store.SpaceMemberRoleAdmin, updatedSpace.CurrentUserRole) + require.Equal(t, int32(2), updatedSpace.MemberCount) _, err = createSpaceMemberForTest(ctx, ts, &store.SpaceMember{SpaceID: space.ID, UserID: member.ID, Role: store.SpaceMemberRoleUser}, owner.ID) require.ErrorIs(t, err, store.ErrSpaceMemberAlreadyExists) diff --git a/web/src/components/AppSidebar/AppSidebar.tsx b/web/src/components/AppSidebar/AppSidebar.tsx index 83d9f3e0..0b592ba2 100644 --- a/web/src/components/AppSidebar/AppSidebar.tsx +++ b/web/src/components/AppSidebar/AppSidebar.tsx @@ -30,7 +30,7 @@ import { Link, matchPath, useLocation, useNavigate, useSearchParams } from "reac import ConfirmDialog from "@/components/ConfirmDialog"; import { MemoDetailSidebar } from "@/components/MemoDetailSidebar"; import MemoDisplaySettingMenu from "@/components/MemoDisplaySettingMenu"; -import { SETTINGS_SECTIONS } from "@/components/Settings/settingSections"; +import { DEFAULT_SETTING_SECTION, SETTINGS_SECTIONS } from "@/components/Settings/settingSections"; import StatisticsView from "@/components/StatisticsView"; import UserMenu from "@/components/UserMenu"; import { Button } from "@/components/ui/button"; @@ -376,7 +376,7 @@ const SettingsSidebarContent = () => { const user = useCurrentUser(); const { setMobileOpen } = useAppSidebar(); const isHost = user?.role === User_Role.ADMIN; - const currentSection = location.hash.slice(1) || "my-account"; + const currentSection = location.hash.slice(1) || DEFAULT_SETTING_SECTION; const basic = SETTINGS_SECTIONS.filter((section) => section.scope === "basic"); const admin = SETTINGS_SECTIONS.filter((section) => section.scope === "admin"); const renderSections = (sections: typeof SETTINGS_SECTIONS) => diff --git a/web/src/components/AppSidebar/SpaceSwitcher.tsx b/web/src/components/AppSidebar/SpaceSwitcher.tsx index acfe7dc4..438b08c9 100644 --- a/web/src/components/AppSidebar/SpaceSwitcher.tsx +++ b/web/src/components/AppSidebar/SpaceSwitcher.tsx @@ -2,6 +2,7 @@ import { CheckIcon, ChevronsUpDownIcon, LoaderCircleIcon, type LucideIcon, PlusI import { type ReactNode, useState } from "react"; import CreateSpaceDialog from "@/components/CreateSpaceDialog"; import MemosLogo from "@/components/MemosLogo"; +import SpaceMark from "@/components/SpaceMark"; import { DropdownMenu, DropdownMenuContent, @@ -13,32 +14,8 @@ import { } from "@/components/ui/dropdown-menu"; import { useSpaceContext } from "@/contexts/SpaceContext"; import { cn } from "@/lib/utils"; -import type { Space } from "@/types/proto/api/v1/space_service_pb"; import { useTranslate } from "@/utils/i18n"; -// Mirrors MemosLogo's compact scale so the brand and a Space read as peers in the menu. -const MARK_SCALE = { - md: "size-7 rounded-[7px] text-[13px]", - sm: "size-5 rounded-[5px] text-[11px]", -} as const; - -const SpaceMark = ({ space, size = "md" }: { space?: Space; size?: "sm" | "md" }) => { - const label = space?.title.trim() || "S"; - const initial = Array.from(label)[0]?.toLocaleUpperCase() ?? "S"; - - return ( - - {initial} - - ); -}; - // Icons in action and status rows sit in a glyph-width slot so every label in the menu // starts on the same text rail as the context rows. const RowIcon = ({ icon: Icon, className }: { icon: LucideIcon; className?: string }) => ( @@ -128,7 +105,7 @@ function SpaceSwitcher({ className }: { className?: string }) { - + ); } diff --git a/web/src/components/CreateSpaceDialog.tsx b/web/src/components/CreateSpaceDialog.tsx index 24c86650..e6c23ac7 100644 --- a/web/src/components/CreateSpaceDialog.tsx +++ b/web/src/components/CreateSpaceDialog.tsx @@ -5,21 +5,22 @@ import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, D import { Input } from "@/components/ui/input"; import { Label } from "@/components/ui/label"; import { Textarea } from "@/components/ui/textarea"; -import { useSpaceContext } from "@/contexts/SpaceContext"; import useCurrentUser from "@/hooks/useCurrentUser"; import { useCreateSpace } from "@/hooks/useSpaceQueries"; import { handleError } from "@/lib/error"; +import type { Space } from "@/types/proto/api/v1/space_service_pb"; import { useTranslate } from "@/utils/i18n"; interface Props { open: boolean; onOpenChange: (open: boolean) => void; + onCreated?: (space: Space) => void; + note?: string; } -function CreateSpaceDialog({ open, onOpenChange }: Props) { +function CreateSpaceDialog({ open, onOpenChange, onCreated, note }: Props) { const t = useTranslate(); const currentUserName = useCurrentUser()?.name ?? ""; - const { selectSpace } = useSpaceContext(); const createSpace = useCreateSpace(currentUserName); const [title, setTitle] = useState(""); const [description, setDescription] = useState(""); @@ -38,17 +39,20 @@ function CreateSpaceDialog({ open, onOpenChange }: Props) { return; } + let space: Space; try { - const space = await createSpace.mutateAsync({ + space = await createSpace.mutateAsync({ title: trimmedTitle, description: description.trim() || undefined, }); - selectSpace(space); - toast.success(t("space.create-success")); - onOpenChange(false); } catch (error) { handleError(error, toast.error, { context: "Create space" }); + return; } + + toast.success(t("space.create-success")); + onOpenChange(false); + onCreated?.(space); }; const handleOpenChange = (nextOpen: boolean) => { @@ -87,7 +91,7 @@ function CreateSpaceDialog({ open, onOpenChange }: Props) { className="min-h-20 resize-none" /> -

{t("space.creator-admin-note")}

+

{note ?? t("space.creator-admin-note")}

+ ) : null} + + {normalizedUsername && lookupSettled && usersQuery.isSuccess && !candidate ? ( +

+ {t("setting.spaces.user-not-found", { username: normalizedUsername })} +

+ ) : null} + + +
+ + +

+ {role === SpaceMember_Role.ADMIN ? t("setting.spaces.admin-role-description") : t("setting.spaces.user-role-description")} +

+
+ + + + + + + + + ); +}; + +export default InviteSpaceMemberDialog; diff --git a/web/src/components/Settings/SpacesSection.tsx b/web/src/components/Settings/SpacesSection.tsx new file mode 100644 index 00000000..6ec7eb84 --- /dev/null +++ b/web/src/components/Settings/SpacesSection.tsx @@ -0,0 +1,731 @@ +import { + ArrowLeftIcon, + ChevronRightIcon, + Clock3Icon, + LoaderCircleIcon, + LogOutIcon, + PlusIcon, + ShieldCheckIcon, + Trash2Icon, + UserPlusIcon, +} from "lucide-react"; +import { useEffect, useMemo, useState } from "react"; +import toast from "react-hot-toast"; +import { useNavigate, useSearchParams } from "react-router-dom"; +import ConfirmDialog from "@/components/ConfirmDialog"; +import CreateSpaceDialog from "@/components/CreateSpaceDialog"; +import InviteSpaceMemberDialog from "@/components/Settings/InviteSpaceMemberDialog"; +import SettingSection from "@/components/Settings/SettingSection"; +import SpaceMark from "@/components/SpaceMark"; +import UserAvatar from "@/components/UserAvatar"; +import { Badge } from "@/components/ui/badge"; +import { Button } from "@/components/ui/button"; +import { Input } from "@/components/ui/input"; +import { Label } from "@/components/ui/label"; +import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select"; +import { Tabs, TabsList, TabsTrigger } from "@/components/ui/tabs"; +import { Textarea } from "@/components/ui/textarea"; +import useCurrentUser from "@/hooks/useCurrentUser"; +import { + useAcceptSpaceInvitation, + useDeclineSpaceInvitation, + useDeleteSpace, + useDeleteSpaceInvitation, + useDeleteSpaceMember, + useSpaceInvitations, + useSpaceMembers, + useSpaces, + useUpdateSpace, + useUpdateSpaceMember, + useUserSpaceInvitations, +} from "@/hooks/useSpaceQueries"; +import { useUsersByUsernames } from "@/hooks/useUserQueries"; +import { handleError } from "@/lib/error"; +import { extractUsernameFromName } from "@/lib/resource-names"; +import { ROUTES } from "@/router/routes"; +import { type Space, type SpaceInvitation, type SpaceMember, SpaceMember_Role } from "@/types/proto/api/v1/space_service_pb"; +import type { User } from "@/types/proto/api/v1/user_service_pb"; +import { useTranslate } from "@/utils/i18n"; + +type DetailTab = "general" | "members"; + +const getSpacesSettingsLocation = (spaceName?: string) => ({ + pathname: ROUTES.SETTING, + search: spaceName ? `?${new URLSearchParams({ space: spaceName }).toString()}` : "", + hash: "#spaces", +}); + +const SpaceRoleBadge = ({ role }: { role: SpaceMember_Role }) => { + const t = useTranslate(); + const isAdmin = role === SpaceMember_Role.ADMIN; + return ( + + {isAdmin ? t("setting.spaces.space-admin") : t("setting.spaces.space-user")} + + ); +}; + +const MemberIdentity = ({ member, user, isCurrentUser }: { member: SpaceMember; user?: User; isCurrentUser?: boolean }) => { + const t = useTranslate(); + const username = user?.username || extractUsernameFromName(member.user); + const displayName = user?.displayName || `@${username}`; + + return ( +
+ +
+
+

{displayName}

+ {isCurrentUser ? {t("setting.spaces.you")} : null} +
+

@{username}

+
+
+ ); +}; + +const InvitationIdentity = ({ invitation, user }: { invitation: SpaceInvitation; user?: User }) => { + const username = user?.username || extractUsernameFromName(invitation.invitee); + const displayName = user?.displayName || `@${username}`; + + return ( +
+ +
+

{displayName}

+

@{username}

+
+
+ ); +}; + +const SpacesSection = () => { + const t = useTranslate(); + const navigate = useNavigate(); + const [searchParams] = useSearchParams(); + const currentUser = useCurrentUser(); + const viewerName = currentUser?.name ?? ""; + const managedSpaceName = searchParams.get("space") ?? ""; + const spacesQuery = useSpaces(viewerName); + const receivedInvitationsQuery = useUserSpaceInvitations(viewerName); + const spaces = spacesQuery.data ?? []; + const receivedInvitations = receivedInvitationsQuery.data ?? []; + const managedSpace = spaces.find((space) => space.name === managedSpaceName); + const [createOpen, setCreateOpen] = useState(false); + const acceptInvitation = useAcceptSpaceInvitation(viewerName); + const declineInvitation = useDeclineSpaceInvitation(viewerName); + + useEffect(() => { + if (managedSpaceName && spacesQuery.isSuccess && !managedSpace) { + navigate(getSpacesSettingsLocation(), { replace: true }); + } + }, [managedSpace, managedSpaceName, navigate, spacesQuery.isSuccess]); + + const handleOpenSpace = (spaceName: string) => { + navigate(getSpacesSettingsLocation(spaceName)); + window.scrollTo({ top: 0, behavior: "smooth" }); + }; + + const handleAcceptInvitation = async (invitation: SpaceInvitation) => { + try { + await acceptInvitation.mutateAsync({ name: invitation.name }); + toast.success(t("setting.spaces.accept-success", { space: invitation.space?.title ?? t("setting.spaces.label") })); + } catch (error) { + handleError(error, toast.error, { context: "Accept space invitation" }); + } + }; + + const handleDeclineInvitation = async (invitation: SpaceInvitation) => { + try { + await declineInvitation.mutateAsync({ name: invitation.name }); + toast.success(t("setting.spaces.decline-success")); + } catch (error) { + handleError(error, toast.error, { context: "Decline space invitation" }); + } + }; + + if (managedSpaceName && !managedSpace && spacesQuery.isLoading) { + return ( + +
+ + {t("setting.spaces.loading")} +
+
+ ); + } + + return managedSpace ? ( + navigate(getSpacesSettingsLocation())} + /> + ) : ( + <> + setCreateOpen(true)}> + + {t("setting.spaces.create-space")} + + } + className="gap-5" + > +
+ {receivedInvitations.length > 0 ? ( +
+
+

+ {t("setting.spaces.invitations")} +

+ + {t("setting.spaces.pending-count", { count: receivedInvitations.length })} + +
+
+ {receivedInvitations.map((invitation) => ( +
+
+ +
+
+

{invitation.space?.title || t("setting.spaces.untitled")}

+ +
+

+ {invitation.space?.description || t("setting.spaces.invited-to-join")} +

+
+
+
+ + +
+
+ ))} +
+
+ ) : null} + +
+
+

+ {t("setting.spaces.your-spaces")} +

+ {spaces.length > 0 ? ( + + {spaces.length === 1 + ? t("setting.spaces.space-count", { count: spaces.length }) + : t("setting.spaces.spaces-count", { count: spaces.length })} + + ) : null} +
+ {spacesQuery.isLoading ? ( +
+ + {t("setting.spaces.loading")} +
+ ) : spacesQuery.isError ? ( +
+ {t("setting.spaces.load-error")} +
+ ) : spaces.length === 0 ? ( +
+

{t("setting.spaces.no-spaces")}

+

{t("setting.spaces.no-spaces-description")}

+ +
+ ) : ( +
+ {spaces.map((space) => ( + + ))} +
+ )} +
+
+
+ + navigate(getSpacesSettingsLocation(space.name))} + note={t("setting.spaces.create-scope-note")} + /> + + ); +}; + +interface SpaceDetailProps { + space: Space; + viewerName: string; + onBack: () => void; +} + +const SpaceDetail = ({ space, viewerName, onBack }: SpaceDetailProps) => { + const t = useTranslate(); + const membersQuery = useSpaceMembers(viewerName, space.name); + const members = membersQuery.data ?? []; + const currentMember = members.find((member) => member.user === viewerName); + const currentRole = currentMember?.role ?? space.currentUserRole; + const isAdmin = currentRole === SpaceMember_Role.ADMIN; + const invitationsQuery = useSpaceInvitations(viewerName, space.name, { enabled: isAdmin }); + const invitations = invitationsQuery.data ?? []; + const usernames = useMemo( + () => + Array.from( + new Set( + [...members.map((member) => member.user), ...invitations.map((invitation) => invitation.invitee)].map(extractUsernameFromName), + ), + ), + [invitations, members], + ); + const usersQuery = useUsersByUsernames(usernames); + const usersByUsername = usersQuery.data ?? new Map(); + const [tab, setTab] = useState("general"); + const [title, setTitle] = useState(space.title); + const [description, setDescription] = useState(space.description); + const [inviteOpen, setInviteOpen] = useState(false); + const [leaveOpen, setLeaveOpen] = useState(false); + const [deleteOpen, setDeleteOpen] = useState(false); + const [removeTarget, setRemoveTarget] = useState(); + const [cancelInvitationTarget, setCancelInvitationTarget] = useState(); + const updateSpace = useUpdateSpace(viewerName); + const deleteSpace = useDeleteSpace(viewerName); + const updateMember = useUpdateSpaceMember(viewerName); + const deleteMember = useDeleteSpaceMember(viewerName); + const deleteInvitation = useDeleteSpaceInvitation(viewerName); + const activeAdminCount = members.filter((member) => member.role === SpaceMember_Role.ADMIN).length; + const isLastAdmin = currentRole === SpaceMember_Role.ADMIN && activeAdminCount === 1; + const memberUserNames = useMemo(() => new Set(members.map((member) => member.user)), [members]); + const pendingInviteeNames = useMemo(() => new Set(invitations.map((invitation) => invitation.invitee)), [invitations]); + const roleOptions = [ + { value: String(SpaceMember_Role.USER), label: t("setting.spaces.space-user") }, + { value: String(SpaceMember_Role.ADMIN), label: t("setting.spaces.space-admin") }, + ]; + const detailsChanged = title.trim() !== space.title || description.trim() !== space.description; + + useEffect(() => { + setTitle(space.title); + setDescription(space.description); + }, [space.description, space.title]); + + const handleSave = async () => { + const trimmedTitle = title.trim(); + if (!trimmedTitle || !isAdmin || updateSpace.isPending) return; + try { + await updateSpace.mutateAsync({ + space: { name: space.name, title: trimmedTitle, description: description.trim() }, + updateMask: ["title", "description"], + }); + toast.success(t("setting.spaces.save-success")); + } catch (error) { + handleError(error, toast.error, { context: "Update space" }); + } + }; + + const handleRoleChange = async (member: SpaceMember, role: SpaceMember_Role) => { + if (member.role === role || updateMember.isPending) return; + try { + await updateMember.mutateAsync({ spaceMember: { name: member.name, role }, updateMask: ["role"] }); + toast.success(t("setting.spaces.role-update-success")); + } catch (error) { + handleError(error, toast.error, { context: "Update space member" }); + } + }; + + const handleRemoveMember = async () => { + if (!removeTarget) return; + try { + await deleteMember.mutateAsync({ name: removeTarget.name }); + toast.success(t("setting.spaces.remove-success", { username: extractUsernameFromName(removeTarget.user) })); + setRemoveTarget(undefined); + } catch (error) { + handleError(error, toast.error, { context: "Remove space member" }); + throw error; + } + }; + + const handleCancelInvitation = async () => { + if (!cancelInvitationTarget) return; + try { + await deleteInvitation.mutateAsync({ name: cancelInvitationTarget.name }); + toast.success(t("setting.spaces.cancel-invitation-success")); + setCancelInvitationTarget(undefined); + } catch (error) { + handleError(error, toast.error, { context: "Cancel space invitation" }); + throw error; + } + }; + + const handleLeave = async () => { + if (!currentMember) return; + try { + await deleteMember.mutateAsync({ name: currentMember.name }); + toast.success(t("setting.spaces.leave-success", { space: space.title })); + onBack(); + } catch (error) { + handleError(error, toast.error, { context: "Leave space" }); + throw error; + } + }; + + const handleDeleteSpace = async () => { + try { + await deleteSpace.mutateAsync({ name: space.name }); + toast.success(t("setting.spaces.delete-success", { space: space.title })); + onBack(); + } catch (error) { + handleError(error, toast.error, { context: "Delete space" }); + throw error; + } + }; + + return ( +
+ + +
+ +
+
+

{space.title}

+ +
+

{space.description || t("setting.spaces.no-description")}

+
+
+ + setTab(value as DetailTab)} variant="underline" className="mt-2"> + + + {t("setting.spaces.general")} + + + {t("setting.spaces.members")} + {members.length || space.memberCount} + + + + + {tab === "general" ? ( +
+
+
+

{t("setting.spaces.space-details")}

+

{t("setting.spaces.space-details-description")}

+
+
+
+ + setTitle(event.target.value)} + readOnly={!isAdmin} + className={!isAdmin ? "bg-muted/25" : undefined} + /> +
+
+
+ +

{t("setting.spaces.description-help")}

+
+